From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E764CC4CECE for ; Mon, 14 Oct 2019 09:46:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B1CB020873 for ; Mon, 14 Oct 2019 09:46:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=endlessm-com.20150623.gappssmtp.com header.i=@endlessm-com.20150623.gappssmtp.com header.b="Uj1L73BB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730941AbfJNJq5 (ORCPT ); Mon, 14 Oct 2019 05:46:57 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:46129 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730927AbfJNJq5 (ORCPT ); Mon, 14 Oct 2019 05:46:57 -0400 Received: by mail-qk1-f195.google.com with SMTP id 201so15270929qkd.13 for ; Mon, 14 Oct 2019 02:46:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=endlessm-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lu3kAKNgLKj0l9OS9STf244o7FzKM+AFq67sW2GGwEA=; b=Uj1L73BBDeBKogOWy6V6kJudrhezS8moRSdpCrLY3eY9sVevqZAlfZAlmZMNsqrlct 4XIovLTXE+6nSTwfashjKKTW2PVQ/K6PU9icsADDq339H5d7jT31VyzFjtJW2asPwsdy L0M1pcSU3zUIQdwuXVKawprh1KTIZUtoQ3cjK3vibIrgNXXCjY6G3ttf0De5NBBY/l/+ zPX+pEWj3G8AeMRPKsUZgjzkpJoQt63L+nEAhoMwyIOucJftx3nzAQM2WdBUWdOGHzUk 02Kki+LBpQ/Y4lBCVMqlH5sWxGCAMWbYXCuRwD3gng7oQwVM+7Wdj3gVhhP4tao3K1NB MfDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lu3kAKNgLKj0l9OS9STf244o7FzKM+AFq67sW2GGwEA=; b=Esx/Et06KZ3nxk8apOv32dT9K3uqM6HSGjPwGnEvb1fUfGsuOeJA9UGLoEArP2+eyP dUUkeb5M2jLIZ54hbEDRAvz2cTxkGiKMNLXAtGCIwRkYlzz4WyP+DhWuJpbAJKkyUlmp 4EnyCVtWMlWwOmHB2ozZuypMmGvipXyRsUcs1ClZmHVHM781LUj9muiOOGoqCyiLDhZq fVZURXcbA+fJbER+hyK3G8Pa6ouKlVBSqYHTMKxOIXRSMTOihk+W5xlH1BT2Q8dvjZxP 6pOq6POxobA9lvnGro8USgloKNlf7OYMa9KcLrWjHDFcyduJJH258e5h1NWN4MkzCf+m G6BQ== X-Gm-Message-State: APjAAAURKLg5oJ0TM5v4vBTO+aXJ9Sxj9C/SMGyJz5H2V8cvM4HW33nQ SjHU+RIsKvtmYS+8qME1NGd+gjVkR1rvG5dpWQWp7g== X-Google-Smtp-Source: APXvYqyX4BdAfaAii4xGwBuVXmFyQ/mTRTffh56bnScOrXrCBjFUMfh4PyZVxGpBJtJERVnMwTOvmNlFux+g2AOjz0g= X-Received: by 2002:a37:883:: with SMTP id 125mr28347719qki.478.1571046415923; Mon, 14 Oct 2019 02:46:55 -0700 (PDT) MIME-Version: 1.0 References: <20190927090202.1468-1-drake@endlessm.com> <261805141.5tZyQaKU0z@kreacher> <4883845.KNzyzeMIEj@kreacher> In-Reply-To: <4883845.KNzyzeMIEj@kreacher> From: Daniel Drake Date: Mon, 14 Oct 2019 17:46:44 +0800 Message-ID: Subject: Re: [PATCH] PCI: also apply D3 delay when leaving D3cold To: "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , Bjorn Helgaas , Mathias Nyman , Linux Upstreaming Team , Linux PM , Linux PCI Content-Type: text/plain; charset="UTF-8" Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, Oct 14, 2019 at 5:22 PM Rafael J. Wysocki wrote: > While I still think that both the system resume and runtime resume code paths > should be as similar as reasonably possible, the above needs to be taken into > account IMO, so it is better to retain pci_pm_default_resume_early(), but make > it do a conditional "ACPI power state refresh" and then call > pci_restore_standard_config(). > > So something like the patch below (can you please test it too?). This is also working fine, thanks for your help!