From: Yinghai Lu <yinghai@kernel.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: Commit ef83b0781a73f (PCI: Remove from bus_list and release resources in pci_release_dev()) broke TBT hotplug
Date: Thu, 30 Jan 2014 08:56:05 -0800 [thread overview]
Message-ID: <CAE9FiQUaof1tk151Wbu2OtpTYb+pvP16ZhLsmbn6LDdBqoVEgA@mail.gmail.com> (raw)
In-Reply-To: <CAE9FiQWDqXNF5Cn5X_muBERMWdZsZFbzmoqWvuPARREz+XO9Gw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1692 bytes --]
>> The latest mainline kernel "hangs" when Thunderbolt devices are
>> hot-unplugged to the system. I can't see any oops but after hot-unplug I'm
>> getting huge amounts of messages like:
>>
>> [ 352.717001] pci 0000:02:00.0: PME# disabled
>> [ 352.717011] pci 0000:02:00.0: PME# disabled
>> [ 352.717021] pci 0000:02:00.0: PME# disabled
>> [ 352.717032] pci 0000:02:00.0: PME# disabled
>> [ 352.717041] pci 0000:02:00.0: PME# disabled
>> [ 352.717051] pci 0000:02:00.0: PME# disabled
>> [ 352.717061] pci 0000:02:00.0: PME# disabled
>> [ 352.717070] pci 0000:02:00.0: PME# disabled
>> [ 352.717083] pci 0000:02:00.0: PME# disabled
>> [ 352.717094] pci 0000:02:00.0: PME# disabled
>> [ 352.717104] pci 0000:02:00.0: PME# disabled
>> [ 352.717113] pci 0000:02:00.0: PME# disabled
>> [ 352.717124] pci 0000:02:00.0: PME# disabled
>> [ 352.717133] pci 0000:02:00.0: PME# disabled
>> [ 352.717143] pci 0000:02:00.0: PME# disabled
>> [ 352.717153] pci 0000:02:00.0: PME# disabled
>> [ 352.717162] pci 0000:02:00.0: PME# disabled
>
> that mean pci_stop_dev() get called again and again ?
please check if attached patch could help.
it should prevent possible reattaching driver.
---
drivers/pci/remove.c | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6/drivers/pci/remove.c
===================================================================
--- linux-2.6.orig/drivers/pci/remove.c
+++ linux-2.6/drivers/pci/remove.c
@@ -11,6 +11,7 @@ static void pci_stop_dev(struct pci_dev
pci_proc_detach_device(dev);
pci_remove_sysfs_dev_files(dev);
device_release_driver(&dev->dev);
+ dev->match_driver = false;
dev->is_added = 0;
}
[-- Attachment #2: not_allow_attach_driver.patch --]
[-- Type: text/x-patch, Size: 470 bytes --]
---
drivers/pci/remove.c | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6/drivers/pci/remove.c
===================================================================
--- linux-2.6.orig/drivers/pci/remove.c
+++ linux-2.6/drivers/pci/remove.c
@@ -11,6 +11,7 @@ static void pci_stop_dev(struct pci_dev
pci_proc_detach_device(dev);
pci_remove_sysfs_dev_files(dev);
device_release_driver(&dev->dev);
+ dev->match_driver = false;
dev->is_added = 0;
}
next prev parent reply other threads:[~2014-01-30 16:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 13:12 Commit ef83b0781a73f (PCI: Remove from bus_list and release resources in pci_release_dev()) broke TBT hotplug Mika Westerberg
2014-01-30 16:48 ` Yinghai Lu
2014-01-30 16:56 ` Yinghai Lu [this message]
2014-01-30 23:39 ` Rafael J. Wysocki
2014-01-30 23:39 ` Yinghai Lu
2014-01-30 23:59 ` Rafael J. Wysocki
2014-01-31 0:38 ` Rafael J. Wysocki
2014-01-31 1:39 ` Yinghai Lu
2014-01-31 10:53 ` Mika Westerberg
2014-01-31 11:52 ` Rafael J. Wysocki
2014-01-31 12:36 ` Mika Westerberg
2014-01-31 13:49 ` Rafael J. Wysocki
2014-01-31 13:49 ` Mika Westerberg
2014-01-31 16:41 ` Mika Westerberg
2014-02-01 3:44 ` Yinghai Lu
2014-02-01 3:51 ` Yinghai Lu
2014-02-01 14:35 ` Rafael J. Wysocki
2014-01-31 14:05 ` Rafael J. Wysocki
2014-01-31 0:39 ` Rafael J. Wysocki
2014-01-31 1:04 ` Rafael J. Wysocki
2014-01-31 1:38 ` Yinghai Lu
2014-01-30 23:58 ` Rafael J. Wysocki
2014-01-31 23:34 ` [PATCH] Revert "PCI: Remove from bus_list and release resources in pci_release_dev()" Rafael J. Wysocki
2014-02-01 1:56 ` Yinghai Lu
2014-02-01 14:38 ` Rafael J. Wysocki
2014-02-01 18:23 ` Linus Torvalds
2014-02-01 18:48 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE9FiQUaof1tk151Wbu2OtpTYb+pvP16ZhLsmbn6LDdBqoVEgA@mail.gmail.com \
--to=yinghai@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).