From: Yinghai Lu <yinghai@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Len Brown <lenb@kernel.org>, linux-pci@vger.kernel.org
Subject: Re: [PATCH 00/29] PCI: use pci host bridge to loop pci root bus
Date: Tue, 25 Sep 2012 09:29:08 -0700 [thread overview]
Message-ID: <CAE9FiQUu++bPNree995uY3bGURxJ6hSi8m77ah_8KK6S2aMUaQ@mail.gmail.com> (raw)
In-Reply-To: <CAErSpo5Arj=rh4mZJk3tEsaWKBFqxK6tAu1N5SKn2Cq=vTj+bw@mail.gmail.com>
On Tue, Sep 25, 2012 at 9:23 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> On Tue, Sep 25, 2012 at 2:26 AM, Yinghai Lu <yinghai@kernel.org> wrote:
>> could remove pci_root_buses list.
>>
...
>> PCI: Add dummy bus_type for pci_host_bridge
...
>> PCI: Add for_each_pci_host_bridge() and pci_get_next_host_bridge
>
> I'm not thrilled about adding a new iterator for all host bridges.
>
> The iterator design pattern does not work for collections that can
> change over time. In this case, it looks like you're adding a safer
> way to iterate through all host bridges we know about at this time.
> But we still have the problem of the host bridge that's added
> tomorrow.
>
> I'd prefer a design where the PCI core provides an interface that
> means "call this function for every host bridge we know about now
> *and* for every one that's added in the future."
yes, that is the point to add pci_root_bridge_bus_type. We can register
bus notifier on that.
-Yinghai
next prev parent reply other threads:[~2012-09-25 16:29 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 8:26 [PATCH 00/29] PCI: use pci host bridge to loop pci root bus Yinghai Lu
2012-09-25 8:26 ` [PATCH 01/29] PCI, x86: Separate out pcibios_allocate_bridge_resources() Yinghai Lu
2012-09-25 8:26 ` [PATCH 02/29] PCI. x86: Separate out pcibios_allocate_dev_resources() Yinghai Lu
2012-09-25 8:26 ` [PATCH 03/29] PCI, x86: Let pcibios_allocate_bus_resources() take bus instead Yinghai Lu
2012-09-25 8:26 ` [PATCH 04/29] PCI, x86: Separate out rom resource claim Yinghai Lu
2012-09-25 8:26 ` [PATCH 05/29] PCI: rename pci_release_bus_bridge_dev to pci_release_host_bridge_dev Yinghai Lu
2012-09-25 8:26 ` [PATCH 06/29] PCI: Add dummy bus_type for pci_host_bridge Yinghai Lu
2012-09-25 8:26 ` [PATCH 07/29] PCI, ACPI: add acpi_bus_type for host bridge Yinghai Lu
2012-09-25 8:26 ` [PATCH 08/29] PCI, ACPI: Remove acpi_find_bridge_device for acpi_bus_type Yinghai Lu
2012-09-25 8:26 ` [PATCH 09/29] PCI, libata: remove find_bridge in acpi_bus_type Yinghai Lu
2012-09-25 16:23 ` Jeff Garzik
2012-09-25 8:26 ` [PATCH 10/29] PCI, USB: " Yinghai Lu
2012-09-25 8:35 ` Lan Tianyu
2012-09-25 16:57 ` Yinghai Lu
2012-09-27 20:21 ` Yinghai Lu
2012-09-28 5:48 ` Lan Tianyu
2012-09-25 8:26 ` [PATCH 11/29] PCI, ACPI: " Yinghai Lu
2012-09-25 8:26 ` [PATCH 12/29] PCI: Add for_each_pci_host_bridge() and pci_get_next_host_bridge Yinghai Lu
2012-09-25 14:51 ` Jiang Liu
2012-09-25 14:59 ` Yinghai Lu
2012-09-25 15:04 ` Jiang Liu
2012-09-25 15:56 ` [PATCH] " Jiang Liu
2012-09-25 16:25 ` Yinghai Lu
2012-09-25 8:26 ` [PATCH 13/29] PCI, hotplug: kill pci_find_next_bus n sgi_hotplug Yinghai Lu
2012-09-25 8:26 ` [PATCH 14/29] PCI: kill pci_find_next_bus in pci_sysfs Yinghai Lu
2012-09-25 8:26 ` [PATCH 15/29] PCI, edac: kill pci_find_next_bus in edac Yinghai Lu
2012-09-25 9:20 ` Mauro Carvalho Chehab
2012-09-25 8:26 ` [PATCH 16/29] PCI, x86: kill pci_find_next_bus in pcibios_scan_root Yinghai Lu
2012-09-25 8:26 ` [PATCH 17/29] PCI, x86: kill pci_root_buses in resources reservations Yinghai Lu
2012-09-25 8:26 ` [PATCH 18/29] PCI, drm: kill pci_root_buses in alpha hose setting Yinghai Lu
2012-09-25 8:26 ` [PATCH 19/29] PCI: kill pci_root_buses in setup-bus Yinghai Lu
2012-09-25 8:26 ` [PATCH 20/29] PCI, sparc: kill pci_find_next_bus Yinghai Lu
2012-09-25 8:40 ` Jurij Smakov
2012-09-25 16:33 ` Yinghai Lu
2012-09-25 17:05 ` David Miller
2012-09-25 8:26 ` [PATCH 21/29] PCI, ia64: " Yinghai Lu
2012-09-25 8:26 ` [PATCH 22/29] PCI, alpha: kill pci_root_buses Yinghai Lu
2012-09-25 8:26 ` [PATCH 23/29] PCI, arm: " Yinghai Lu
2012-09-25 8:26 ` [PATCH 24/29] PCI, frv: kill pci_root_buses in resources reservations Yinghai Lu
2012-09-25 8:26 ` [PATCH 25/29] PCI, microblaze: " Yinghai Lu
2012-09-25 8:26 ` [PATCH 26/29] PCI, mn10300: " Yinghai Lu
2012-09-25 8:26 ` [PATCH 27/29] PCI, powerpc: " Yinghai Lu
2012-09-25 8:26 ` [PATCH 28/29] PCI: kill pci_find_next_bus Yinghai Lu
2012-09-25 8:26 ` [PATCH 29/29] PCI: kill pci_root_buses Yinghai Lu
2012-09-25 16:23 ` [PATCH 00/29] PCI: use pci host bridge to loop pci root bus Bjorn Helgaas
2012-09-25 16:29 ` Yinghai Lu [this message]
2012-09-25 17:37 ` Bjorn Helgaas
2012-09-25 18:06 ` Yinghai Lu
2012-09-25 18:19 ` Bjorn Helgaas
2012-09-25 19:17 ` Yinghai Lu
2012-09-25 19:45 ` Bjorn Helgaas
2012-09-25 19:53 ` Yinghai Lu
2012-09-25 20:06 ` Bjorn Helgaas
2012-09-25 22:44 ` Yinghai Lu
2012-09-25 19:38 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE9FiQUu++bPNree995uY3bGURxJ6hSi8m77ah_8KK6S2aMUaQ@mail.gmail.com \
--to=yinghai@kernel.org \
--cc=bhelgaas@google.com \
--cc=lenb@kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).