From: Yinghai Lu <yinghai@kernel.org>
To: Yijing Wang <wangyijing@huawei.com>
Cc: Jiang Liu <liuj97@gmail.com>, Bjorn Helgaas <bhelgaas@google.com>,
"Rafael J . Wysocki" <rjw@sisk.pl>,
Jiang Liu <jiang.liu@huawei.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/2] acpiphp: remove dead code for PCI host bridge hotplug
Date: Fri, 1 Feb 2013 16:01:06 -0800 [thread overview]
Message-ID: <CAE9FiQVH=0H+YPDKSO3t5Mdi-KndZtFXBit826HCNXQ_X3USyA@mail.gmail.com> (raw)
In-Reply-To: <510B81D1.5070302@huawei.com>
On Fri, Feb 1, 2013 at 12:50 AM, Yijing Wang <wangyijing@huawei.com> wrote:
> On 2013/1/31 23:59, Yinghai Lu wrote:
>> On Thu, Jan 31, 2013 at 7:37 AM, Jiang Liu <liuj97@gmail.com> wrote:
>>>
>>> So I think the code in handle_hotplug_event_bridge() to handle P2P hot-addition
>>> is dead. Yijing has helped to test the code by faking ACPI CUSTOM_METHOD, and it
>>> does work as expected.
>>
>> ok, then.
>>
>> It would be better if you can append some print out from Yijing's test
>> in the changelog.
>>
>
> Hi Yinghai,
> I used custom_method module to make root port device 0000:00:07.0 support acpi hotplug (by adding _EJ0 method),
> This root port device also connected to a slot which support hotplug. I tested to hot plug root port device 0000:00:07.0,
> and test steps and info as bellow, if there are somethings missing during test, please let me know.
> Thanks very much!
>
> linux-ha2:/sys/bus/pci/slots # lspci -tv
> \-[0000:00]-+-00.0 Intel Corporation 5520/5500/X58 I/O Hub to ESI Port
> +-01.0-[0000:01]--+-00.0 Intel Corporation 82576 Gigabit Network Connection
> | \-00.1 Intel Corporation 82576 Gigabit Network Connection
> +-03.0-[0000:02]----00.0 LSI Logic / Symbios Logic SAS1064ET PCI-Express Fusion-MPT SAS
> +-04.0-[0000:03]--
> +-05.0-[0000:04]--
> +-07.0-[0000:05]--+-00.0 nVidia Corporation GT218 [GeForce G210]
> | \-00.1 nVidia Corporation High Definition Audio Controller
> +-0d.0 Intel Corporation Device 343a
> linux-ha2:/sys/bus/pci/slots # ls
> 0 0-1 1 3 5 7
> linux-ha2:/sys/bus/pci/slots # cat 1/address
> 0000:00:07
> linux-ha2:/sys/bus/pci/slots # cd 1
> linux-ha2:/sys/bus/pci/slots/1 # ls
> adapter address attention cur_bus_speed latch max_bus_speed module power
> linux-ha2:/sys/bus/pci/slots/1 # cat power
> 1
> linux-ha2:/sys/bus/pci/slots/1 # echo "\_SB_.NOD0.PCI0.MRP7 3" > /sys/kernel/debug/acpi/sci_notify
> linux-ha2:/sys/bus/pci/slots/1 # cat power
> 0
> linux-ha2:/sys/bus/pci/slots/1 # lspci -tv
> \-[0000:00]-+-00.0 Intel Corporation 5520/5500/X58 I/O Hub to ESI Port
> +-01.0-[0000:01]--+-00.0 Intel Corporation 82576 Gigabit Network Connection
> | \-00.1 Intel Corporation 82576 Gigabit Network Connection
> +-03.0-[0000:02]----00.0 LSI Logic / Symbios Logic SAS1064ET PCI-Express Fusion-MPT SAS
> +-04.0-[0000:03]--
> +-05.0-[0000:04]--
> +-0d.0 Intel Corporation Device 343a
> linux-ha2:/sys/bus/pci/slots/1 # echo "\_SB_.NOD0.PCI0.MRP7 1" > /sys/kernel/debug/acpi/sci_notify
> linux-ha2:/sys/bus/pci/slots/1 # cat power
> 1
> linux-ha2:/sys/bus/pci/slots/1 # lspci -tv
> \-[0000:00]-+-00.0 Intel Corporation 5520/5500/X58 I/O Hub to ESI Port
> +-01.0-[0000:01]--+-00.0 Intel Corporation 82576 Gigabit Network Connection
> | \-00.1 Intel Corporation 82576 Gigabit Network Connection
> +-03.0-[0000:02]----00.0 LSI Logic / Symbios Logic SAS1064ET PCI-Express Fusion-MPT SAS
> +-04.0-[0000:03]--
> +-05.0-[0000:04]--
> +-07.0-[0000:05]--+-00.0 nVidia Corporation GT218 [GeForce G210]
> | \-00.1 nVidia Corporation High Definition Audio Controller
> +-0d.0 Intel Corporation Device 343a
looks good.
Thanks
next prev parent reply other threads:[~2013-02-02 0:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 16:10 [PATCH 1/2] acpiphp: create companion ACPI devices before creating PCI devices Jiang Liu
2013-01-30 16:10 ` [PATCH 2/2] acpiphp: remove dead code for PCI host bridge hotplug Jiang Liu
2013-01-30 17:27 ` Yinghai Lu
2013-01-31 15:37 ` Jiang Liu
2013-01-31 15:59 ` Yinghai Lu
2013-02-01 8:50 ` Yijing Wang
2013-02-02 0:01 ` Yinghai Lu [this message]
2013-02-01 23:18 ` Bjorn Helgaas
2013-02-01 23:06 ` [PATCH 1/2] acpiphp: create companion ACPI devices before creating PCI devices Bjorn Helgaas
2013-02-01 23:17 ` Bjorn Helgaas
2013-02-02 2:24 ` Yijing Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE9FiQVH=0H+YPDKSO3t5Mdi-KndZtFXBit826HCNXQ_X3USyA@mail.gmail.com' \
--to=yinghai@kernel.org \
--cc=bhelgaas@google.com \
--cc=jiang.liu@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liuj97@gmail.com \
--cc=rjw@sisk.pl \
--cc=wangyijing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).