From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f174.google.com ([209.85.213.174]:35512 "EHLO mail-ig0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752727AbbG3D7Q (ORCPT ); Wed, 29 Jul 2015 23:59:16 -0400 Received: by igr7 with SMTP id 7so159443316igr.0 for ; Wed, 29 Jul 2015 20:59:16 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20150729202639.GA13239@google.com> References: <1436292680-25111-1-git-send-email-linux@roeck-us.net> <20150729160903.GD31170@google.com> <55B92DA5.4030409@roeck-us.net> <55B93151.8040608@roeck-us.net> <20150729202639.GA13239@google.com> Date: Wed, 29 Jul 2015 20:59:16 -0700 Message-ID: Subject: Re: [RFC PATCH v2] PCI: Only enable IO window if supported From: Yinghai Lu To: Bjorn Helgaas Cc: Guenter Roeck , "linux-pci@vger.kernel.org" , Lorenzo Pieralisi Content-Type: multipart/mixed; boundary=047d7bd758a2207787051c0fba9c Sender: linux-pci-owner@vger.kernel.org List-ID: --047d7bd758a2207787051c0fba9c Content-Type: text/plain; charset=UTF-8 On Wed, Jul 29, 2015 at 1:26 PM, Bjorn Helgaas wrote: > On Wed, Jul 29, 2015 at 01:02:25PM -0700, Guenter Roeck wrote: >> Bjorn, how do you want to handle the flag problem ? >> Do you have an idea on how to make it work with >> the reversed definition ? > > I'll wait for the revised patch. Sorry for screwing this up. Please check attached updated version. Yinghai --047d7bd758a2207787051c0fba9c Content-Type: text/x-patch; charset=US-ASCII; name="commit-4b59da5_x.patch" Content-Disposition: attachment; filename="commit-4b59da5_x.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_icpo901y0 Y29tbWl0IDRiNTlkYTUyMWY3ZTBhZWRmZjc1YzJhYTkwYjZhNjUzNzI3Y2RmN2YKQXV0aG9yOiBH dWVudGVyIFJvZWNrIDxsaW51eEByb2Vjay11cy5uZXQ+CkRhdGU6ICAgVHVlIEp1bCA3IDExOjEx OjIwIDIwMTUgLTA3MDAKCiAgICBUaGUgUENJIHN1YnN5c3RlbSBhbHdheXMgYXNzdW1lcyB0aGF0 IEkvTyBpcyBzdXBwb3J0ZWQgb24gUENJZSBicmlkZ2VzIGFuZAogICAgdHJpZXMgdG8gYXNzaWdu IGFuIEkvTyB3aW5kb3cgdG8gZWFjaCBjaGlsZCBidXMgZXZlbiBpZiB0aGF0IGlzIG5vdCB0aGUK ICAgIGNhc2UuCiAgICAKICAgIFRoaXMgbWF5IHJlc3VsdCBpbiBtZXNzYWdlcyBzdWNoIGFzOgog ICAgCiAgICAgIHBjaWVwb3J0IDAwMDA6MDI6MDAuMDogcmVzWzddPVtpbyAgMHgxMDAwLTB4MGZm Zl0gZ2V0X3Jlc19hZGRfc2l6ZSBhZGRfc2l6ZSAxMDAwCiAgICAgIHBjaWVwb3J0IDAwMDA6MDI6 MDAuMDogQkFSIDc6IG5vIHNwYWNlIGZvciBbaW8gIHNpemUgMHgxMDAwXQogICAgICBwY2llcG9y dCAwMDAwOjAyOjAwLjA6IEJBUiA3OiBmYWlsZWQgdG8gYXNzaWduIFtpbyAgc2l6ZSAweDEwMDBd CiAgICAKICAgIGZvciBlYWNoIGJyaWRnZSBwb3J0LCBldmVuIGlmIGEgYnVzIG9yIGl0cyBwYXJl bnQgZG9lcyBub3Qgc3VwcG9ydCBJL08gaW4KICAgIHRoZSBmaXJzdCBwbGFjZS4KICAgIAogICAg VG8gYXZvaWQgdGhpcyBtZXNzYWdlLCBjaGVjayBpZiBhIGJ1cyBzdXBwb3J0cyBJL08gYmVmb3Jl IHRyeWluZyB0byBlbmFibGUKICAgIGl0LiAgQWxzbyBjaGVjayBpZiB0aGUgcm9vdCBidXMgaGFz IGFuIElPIHdpbmRvdyBhc3NpZ25lZDsgaWYgbm90LCBpdCBkb2VzCiAgICBub3QgbWFrZSBzZW5z ZSB0byB0cnkgdG8gYXNzaWduIG9uZSB0byBhbnkgb2YgaXRzIGNoaWxkIGJ1c3Nlcy4KICAgIAog ICAgW2JoZWxnYWFzOiByZXZlcnNlIHNlbnNlIG9mIG5ldyBwY2lfYnVzX2ZsYWdzX3QgdmFsdWVd CiAgICBbeWluZ2hhaTogc2ltcGxpZnkgcm9vdCBidXMgZmxhZyBjaGVjaywgZml4IGZsYWdzIGlu aXRpYWwgc2V0dGluZywgY2hhbmdlIHRvIGJvb2xdCiAgICBTaWduZWQtb2ZmLWJ5OiBHdWVudGVy IFJvZWNrIDxsaW51eEByb2Vjay11cy5uZXQ+CiAgICBTaWduZWQtb2ZmLWJ5OiBCam9ybiBIZWxn YWFzIDxiaGVsZ2Fhc0Bnb29nbGUuY29tPgogICAgQ0M6IExvcmVuem8gUGllcmFsaXNpIDxsb3Jl bnpvLnBpZXJhbGlzaUBhcm0uY29tPgoKLS0tCiBkcml2ZXJzL3BjaS9wcm9iZS5jICAgICB8ICAg NTEgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiBkcml2 ZXJzL3BjaS9zZXR1cC1idXMuYyB8ICAgMTEgKystLS0tLS0tLQogaW5jbHVkZS9saW51eC9wY2ku aCAgICAgfCAgICAxIAogMyBmaWxlcyBjaGFuZ2VkLCA1NSBpbnNlcnRpb25zKCspLCA4IGRlbGV0 aW9ucygtKQoKSW5kZXg6IGxpbnV4LTIuNi9kcml2ZXJzL3BjaS9wcm9iZS5jCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIGxpbnV4LTIuNi5vcmlnL2RyaXZlcnMvcGNpL3Byb2JlLmMKKysrIGxpbnV4LTIuNi9kcml2 ZXJzL3BjaS9wcm9iZS5jCkBAIC0zMzIsNiArMzMyLDMyIEBAIHN0YXRpYyB2b2lkIHBjaV9yZWFk X2Jhc2VzKHN0cnVjdCBwY2lfZGUKIAl9CiB9CiAKK3N0YXRpYyBib29sIHBjaV9icmlkZ2Vfc3Vw cG9ydHNfaW8oc3RydWN0IHBjaV9kZXYgKmJyaWRnZSkKK3sKKwl1MTYgaW87CisKKwlwY2lfcmVh ZF9jb25maWdfd29yZChicmlkZ2UsIFBDSV9JT19CQVNFLCAmaW8pOworCWlmIChpbykKKwkJcmV0 dXJuIHRydWU7CisKKwkvKiBJT19CQVNFL0xJTUlUIGlzIGVpdGhlciBoYXJkLXdpcmVkIHRvIHpl cm8gb3IgcHJvZ3JhbW1lZCB0byB6ZXJvICovCisJcGNpX3dyaXRlX2NvbmZpZ193b3JkKGJyaWRn ZSwgUENJX0lPX0JBU0UsIDB4ZTBmMCk7CisJcGNpX3JlYWRfY29uZmlnX3dvcmQoYnJpZGdlLCBQ Q0lfSU9fQkFTRSwgJmlvKTsKKwlwY2lfd3JpdGVfY29uZmlnX3dvcmQoYnJpZGdlLCBQQ0lfSU9f QkFTRSwgMHgwKTsKKwlpZiAoaW8pCisJCXJldHVybiB0cnVlOworCisJcmV0dXJuIGZhbHNlOwor fQorCitzdGF0aWMgYm9vbCBwY2lfcm9vdF9oYXNfaW9fcmVzb3VyY2Uoc3RydWN0IHBjaV9idXMg KmJ1cykKK3sKKwl3aGlsZSAoYnVzLT5wYXJlbnQpCisJCWJ1cyA9IGJ1cy0+cGFyZW50OworCisJ cmV0dXJuICEhKGJ1cy0+YnVzX2ZsYWdzICYgUENJX0JVU19GTEFHU19TVVBQT1JUU19JTyk7Cit9 CisKIHN0YXRpYyB2b2lkIHBjaV9yZWFkX2JyaWRnZV9pbyhzdHJ1Y3QgcGNpX2J1cyAqY2hpbGQp CiB7CiAJc3RydWN0IHBjaV9kZXYgKmRldiA9IGNoaWxkLT5zZWxmOwpAQCAtMzQwLDYgKzM2Niwy MSBAQCBzdGF0aWMgdm9pZCBwY2lfcmVhZF9icmlkZ2VfaW8oc3RydWN0IHBjCiAJc3RydWN0IHBj aV9idXNfcmVnaW9uIHJlZ2lvbjsKIAlzdHJ1Y3QgcmVzb3VyY2UgKnJlczsKIAorCWlmICghKGNo aWxkLT5idXNfZmxhZ3MgJiBQQ0lfQlVTX0ZMQUdTX1NVUFBPUlRTX0lPKSkKKwkJcmV0dXJuOwor CisJaWYgKCFwY2lfYnJpZGdlX3N1cHBvcnRzX2lvKGRldikpIHsKKwkJZGV2X3ByaW50ayhLRVJO X0RFQlVHLCAmZGV2LT5kZXYsICIgIG5vIEkvTyB3aW5kb3dcbiIpOworCQljaGlsZC0+YnVzX2Zs YWdzICY9IH5QQ0lfQlVTX0ZMQUdTX1NVUFBPUlRTX0lPOworCQlyZXR1cm47CisJfQorCisJaWYg KCFwY2lfcm9vdF9oYXNfaW9fcmVzb3VyY2UoY2hpbGQpKSB7CisJCWRldl9wcmludGsoS0VSTl9E RUJVRywgJmRldi0+ZGV2LCAiICBubyBJL08gcmVzb3VyY2Ugb24gcm9vdCBidXNcbiIpOworCQlj aGlsZC0+YnVzX2ZsYWdzICY9IH5QQ0lfQlVTX0ZMQUdTX1NVUFBPUlRTX0lPOworCQlyZXR1cm47 CisJfQorCiAJaW9fbWFzayA9IFBDSV9JT19SQU5HRV9NQVNLOwogCWlvX2dyYW51bGFyaXR5ID0g MHgxMDAwOwogCWlmIChkZXYtPmlvX3dpbmRvd18xaykgewpAQCAtNDk2LDYgKzUzNyw3IEBAIHN0 YXRpYyBzdHJ1Y3QgcGNpX2J1cyAqcGNpX2FsbG9jX2J1cyhzdHIKIAlJTklUX0xJU1RfSEVBRCgm Yi0+cmVzb3VyY2VzKTsKIAliLT5tYXhfYnVzX3NwZWVkID0gUENJX1NQRUVEX1VOS05PV047CiAJ Yi0+Y3VyX2J1c19zcGVlZCA9IFBDSV9TUEVFRF9VTktOT1dOOworCWItPmJ1c19mbGFncyB8PSBQ Q0lfQlVTX0ZMQUdTX1NVUFBPUlRTX0lPOwogI2lmZGVmIENPTkZJR19QQ0lfRE9NQUlOU19HRU5F UklDCiAJaWYgKHBhcmVudCkKIAkJYi0+ZG9tYWluX25yID0gcGFyZW50LT5kb21haW5fbnI7CkBA IC0yMDU4LDYgKzIxMDAsMTUgQEAgaW50IHBjaV9idXNfaW5zZXJ0X2J1c25fcmVzKHN0cnVjdCBw Y2lfYgogCQlyZXMtPmZsYWdzIHw9IElPUkVTT1VSQ0VfUENJX0ZJWEVEOwogCX0KIAorCWItPmJ1 c19mbGFncyAmPSB+UENJX0JVU19GTEFHU19TVVBQT1JUU19JTzsKKwlyZXNvdXJjZV9saXN0X2Zv cl9lYWNoX2VudHJ5KHdpbmRvdywgJmJyaWRnZS0+d2luZG93cykgeworCQlyZXMgPSB3aW5kb3ct PnJlczsKKwkJaWYgKHJlc291cmNlX3R5cGUocmVzKSA9PSBJT1JFU09VUkNFX0lPKSB7CisJCQli LT5idXNfZmxhZ3MgfD0gUENJX0JVU19GTEFHU19TVVBQT1JUU19JTzsKKwkJCWJyZWFrOworCQl9 CisJfQorCiAJY29uZmxpY3QgPSByZXF1ZXN0X3Jlc291cmNlX2NvbmZsaWN0KHBhcmVudF9yZXMs IHJlcyk7CiAKIAlpZiAoY29uZmxpY3QpCkluZGV4OiBsaW51eC0yLjYvZHJpdmVycy9wY2kvc2V0 dXAtYnVzLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gbGludXgtMi42Lm9yaWcvZHJpdmVycy9wY2kvc2V0dXAt YnVzLmMKKysrIGxpbnV4LTIuNi9kcml2ZXJzL3BjaS9zZXR1cC1idXMuYwpAQCAtNzQ0LDcgKzc0 NCw2IEBAIGludCBwY2lfY2xhaW1fYnJpZGdlX3Jlc291cmNlKHN0cnVjdCBwY2kKICAgIGJhc2Uv bGltaXQgcmVnaXN0ZXJzIG11c3QgYmUgcmVhZC1vbmx5IGFuZCByZWFkIGFzIDAuICovCiBzdGF0 aWMgdm9pZCBwY2lfYnJpZGdlX2NoZWNrX3JhbmdlcyhzdHJ1Y3QgcGNpX2J1cyAqYnVzKQogewot CXUxNiBpbzsKIAl1MzIgcG1lbTsKIAlzdHJ1Y3QgcGNpX2RldiAqYnJpZGdlID0gYnVzLT5zZWxm OwogCXN0cnVjdCByZXNvdXJjZSAqYl9yZXM7CkBAIC03NTIsMTQgKzc1MSwxMCBAQCBzdGF0aWMg dm9pZCBwY2lfYnJpZGdlX2NoZWNrX3JhbmdlcyhzdHJ1CiAJYl9yZXMgPSAmYnJpZGdlLT5yZXNv dXJjZVtQQ0lfQlJJREdFX1JFU09VUkNFU107CiAJYl9yZXNbMV0uZmxhZ3MgfD0gSU9SRVNPVVJD RV9NRU07CiAKLQlwY2lfcmVhZF9jb25maWdfd29yZChicmlkZ2UsIFBDSV9JT19CQVNFLCAmaW8p OwotCWlmICghaW8pIHsKLQkJcGNpX3dyaXRlX2NvbmZpZ193b3JkKGJyaWRnZSwgUENJX0lPX0JB U0UsIDB4ZTBmMCk7Ci0JCXBjaV9yZWFkX2NvbmZpZ193b3JkKGJyaWRnZSwgUENJX0lPX0JBU0Us ICZpbyk7Ci0JCXBjaV93cml0ZV9jb25maWdfd29yZChicmlkZ2UsIFBDSV9JT19CQVNFLCAweDAp OwotCX0KLQlpZiAoaW8pCisJaWYgKGJ1cy0+YnVzX2ZsYWdzICYgUENJX0JVU19GTEFHU19TVVBQ T1JUU19JTykKIAkJYl9yZXNbMF0uZmxhZ3MgfD0gSU9SRVNPVVJDRV9JTzsKKwllbHNlCisJCWJf cmVzWzBdLmZsYWdzICY9IH5JT1JFU09VUkNFX0lPOwogCiAJLyogIERFQ2NoaXAgMjEwNTAgcGFz cyAyIGVycmF0YTogdGhlIGJyaWRnZSBtYXkgbWlzcyBhbiBhZGRyZXNzCiAJICAgIGRpc2Nvbm5l Y3QgYm91bmRhcnkgYnkgb25lIFBDSSBkYXRhIHBoYXNlLgpJbmRleDogbGludXgtMi42L2luY2x1 ZGUvbGludXgvcGNpLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gbGludXgtMi42Lm9yaWcvaW5jbHVkZS9saW51 eC9wY2kuaAorKysgbGludXgtMi42L2luY2x1ZGUvbGludXgvcGNpLmgKQEAgLTE5Myw2ICsxOTMs NyBAQCB0eXBlZGVmIHVuc2lnbmVkIHNob3J0IF9fYml0d2lzZSBwY2lfYnVzCiBlbnVtIHBjaV9i dXNfZmxhZ3MgewogCVBDSV9CVVNfRkxBR1NfTk9fTVNJICAgPSAoX19mb3JjZSBwY2lfYnVzX2Zs YWdzX3QpIDEsCiAJUENJX0JVU19GTEFHU19OT19NTVJCQyA9IChfX2ZvcmNlIHBjaV9idXNfZmxh Z3NfdCkgMiwKKwlQQ0lfQlVTX0ZMQUdTX1NVUFBPUlRTX0lPID0gKF9fZm9yY2UgcGNpX2J1c19m bGFnc190KSA0LAogfTsKIAogLyogVGhlc2UgdmFsdWVzIGNvbWUgZnJvbSB0aGUgUENJIEV4cHJl c3MgU3BlYyAqLwo= --047d7bd758a2207787051c0fba9c--