linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Taku Izumi <izumi.taku@jp.fujitsu.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, Jiang Liu <jiang.liu@huawei.com>,
	wangyijing@huawei.com
Subject: Re: [PATCH] PCI/portdrv: Fix regression introduced by commit 2dcfaf85
Date: Tue, 30 Oct 2012 18:34:29 -0700	[thread overview]
Message-ID: <CAE9FiQVoNm3Wsi4LM1Hhk3RXyLr-UXPggSdJ6Y1Ha7BjjApC5A@mail.gmail.com> (raw)
In-Reply-To: <20121031095148.75dbb6e8.izumi.taku@jp.fujitsu.com>

On Tue, Oct 30, 2012 at 5:51 PM, Taku Izumi <izumi.taku@jp.fujitsu.com> wrote:
>
> PCI/portdrv: Fix regression introduced by commit 2dcfaf85
>
> After commit 2dcfaf85, hotplug slots for port devices
> w/o slot implementation come to be created.
> This patch fixes this problem.
>
> Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com>
> ---
>  drivers/pci/pcie/portdrv_core.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: pci/drivers/pci/pcie/portdrv_core.c
> ===================================================================
> --- pci.orig/drivers/pci/pcie/portdrv_core.c
> +++ pci/drivers/pci/pcie/portdrv_core.c
> @@ -272,7 +272,8 @@ static int get_port_device_capability(st
>         }
>
>         /* Hot-Plug Capable */
> -       if (cap_mask & PCIE_PORT_SERVICE_HP) {
> +       if ((cap_mask & PCIE_PORT_SERVICE_HP) &&
> +           dev->pcie_flags_reg & PCI_EXP_FLAGS_SLOT) {
>                 pcie_capability_read_dword(dev, PCI_EXP_SLTCAP, &reg32);
>                 if (reg32 & PCI_EXP_SLTCAP_HPC) {
>                         services |= PCIE_PORT_SERVICE_HP;
>

Acked-by: Yinghai Lu <yinghai@kernel.org>

  reply	other threads:[~2012-10-31  1:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-31  0:51 [PATCH] PCI/portdrv: Fix regression introduced by commit 2dcfaf85 Taku Izumi
2012-10-31  1:34 ` Yinghai Lu [this message]
2012-11-01 12:53 ` Jiang Liu
2012-11-05 22:08   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAE9FiQVoNm3Wsi4LM1Hhk3RXyLr-UXPggSdJ6Y1Ha7BjjApC5A@mail.gmail.com \
    --to=yinghai@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=izumi.taku@jp.fujitsu.com \
    --cc=jiang.liu@huawei.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=wangyijing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).