From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:37926 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759095Ab2I2Bw2 (ORCPT ); Fri, 28 Sep 2012 21:52:28 -0400 MIME-Version: 1.0 In-Reply-To: References: <1348733519-24684-1-git-send-email-yinghai@kernel.org> <1348733519-24684-4-git-send-email-yinghai@kernel.org> Date: Fri, 28 Sep 2012 18:52:27 -0700 Message-ID: Subject: Re: [PATCH 3/8] PCI: Move out pci_enable_bridges out of assign_unsigned_bus_res From: Yinghai Lu To: Bjorn Helgaas Cc: Len Brown , Taku Izumi , Jiang Liu , linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-pci-owner@vger.kernel.org List-ID: On Fri, Sep 28, 2012 at 6:48 PM, Yinghai Lu wrote: > On Fri, Sep 28, 2012 at 4:46 PM, Bjorn Helgaas wrote: >> On Thu, Sep 27, 2012 at 2:11 AM, Yinghai Lu wrote: >>> So could use assign_unassigned_bus_res pci root bus add >> >> After your series, acpi_pci_root_start() looks like this: >> >> pci_assign_unassigned_bus_resources >> list_for_each_entry(driver, &acpi_pci_drivers, node) >> driver->add(root); >> pci_enable_bridges(root->bus); >> >> so apparently it's important that the driver->add() methods be run >> *before* the bridges are enabled. Why? > During rebase, the changelog get lost. pci_enable_bridges ==> pci_enable_device ==> ... ===> pcibios_enable_device ===> pcibios_enable_irq and one of driver in acpi_pci_drivers, is ioapic drivers and it will enable ioapic there. So we need to enable bridges that later. -Yinghai