From: Bjorn Helgaas <bhelgaas@google.com>
To: Huang Ying <ying.huang@intel.com>
Cc: ming.m.lin@intel.com, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, linux-pm@vger.kernel.org,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Zheng Yan <zheng.z.yan@intel.com>
Subject: Re: [PATCH -v6 0/4] PCIe, PM, Add PCIe runtime D3cold support
Date: Fri, 22 Jun 2012 16:13:05 -0600 [thread overview]
Message-ID: <CAErSpo4Hd7__n=Ffxk5be1SwVbPZ5PdkaeX4sbAV886PCjSJtg@mail.gmail.com> (raw)
In-Reply-To: <1340083249-16266-1-git-send-email-ying.huang@intel.com>
On Mon, Jun 18, 2012 at 11:20 PM, Huang Ying <ying.huang@intel.com> wrote:
> Changelog:
>
> v6:
>
> - Disable device D3cold during system suspend/hibernate with a new method per Rafeal's comments
>
> v5:
>
> - Disable device D3cold during system suspend/hibernate per Rafael's comments
>
> v4:
>
> - Minors fixes based on comments from Rafael
>
> v3:
>
> - Drop device.power.power_must_be_on, use pci_dev.no_d3cold instead
> - Drop device.power.power_off_user, use pci_dev.d3cold_allowed instead
> - Use black list instead of white list in pcie port runtime support per request from Bjorn
> - Various fixes based on comments from Rafael
>
> v2:
>
> - Refreshed based on comments from Rafael
>
> [PATCH -v6 1/4] ACPI, PM, Specify lowest allowed state for device sleep
> [PATCH -v6 2/4] PCIe, PM, Add runtime PM support to PCIe port
> [PATCH -v6 3/4] PCI, PM, Do not call pci_set_power_state with PCI_D3cold
> [PATCH -v6 4/4] PCIe, PM, Add PCIe runtime D3cold support
What kernel is this series based on? Patch 4/4 doesn't apply to my
tree. This hunk fails because I don't have the "Some devices mustn't
be in D3 ..." context:
@@ -1754,6 +1841,10 @@ int pci_prepare_to_sleep(struct pci_dev
if (target_state == PCI_POWER_ERROR)
return -EIO;
+ /* D3cold during system suspend/hibernate is not supported */
+ if (target_state > PCI_D3hot)
+ target_state = PCI_D3hot;
+
/* Some devices mustn't be in D3 during system sleep */
if (target_state == PCI_D3hot &&
(dev->dev_flags & PCI_DEV_FLAGS_NO_D3_DURING_SLEEP))
next prev parent reply other threads:[~2012-06-22 22:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 5:20 [PATCH -v6 0/4] PCIe, PM, Add PCIe runtime D3cold support Huang Ying
2012-06-19 5:20 ` [PATCH -v6 1/4] ACPI, PM, Specify lowest allowed state for device sleep state Huang Ying
2012-06-19 5:20 ` [PATCH -v6 2/4] PCIe, PM, Add runtime PM support to PCIe port Huang Ying
2012-06-19 5:20 ` [PATCH -v6 3/4] PCI, PM, Do not call pci_set_power_state with PCI_D3cold Huang Ying
2012-06-20 22:47 ` Rafael J. Wysocki
2012-06-19 5:20 ` [PATCH -v6 4/4] PCIe, PM, Add PCIe runtime D3cold support Huang Ying
2012-06-20 22:53 ` Rafael J. Wysocki
2012-06-22 22:13 ` Bjorn Helgaas [this message]
2012-06-22 23:15 ` [PATCH -v6 0/4] " Rafael J. Wysocki
2012-06-23 1:05 ` huang ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAErSpo4Hd7__n=Ffxk5be1SwVbPZ5PdkaeX4sbAV886PCjSJtg@mail.gmail.com' \
--to=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=rjw@sisk.pl \
--cc=ying.huang@intel.com \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).