[PATCH] microblaze/PCI: Remove unused declarations

[PATCH] microblaze/PCI: Remove unused declarations

[Bjorn Helgaas]

The following declarations were copied from powerpc but are unused on
microblaze:

  struct pci_controller *init_phb_dynamic(struct device_node *dn)
  int remove_phb_dynamic(struct pci_controller *phb)
  struct pci_dev *of_create_pci_dev(struct device_node *node, ...)
  void of_scan_pci_bridge(struct device_node *node, ...)
  void of_scan_bus(struct device_node *node, struct pci_bus *bus)
  void of_rescan_bus(struct device_node *node, struct pci_bus *bus)

Remove them.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 arch/microblaze/include/asm/pci.h |   12 ------------
 1 file changed, 12 deletions(-)

diff --git a/arch/microblaze/include/asm/pci.h b/arch/microblaze/include/asm/pci.h
index 468aca8..b6b5b3c 100644
--- a/arch/microblaze/include/asm/pci.h
+++ b/arch/microblaze/include/asm/pci.h
@@ -102,18 +102,6 @@ extern void pcibios_finish_adding_to_bus(struct pci_bus *bus);
 
 extern void pcibios_resource_survey(void);
 
-extern struct pci_controller *init_phb_dynamic(struct device_node *dn);
-extern int remove_phb_dynamic(struct pci_controller *phb);
-
-extern struct pci_dev *of_create_pci_dev(struct device_node *node,
-					struct pci_bus *bus, int devfn);
-
-extern void of_scan_pci_bridge(struct device_node *node,
-				struct pci_dev *dev);
-
-extern void of_scan_bus(struct device_node *node, struct pci_bus *bus);
-extern void of_rescan_bus(struct device_node *node, struct pci_bus *bus);
-
 extern int pci_bus_find_capability(struct pci_bus *bus,
 						unsigned int devfn, int cap);
 

Re: [PATCH] microblaze/PCI: Remove unused declarations

[Michal Simek]

[-- Attachment #1: Type: text/plain, Size: 2133 bytes --]

Hi Bjorn,

On 06/04/2015 09:57 PM, Bjorn Helgaas wrote:
> The following declarations were copied from powerpc but are unused on
> microblaze:
> 
>   struct pci_controller *init_phb_dynamic(struct device_node *dn)
>   int remove_phb_dynamic(struct pci_controller *phb)
>   struct pci_dev *of_create_pci_dev(struct device_node *node, ...)
>   void of_scan_pci_bridge(struct device_node *node, ...)
>   void of_scan_bus(struct device_node *node, struct pci_bus *bus)
>   void of_rescan_bus(struct device_node *node, struct pci_bus *bus)
> 
> Remove them.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
>  arch/microblaze/include/asm/pci.h |   12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/arch/microblaze/include/asm/pci.h b/arch/microblaze/include/asm/pci.h
> index 468aca8..b6b5b3c 100644
> --- a/arch/microblaze/include/asm/pci.h
> +++ b/arch/microblaze/include/asm/pci.h
> @@ -102,18 +102,6 @@ extern void pcibios_finish_adding_to_bus(struct pci_bus *bus);
>  
>  extern void pcibios_resource_survey(void);
>  
> -extern struct pci_controller *init_phb_dynamic(struct device_node *dn);
> -extern int remove_phb_dynamic(struct pci_controller *phb);
> -
> -extern struct pci_dev *of_create_pci_dev(struct device_node *node,
> -					struct pci_bus *bus, int devfn);
> -
> -extern void of_scan_pci_bridge(struct device_node *node,
> -				struct pci_dev *dev);
> -
> -extern void of_scan_bus(struct device_node *node, struct pci_bus *bus);
> -extern void of_rescan_bus(struct device_node *node, struct pci_bus *bus);
> -
>  extern int pci_bus_find_capability(struct pci_bus *bus,
>  						unsigned int devfn, int cap);
>  
> 

I think I should ignore this because you have sent another series where
this patch is included.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] microblaze/PCI: Remove unused declarations

[Bjorn Helgaas]

On Fri, Jun 5, 2015 at 1:42 AM, Michal Simek <monstr@monstr.eu> wrote:
> Hi Bjorn,
>
> On 06/04/2015 09:57 PM, Bjorn Helgaas wrote:
>> The following declarations were copied from powerpc but are unused on
>> microblaze:
>>
>>   struct pci_controller *init_phb_dynamic(struct device_node *dn)
>>   int remove_phb_dynamic(struct pci_controller *phb)
>>   struct pci_dev *of_create_pci_dev(struct device_node *node, ...)
>>   void of_scan_pci_bridge(struct device_node *node, ...)
>>   void of_scan_bus(struct device_node *node, struct pci_bus *bus)
>>   void of_rescan_bus(struct device_node *node, struct pci_bus *bus)
>>
>> Remove them.
>>
>> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>> ---
>>  arch/microblaze/include/asm/pci.h |   12 ------------
>>  1 file changed, 12 deletions(-)
>>
>> diff --git a/arch/microblaze/include/asm/pci.h b/arch/microblaze/include/asm/pci.h
>> index 468aca8..b6b5b3c 100644
>> --- a/arch/microblaze/include/asm/pci.h
>> +++ b/arch/microblaze/include/asm/pci.h
>> @@ -102,18 +102,6 @@ extern void pcibios_finish_adding_to_bus(struct pci_bus *bus);
>>
>>  extern void pcibios_resource_survey(void);
>>
>> -extern struct pci_controller *init_phb_dynamic(struct device_node *dn);
>> -extern int remove_phb_dynamic(struct pci_controller *phb);
>> -
>> -extern struct pci_dev *of_create_pci_dev(struct device_node *node,
>> -                                     struct pci_bus *bus, int devfn);
>> -
>> -extern void of_scan_pci_bridge(struct device_node *node,
>> -                             struct pci_dev *dev);
>> -
>> -extern void of_scan_bus(struct device_node *node, struct pci_bus *bus);
>> -extern void of_rescan_bus(struct device_node *node, struct pci_bus *bus);
>> -
>>  extern int pci_bus_find_capability(struct pci_bus *bus,
>>                                               unsigned int devfn, int cap);
>>
>>
>
> I think I should ignore this because you have sent another series where
> this patch is included.

Yeah, sorry, I found several other pieces of cruft after sending this
and wanted to group it all together.