* [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id [not found] <1431747401-20847-1-git-send-email-aleksey.makarov@auriga.com> @ 2015-05-16 3:36 ` Aleksey Makarov 2015-05-16 14:49 ` Bjorn Helgaas 2015-05-18 21:00 ` Aleksey Makarov 0 siblings, 2 replies; 9+ messages in thread From: Aleksey Makarov @ 2015-05-16 3:36 UTC (permalink / raw) To: netdev; +Cc: linux-kernel, David Daney, Aleksey Makarov, Bjorn Helgaas, linux-pci Signed-off-by: Aleksey Makarov <aleksey.makarov@auriga.com> --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index e63c02a..3633cc6 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -2327,6 +2327,8 @@ #define PCI_DEVICE_ID_ALTIMA_AC9100 0x03ea #define PCI_DEVICE_ID_ALTIMA_AC1003 0x03eb +#define PCI_VENDOR_ID_CAVIUM 0x177d + #define PCI_VENDOR_ID_BELKIN 0x1799 #define PCI_DEVICE_ID_BELKIN_F5D7010V7 0x701f -- 2.4.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id 2015-05-16 3:36 ` [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id Aleksey Makarov @ 2015-05-16 14:49 ` Bjorn Helgaas 2015-05-16 21:14 ` David Miller 2015-05-18 21:00 ` Aleksey Makarov 1 sibling, 1 reply; 9+ messages in thread From: Bjorn Helgaas @ 2015-05-16 14:49 UTC (permalink / raw) To: Aleksey Makarov Cc: netdev, linux-kernel@vger.kernel.org, David Daney, linux-pci@vger.kernel.org Hi Aleksey, On Fri, May 15, 2015 at 10:36 PM, Aleksey Makarov <aleksey.makarov@auriga.com> wrote: > Signed-off-by: Aleksey Makarov <aleksey.makarov@auriga.com> > --- > include/linux/pci_ids.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index e63c02a..3633cc6 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -2327,6 +2327,8 @@ > #define PCI_DEVICE_ID_ALTIMA_AC9100 0x03ea > #define PCI_DEVICE_ID_ALTIMA_AC1003 0x03eb > > +#define PCI_VENDOR_ID_CAVIUM 0x177d Please read the note at the top of include/linux/pci_ids.h. If this definition is used in two or more drivers, mention that in the changelog. Otherwise, just use the bare hex value or a private #define in your driver. Bjorn > #define PCI_VENDOR_ID_BELKIN 0x1799 > #define PCI_DEVICE_ID_BELKIN_F5D7010V7 0x701f > > -- > 2.4.0 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id 2015-05-16 14:49 ` Bjorn Helgaas @ 2015-05-16 21:14 ` David Miller 2015-05-18 16:35 ` Bjorn Helgaas 0 siblings, 1 reply; 9+ messages in thread From: David Miller @ 2015-05-16 21:14 UTC (permalink / raw) To: bhelgaas; +Cc: aleksey.makarov, netdev, linux-kernel, david.daney, linux-pci From: Bjorn Helgaas <bhelgaas@google.com> Date: Sat, 16 May 2015 09:49:40 -0500 > Hi Aleksey, > > On Fri, May 15, 2015 at 10:36 PM, Aleksey Makarov > <aleksey.makarov@auriga.com> wrote: >> Signed-off-by: Aleksey Makarov <aleksey.makarov@auriga.com> >> --- >> include/linux/pci_ids.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h >> index e63c02a..3633cc6 100644 >> --- a/include/linux/pci_ids.h >> +++ b/include/linux/pci_ids.h >> @@ -2327,6 +2327,8 @@ >> #define PCI_DEVICE_ID_ALTIMA_AC9100 0x03ea >> #define PCI_DEVICE_ID_ALTIMA_AC1003 0x03eb >> >> +#define PCI_VENDOR_ID_CAVIUM 0x177d > > Please read the note at the top of include/linux/pci_ids.h. If this > definition is used in two or more drivers, mention that in the > changelog. Otherwise, just use the bare hex value or a private > #define in your driver. It is referenced from two foo.c files in the same driver. I don't know what policy we want for situations like that. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id 2015-05-16 21:14 ` David Miller @ 2015-05-18 16:35 ` Bjorn Helgaas 2015-05-18 16:41 ` David Miller 0 siblings, 1 reply; 9+ messages in thread From: Bjorn Helgaas @ 2015-05-18 16:35 UTC (permalink / raw) To: David Miller Cc: aleksey.makarov, netdev, linux-kernel@vger.kernel.org, David Daney, linux-pci@vger.kernel.org, Greg Kroah-Hartman [+cc Greg] On Sat, May 16, 2015 at 4:14 PM, David Miller <davem@davemloft.net> wrote: > From: Bjorn Helgaas <bhelgaas@google.com> > Date: Sat, 16 May 2015 09:49:40 -0500 > >> Hi Aleksey, >> >> On Fri, May 15, 2015 at 10:36 PM, Aleksey Makarov >> <aleksey.makarov@auriga.com> wrote: >>> Signed-off-by: Aleksey Makarov <aleksey.makarov@auriga.com> >>> --- >>> include/linux/pci_ids.h | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h >>> index e63c02a..3633cc6 100644 >>> --- a/include/linux/pci_ids.h >>> +++ b/include/linux/pci_ids.h >>> @@ -2327,6 +2327,8 @@ >>> #define PCI_DEVICE_ID_ALTIMA_AC9100 0x03ea >>> #define PCI_DEVICE_ID_ALTIMA_AC1003 0x03eb >>> >>> +#define PCI_VENDOR_ID_CAVIUM 0x177d >> >> Please read the note at the top of include/linux/pci_ids.h. If this >> definition is used in two or more drivers, mention that in the >> changelog. Otherwise, just use the bare hex value or a private >> #define in your driver. > > It is referenced from two foo.c files in the same driver. > > I don't know what policy we want for situations like that. The current policy (1d4a433fc4e9 ("PCI: Document pci_ids.h addition policy.")) predates me and I don't know the whole rationale. I can see that it might reduce backporting pain for distros. If two foo.c files in the same driver share the PCI ID, they likely share other things as well, so there's likely a shared .h file where a private PCI_VENDOR_ID_CAVIUM could go. But this is a vendor ID (not a device ID), and it seems likely that there will be other devices from Cavium, so maybe it would make sense to apply the policy to device IDs, and go ahead and add vendor IDs to pci_ids.h. Bjorn ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id 2015-05-18 16:35 ` Bjorn Helgaas @ 2015-05-18 16:41 ` David Miller 2015-05-18 17:26 ` Bjorn Helgaas 0 siblings, 1 reply; 9+ messages in thread From: David Miller @ 2015-05-18 16:41 UTC (permalink / raw) To: bhelgaas Cc: aleksey.makarov, netdev, linux-kernel, david.daney, linux-pci, gregkh From: Bjorn Helgaas <bhelgaas@google.com> Date: Mon, 18 May 2015 11:35:20 -0500 > [+cc Greg] > > On Sat, May 16, 2015 at 4:14 PM, David Miller <davem@davemloft.net> wrote: >> From: Bjorn Helgaas <bhelgaas@google.com> >> Date: Sat, 16 May 2015 09:49:40 -0500 >> >>> Hi Aleksey, >>> >>> On Fri, May 15, 2015 at 10:36 PM, Aleksey Makarov >>> <aleksey.makarov@auriga.com> wrote: >>>> Signed-off-by: Aleksey Makarov <aleksey.makarov@auriga.com> >>>> --- >>>> include/linux/pci_ids.h | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h >>>> index e63c02a..3633cc6 100644 >>>> --- a/include/linux/pci_ids.h >>>> +++ b/include/linux/pci_ids.h >>>> @@ -2327,6 +2327,8 @@ >>>> #define PCI_DEVICE_ID_ALTIMA_AC9100 0x03ea >>>> #define PCI_DEVICE_ID_ALTIMA_AC1003 0x03eb >>>> >>>> +#define PCI_VENDOR_ID_CAVIUM 0x177d >>> >>> Please read the note at the top of include/linux/pci_ids.h. If this >>> definition is used in two or more drivers, mention that in the >>> changelog. Otherwise, just use the bare hex value or a private >>> #define in your driver. >> >> It is referenced from two foo.c files in the same driver. >> >> I don't know what policy we want for situations like that. > > The current policy (1d4a433fc4e9 ("PCI: Document pci_ids.h addition > policy.")) predates me and I don't know the whole rationale. I can > see that it might reduce backporting pain for distros. > > If two foo.c files in the same driver share the PCI ID, they likely > share other things as well, so there's likely a shared .h file where a > private PCI_VENDOR_ID_CAVIUM could go. > > But this is a vendor ID (not a device ID), and it seems likely that > there will be other devices from Cavium, so maybe it would make sense > to apply the policy to device IDs, and go ahead and add vendor IDs to > pci_ids.h. That makes sense to me, and therefore this change is probably fine as-is. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id 2015-05-18 16:41 ` David Miller @ 2015-05-18 17:26 ` Bjorn Helgaas 2015-05-18 17:51 ` David Daney 0 siblings, 1 reply; 9+ messages in thread From: Bjorn Helgaas @ 2015-05-18 17:26 UTC (permalink / raw) To: David Miller Cc: Aleksey Makarov, netdev, linux-kernel@vger.kernel.org, David Daney, linux-pci@vger.kernel.org, Greg Kroah-Hartman On Mon, May 18, 2015 at 11:41 AM, David Miller <davem@davemloft.net> wrote: > From: Bjorn Helgaas <bhelgaas@google.com> > Date: Mon, 18 May 2015 11:35:20 -0500 > >> [+cc Greg] >> >> On Sat, May 16, 2015 at 4:14 PM, David Miller <davem@davemloft.net> wrote: >>> From: Bjorn Helgaas <bhelgaas@google.com> >>> Date: Sat, 16 May 2015 09:49:40 -0500 >>> >>>> Hi Aleksey, >>>> >>>> On Fri, May 15, 2015 at 10:36 PM, Aleksey Makarov >>>> <aleksey.makarov@auriga.com> wrote: >>>>> Signed-off-by: Aleksey Makarov <aleksey.makarov@auriga.com> >>>>> --- >>>>> include/linux/pci_ids.h | 2 ++ >>>>> 1 file changed, 2 insertions(+) >>>>> >>>>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h >>>>> index e63c02a..3633cc6 100644 >>>>> --- a/include/linux/pci_ids.h >>>>> +++ b/include/linux/pci_ids.h >>>>> @@ -2327,6 +2327,8 @@ >>>>> #define PCI_DEVICE_ID_ALTIMA_AC9100 0x03ea >>>>> #define PCI_DEVICE_ID_ALTIMA_AC1003 0x03eb >>>>> >>>>> +#define PCI_VENDOR_ID_CAVIUM 0x177d >>>> >>>> Please read the note at the top of include/linux/pci_ids.h. If this >>>> definition is used in two or more drivers, mention that in the >>>> changelog. Otherwise, just use the bare hex value or a private >>>> #define in your driver. >>> >>> It is referenced from two foo.c files in the same driver. >>> >>> I don't know what policy we want for situations like that. >> >> The current policy (1d4a433fc4e9 ("PCI: Document pci_ids.h addition >> policy.")) predates me and I don't know the whole rationale. I can >> see that it might reduce backporting pain for distros. >> >> If two foo.c files in the same driver share the PCI ID, they likely >> share other things as well, so there's likely a shared .h file where a >> private PCI_VENDOR_ID_CAVIUM could go. >> >> But this is a vendor ID (not a device ID), and it seems likely that >> there will be other devices from Cavium, so maybe it would make sense >> to apply the policy to device IDs, and go ahead and add vendor IDs to >> pci_ids.h. > > That makes sense to me, and therefore this change is probably fine as-is. OK. I assume you'll take the whole series, so: Acked-by: Bjorn Helgaas <bhelgaas@google.com> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id 2015-05-18 17:26 ` Bjorn Helgaas @ 2015-05-18 17:51 ` David Daney 0 siblings, 0 replies; 9+ messages in thread From: David Daney @ 2015-05-18 17:51 UTC (permalink / raw) To: Bjorn Helgaas, David Miller Cc: Aleksey Makarov, netdev, linux-kernel@vger.kernel.org, David Daney, linux-pci@vger.kernel.org, Greg Kroah-Hartman On 05/18/2015 10:26 AM, Bjorn Helgaas wrote: > On Mon, May 18, 2015 at 11:41 AM, David Miller <davem@davemloft.net> wrote: >> From: Bjorn Helgaas <bhelgaas@google.com> >> Date: Mon, 18 May 2015 11:35:20 -0500 >> >>> [+cc Greg] >>> >>> On Sat, May 16, 2015 at 4:14 PM, David Miller <davem@davemloft.net> wrote: >>>> From: Bjorn Helgaas <bhelgaas@google.com> >>>> Date: Sat, 16 May 2015 09:49:40 -0500 >>>> >>>>> Hi Aleksey, >>>>> >>>>> On Fri, May 15, 2015 at 10:36 PM, Aleksey Makarov >>>>> <aleksey.makarov@auriga.com> wrote: >>>>>> Signed-off-by: Aleksey Makarov <aleksey.makarov@auriga.com> >>>>>> --- >>>>>> include/linux/pci_ids.h | 2 ++ >>>>>> 1 file changed, 2 insertions(+) >>>>>> >>>>>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h >>>>>> index e63c02a..3633cc6 100644 >>>>>> --- a/include/linux/pci_ids.h >>>>>> +++ b/include/linux/pci_ids.h >>>>>> @@ -2327,6 +2327,8 @@ >>>>>> #define PCI_DEVICE_ID_ALTIMA_AC9100 0x03ea >>>>>> #define PCI_DEVICE_ID_ALTIMA_AC1003 0x03eb >>>>>> >>>>>> +#define PCI_VENDOR_ID_CAVIUM 0x177d >>>>> >>>>> Please read the note at the top of include/linux/pci_ids.h. If this >>>>> definition is used in two or more drivers, mention that in the >>>>> changelog. Otherwise, just use the bare hex value or a private >>>>> #define in your driver. >>>> >>>> It is referenced from two foo.c files in the same driver. >>>> >>>> I don't know what policy we want for situations like that. >>> >>> The current policy (1d4a433fc4e9 ("PCI: Document pci_ids.h addition >>> policy.")) predates me and I don't know the whole rationale. I can >>> see that it might reduce backporting pain for distros. >>> >>> If two foo.c files in the same driver share the PCI ID, they likely >>> share other things as well, so there's likely a shared .h file where a >>> private PCI_VENDOR_ID_CAVIUM could go. >>> >>> But this is a vendor ID (not a device ID), and it seems likely that >>> there will be other devices from Cavium, so maybe it would make sense >>> to apply the policy to device IDs, and go ahead and add vendor IDs to >>> pci_ids.h. >> >> That makes sense to me, and therefore this change is probably fine as-is. > > OK. I assume you'll take the whole series, so: > > Acked-by: Bjorn Helgaas <bhelgaas@google.com> > Thanks guys, Just for the record, the Cavium ThunderX network controller driver (that is part 2/2 of the series), is just the first user of the PCI_VENDOR_ID_CAVIUM. We have in the pipeline drivers/patches for USB (xHCI), SATA (AHCI), GPIO, I2C, MMC, and maybe others that will also be using this #define. I also agree with the concept that the vendor ID has more if a place in pci_ids.h than device IDs (which usually can go in the driver itself). David Daney ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id 2015-05-16 3:36 ` [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id Aleksey Makarov 2015-05-16 14:49 ` Bjorn Helgaas @ 2015-05-18 21:00 ` Aleksey Makarov 2015-05-18 21:06 ` David Miller 1 sibling, 1 reply; 9+ messages in thread From: Aleksey Makarov @ 2015-05-18 21:00 UTC (permalink / raw) To: netdev; +Cc: linux-kernel, David Daney, Bjorn Helgaas, linux-pci Author of this patch is Author: Sunil Goutham <sgoutham@cavium.com> Sorry for this. It will be fixed in next versions. On 05/15/2015 08:36 PM, Aleksey Makarov wrote: > Signed-off-by: Aleksey Makarov <aleksey.makarov@auriga.com> > --- > include/linux/pci_ids.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index e63c02a..3633cc6 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -2327,6 +2327,8 @@ > #define PCI_DEVICE_ID_ALTIMA_AC9100 0x03ea > #define PCI_DEVICE_ID_ALTIMA_AC1003 0x03eb > > +#define PCI_VENDOR_ID_CAVIUM 0x177d > + > #define PCI_VENDOR_ID_BELKIN 0x1799 > #define PCI_DEVICE_ID_BELKIN_F5D7010V7 0x701f > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id 2015-05-18 21:00 ` Aleksey Makarov @ 2015-05-18 21:06 ` David Miller 0 siblings, 0 replies; 9+ messages in thread From: David Miller @ 2015-05-18 21:06 UTC (permalink / raw) To: aleksey.makarov; +Cc: netdev, linux-kernel, david.daney, bhelgaas, linux-pci From: Aleksey Makarov <aleksey.makarov@auriga.com> Date: Mon, 18 May 2015 14:00:22 -0700 > > Author of this patch is > > Author: Sunil Goutham <sgoutham@cavium.com> > > Sorry for this. It will be fixed in next versions. You indicate this with: From: Sunil Goutham <sgoutham@cavium.com> at the top of the commit message when you post the patch. ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-05-18 21:06 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1431747401-20847-1-git-send-email-aleksey.makarov@auriga.com>
2015-05-16 3:36 ` [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id Aleksey Makarov
2015-05-16 14:49 ` Bjorn Helgaas
2015-05-16 21:14 ` David Miller
2015-05-18 16:35 ` Bjorn Helgaas
2015-05-18 16:41 ` David Miller
2015-05-18 17:26 ` Bjorn Helgaas
2015-05-18 17:51 ` David Daney
2015-05-18 21:00 ` Aleksey Makarov
2015-05-18 21:06 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).