From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f172.google.com ([209.85.214.172]:47891 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757111Ab3ETXpb (ORCPT ); Mon, 20 May 2013 19:45:31 -0400 Received: by mail-ob0-f172.google.com with SMTP id tb18so20041obb.3 for ; Mon, 20 May 2013 16:45:31 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1369093321.6387.24.camel@pasglop> References: <20130520231909.32416.81752.stgit@bhelgaas-glaptop> <1369093321.6387.24.camel@pasglop> From: Bjorn Helgaas Date: Mon, 20 May 2013 17:45:11 -0600 Message-ID: Subject: Re: [PATCH 1/2] powerpc/PCI: Use PCI_UNKNOWN for unknown power state To: Benjamin Herrenschmidt Cc: Paul Mackerras , "David S. Miller" , sparclinux@vger.kernel.org, "Rafael J. Wysocki" , linuxppc-dev , "linux-pci@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-pci-owner@vger.kernel.org List-ID: On Mon, May 20, 2013 at 5:42 PM, Benjamin Herrenschmidt wrote: > On Mon, 2013-05-20 at 17:19 -0600, Bjorn Helgaas wrote: >> Previously we initialized dev->current_state to 4 (PCI_D3cold), but I think >> we wanted PCI_UNKNOWN (5) here based on the comment and the fact that the >> generic version of this code, pci_setup_device(), uses PCI_UNKNOWN. >> >> Signed-off-by: Bjorn Helgaas >> --- > > Ack. Do you send to Linus or should I ? I'll add your ack and take care of it. >> arch/powerpc/kernel/pci_of_scan.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/powerpc/kernel/pci_of_scan.c b/arch/powerpc/kernel/pci_of_scan.c >> index 2a67e9b..d2d407d 100644 >> --- a/arch/powerpc/kernel/pci_of_scan.c >> +++ b/arch/powerpc/kernel/pci_of_scan.c >> @@ -165,7 +165,7 @@ struct pci_dev *of_create_pci_dev(struct device_node *node, >> pr_debug(" class: 0x%x\n", dev->class); >> pr_debug(" revision: 0x%x\n", dev->revision); >> >> - dev->current_state = 4; /* unknown power state */ >> + dev->current_state = PCI_UNKNOWN; /* unknown power state */ >> dev->error_state = pci_channel_io_normal; >> dev->dma_mask = 0xffffffff; >> > >