RE: [PATCH] i2c:amd I2C Driver based on PCI Interface for upcoming platform

RE: [PATCH] i2c:amd I2C Driver based on PCI Interface for upcoming platform

[Shah, Nehal-bakulchandra]

Hi All,

Please help in reviewing the patch.


@Wolfram,

Thanks for the update and all the support for helping us.


Regards
Nehal Shah

-----Original Message-----
From: linux-i2c-owner@vger.kernel.org [mailto:linux-i2c-owner@vger.kernel.o=
rg] On Behalf Of Wolfram Sang
Sent: Friday, June 1, 2018 3:13 AM
To: Shah, Nehal-bakulchandra <Nehal-bakulchandra.Shah@amd.com>
Cc: linux-i2c@vger.kernel.org; Singh, Sandeep <Sandeep.Singh@amd.com>; S-k,=
 Shyam-sundar <Shyam-sundar.S-k@amd.com>; Kai Heng Feng <kai.heng.feng@cano=
nical.com>
Subject: Re: [PATCH] i2c:amd I2C Driver based on PCI Interface for upcoming=
 platform

Hi,

> I am waiting for the feedback on this patch. It has been there since=20
> long time. Can you please provide the feedback.

Well, reviewing drivers is a community effort these days. While I am part o=
f this community, I am surely not the only one. So, please ask the list for=
 help (rather than me personally). Furthermore, I think I am not the right =
person here to ask for help. I don't know much about PCI & ACPI. We have de=
dicated I2C-ACPI maintainers, maybe they have some bandwidth for review?

That being said: yes, it is sad that you need to wait this long; yet I simp=
ly can't fill up all the resource problems we have here.

Thanks,

   Wolfram

Re: [PATCH] i2c:amd I2C Driver based on PCI Interface for upcoming platform

[Bjorn Helgaas]

On Mon, Jun 4, 2018 at 11:33 AM Shah, Nehal-bakulchandra
<Nehal-bakulchandra.Shah@amd.com> wrote:
>
> Hi All,
>
> Please help in reviewing the patch.

If you'd like PCI review, please post the patches to linux-pci@vger.kernel.=
org.

> -----Original Message-----
> From: linux-i2c-owner@vger.kernel.org [mailto:linux-i2c-owner@vger.kernel=
.org] On Behalf Of Wolfram Sang
> Sent: Friday, June 1, 2018 3:13 AM
> To: Shah, Nehal-bakulchandra <Nehal-bakulchandra.Shah@amd.com>
> Cc: linux-i2c@vger.kernel.org; Singh, Sandeep <Sandeep.Singh@amd.com>; S-=
k, Shyam-sundar <Shyam-sundar.S-k@amd.com>; Kai Heng Feng <kai.heng.feng@ca=
nonical.com>
> Subject: Re: [PATCH] i2c:amd I2C Driver based on PCI Interface for upcomi=
ng platform
>
> Hi,
>
> > I am waiting for the feedback on this patch. It has been there since
> > long time. Can you please provide the feedback.
>
> Well, reviewing drivers is a community effort these days. While I am part=
 of this community, I am surely not the only one. So, please ask the list f=
or help (rather than me personally). Furthermore, I think I am not the righ=
t person here to ask for help. I don't know much about PCI & ACPI. We have =
dedicated I2C-ACPI maintainers, maybe they have some bandwidth for review?
>
> That being said: yes, it is sad that you need to wait this long; yet I si=
mply can't fill up all the resource problems we have here.
>
> Thanks,
>
>    Wolfram
>

Re: [PATCH] i2c:amd I2C Driver based on PCI Interface for upcoming platform

[Shah, Nehal-bakulchandra]

Hi

Thanks for your valuable input.
On 6/4/2018 10:45 PM, Bjorn Helgaas wrote:
> On Mon, Jun 4, 2018 at 11:33 AM Shah, Nehal-bakulchandra
> <Nehal-bakulchandra.Shah@amd.com> wrote:
>>
>> Hi All,
>>
>> Please help in reviewing the patch.
> 
> If you'd like PCI review, please post the patches to linux-pci@vger.kernel.org.

This patch is more onto I2C which is using PCI Interface. Is it still good to send for linux-pci review? I am really confused how to take it forward. Your suggestion will be well appreciated.
 
>> -----Original Message-----
>> From: linux-i2c-owner@vger.kernel.org [mailto:linux-i2c-owner@vger.kernel.org] On Behalf Of Wolfram Sang
>> Sent: Friday, June 1, 2018 3:13 AM
>> To: Shah, Nehal-bakulchandra <Nehal-bakulchandra.Shah@amd.com>
>> Cc: linux-i2c@vger.kernel.org; Singh, Sandeep <Sandeep.Singh@amd.com>; S-k, Shyam-sundar <Shyam-sundar.S-k@amd.com>; Kai Heng Feng <kai.heng.feng@canonical.com>
>> Subject: Re: [PATCH] i2c:amd I2C Driver based on PCI Interface for upcoming platform
>>
>> Hi,
>>
>>> I am waiting for the feedback on this patch. It has been there since
>>> long time. Can you please provide the feedback.
>>
>> Well, reviewing drivers is a community effort these days. While I am part of this community, I am surely not the only one. So, please ask the list for help (rather than me personally). Furthermore, I think I am not the right person here to ask for help. I don't know much about PCI & ACPI. We have dedicated I2C-ACPI maintainers, maybe they have some bandwidth for review?
>>
>> That being said: yes, it is sad that you need to wait this long; yet I simply can't fill up all the resource problems we have here.
>>
>> Thanks,
>>
>>    Wolfram
>>

Thanks,
Nehal Shah

Re: [PATCH] i2c:amd I2C Driver based on PCI Interface for upcoming platform

[Bjorn Helgaas]

On Thu, Jun 07, 2018 at 03:52:03PM +0530, Shah, Nehal-bakulchandra wrote:
> On 6/4/2018 10:45 PM, Bjorn Helgaas wrote:
> > On Mon, Jun 4, 2018 at 11:33 AM Shah, Nehal-bakulchandra
> > <Nehal-bakulchandra.Shah@amd.com> wrote:
> >>
> >> Hi All,
> >>
> >> Please help in reviewing the patch.
> > 
> > If you'd like PCI review, please post the patches to linux-pci@vger.kernel.org.
> 
> This patch is more onto I2C which is using PCI Interface. Is it
> still good to send for linux-pci review? I am really confused how to
> take it forward. Your suggestion will be well appreciated.

You sent this to linux-pci:

  To: Wolfram Sang <wsa@the-dreams.de>, "mika.westerberg@linux.intel.com" <mika.westerberg@linux.intel.com>, "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>, "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
  ...

  Hi All,

  Please help in reviewing the patch.

That looks like a request for PCI folks to review your patch.  My
point is simply that if you would like PCI people to review it, you
should send the patch to linux-pci@vger.kernel.org.

> >> -----Original Message-----
> >> From: linux-i2c-owner@vger.kernel.org [mailto:linux-i2c-owner@vger.kernel.org] On Behalf Of Wolfram Sang
> >> Sent: Friday, June 1, 2018 3:13 AM
> >> To: Shah, Nehal-bakulchandra <Nehal-bakulchandra.Shah@amd.com>
> >> Cc: linux-i2c@vger.kernel.org; Singh, Sandeep <Sandeep.Singh@amd.com>; S-k, Shyam-sundar <Shyam-sundar.S-k@amd.com>; Kai Heng Feng <kai.heng.feng@canonical.com>
> >> Subject: Re: [PATCH] i2c:amd I2C Driver based on PCI Interface for upcoming platform
> >>
> >> Hi,
> >>
> >>> I am waiting for the feedback on this patch. It has been there since
> >>> long time. Can you please provide the feedback.
> >>
> >> Well, reviewing drivers is a community effort these days. While I am part of this community, I am surely not the only one. So, please ask the list for help (rather than me personally). Furthermore, I think I am not the right person here to ask for help. I don't know much about PCI & ACPI. We have dedicated I2C-ACPI maintainers, maybe they have some bandwidth for review?
> >>
> >> That being said: yes, it is sad that you need to wait this long; yet I simply can't fill up all the resource problems we have here.
> >>
> >> Thanks,
> >>
> >>    Wolfram
> >>
> 
> Thanks,
> Nehal Shah