From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: References: <1336422606-4244-1-git-send-email-yinghai@kernel.org> <1336422606-4244-6-git-send-email-yinghai@kernel.org> From: Bjorn Helgaas Date: Fri, 18 May 2012 12:06:42 -0600 Message-ID: Subject: Re: [PATCH 05/21] resource: adjust_resource handle resource without parent To: Yinghai Lu Cc: Benjamin Herrenschmidt , Tony Luck , David Miller , x86 , Dominik Brodowski , Andrew Morton , Linus Torvalds , Greg Kroah-Hartman , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-arch-owner@vger.kernel.org List-ID: On Fri, May 18, 2012 at 11:54 AM, Yinghai Lu wrote: > On Fri, May 18, 2012 at 10:12 AM, Bjorn Helgaas wrote: >> On Mon, May 7, 2012 at 2:29 PM, Yinghai Lu wrote: > >> Where does this case occur?  When do you need to adjust a resource >> that has no parent? > > for unassigned pci bridge from BIOS, before scan busn_res.end is 0xff, > so you can not insert them, because the bridge could in the middle. > Have to update the busn_res.end and insert after the bridge is scanned Does the resource have children in this case? If it has no parent, it's not in the resource tree at all, is it? Is there any reason to use adjust_resource() rather than just updating res->start and res->end directly?