From: Bjorn Helgaas <bhelgaas@google.com>
To: Jiang Liu <jiang.liu@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>, Len Brown <lenb@kernel.org>,
Lv Zheng <lv.zheng@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [Bugfix v5] x86/PCI/ACPI: Fix regression caused by commit 63f1789ec716
Date: Wed, 29 Apr 2015 08:37:03 -0500 [thread overview]
Message-ID: <CAErSpo7D_CDM+1mzO0ADdzbAE9xwnwiyJ-dk0WFthr+ReKpidg@mail.gmail.com> (raw)
In-Reply-To: <5540DD9C.9030707@linux.intel.com>
On Wed, Apr 29, 2015 at 8:33 AM, Jiang Liu <jiang.liu@linux.intel.com> wrote:
> On 2015/4/29 21:20, Bjorn Helgaas wrote:
>> On Tue, Apr 28, 2015 at 7:40 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>>> On Monday, April 20, 2015 11:08:58 AM Jiang Liu wrote:
>>>> + *
>>>> + * Another possible solution is to explicitly filter out IO
>>>> + * port[0xCF8-0xCFF].
>>>> + */
>>>> + res_flags = IORESOURCE_IO | IORESOURCE_MEM | IORESOURCE_IO_FIXED;
>>
>> 2) The usage of IORESOURCE_IO_FIXED here seems like a hack. It's not
>> related to other existing use of IORESOURCE_IO_FIXED, and it's not
>> intuitive that supplying IORESOURCE_MEM means "I want all the
>> memory-type resources," but supplying IORESOURCE_IO_FIXED means "I
>> *don't* want the fixed I/O-type resources."
>
> Yes, the IORESOURCE_IO_FIXED is a hack here. Then how about explicitly
> filtering IOPORT [0xCF8-0xCFF] so we could avoid such a hack.
I'm OK with that, although it should be in an arch-specific hook or something.
next prev parent reply other threads:[~2015-04-29 13:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 3:08 [Bugfix v5] x86/PCI/ACPI: Fix regression caused by commit 63f1789ec716 Jiang Liu
2015-04-29 0:40 ` Rafael J. Wysocki
2015-04-29 13:20 ` Bjorn Helgaas
2015-04-29 13:33 ` Jiang Liu
2015-04-29 13:37 ` Bjorn Helgaas [this message]
2015-04-30 4:41 ` [Bugfix v6] " Jiang Liu
2015-04-30 13:28 ` Bjorn Helgaas
2015-04-30 20:16 ` Rafael J. Wysocki
2015-04-29 14:15 ` [Bugfix v5] " Rafael J. Wysocki
2015-04-29 13:53 ` Jiang Liu
-- strict thread matches above, loose matches on Subject: below --
2015-04-13 4:31 [Bugfix v3] " Jiang Liu
2015-04-13 6:38 ` [Bugfix v5] " Jiang Liu
2015-04-13 6:56 ` Ingo Molnar
2015-04-13 12:05 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAErSpo7D_CDM+1mzO0ADdzbAE9xwnwiyJ-dk0WFthr+ReKpidg@mail.gmail.com \
--to=bhelgaas@google.com \
--cc=hpa@zytor.com \
--cc=jiang.liu@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).