From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f44.google.com ([74.125.82.44]:54390 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751783Ab2KLVHY (ORCPT ); Mon, 12 Nov 2012 16:07:24 -0500 Received: by mail-wg0-f44.google.com with SMTP id dr13so4462725wgb.1 for ; Mon, 12 Nov 2012 13:07:23 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <201209282356.52558.rjw@sisk.pl> References: <201209282351.10663.rjw@sisk.pl> <201209282356.52558.rjw@sisk.pl> From: Bjorn Helgaas Date: Mon, 12 Nov 2012 14:07:03 -0700 Message-ID: Subject: Re: [RFD][PATCH 7/7] PM / ACPI: Take device PM QoS flags into account To: "Rafael J. Wysocki" Cc: Linux PM list , ACPI Devel Mailing List , Alan Stern , Huang Ying , Sarah Sharp , Lan Tianyu , Aaron Lu , Jean Pihet , linux-pci@vger.kernel.org, Greg Kroah-Hartman , mark gross Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-pci-owner@vger.kernel.org List-ID: On Fri, Sep 28, 2012 at 3:56 PM, Rafael J. Wysocki wrote: > Make ACPI power management routines and PCI power management > routines depending on ACPI take device PM QoS flags into account > when deciding what power state to put the device into. > > In particular, after this change acpi_pm_device_sleep_state() will > not return ACPI_STATE_D3_COLD as the deepest available low-power > state if PM_QOS_FLAG_NO_POWER_OFF is requested for the device and it > will not require remote wakeup to work for the device in the returned > low-power state if there is at least one PM QoS flags request for the > device, but PM_QOS_FLAG_REMOTE_WAKEUP is not requested for it. > > Accordingly, acpi_pci_set_power_state() will refuse to put the > device into D3cold if PM_QOS_FLAG_NO_POWER_OFF is requested for it. > > Signed-off-by: Rafael J. Wysocki > --- > drivers/acpi/sleep.c | 16 ++++++++++++---- > drivers/pci/pci-acpi.c | 8 +++++++- This touches a file in drivers/pci, but I expect it depends on all the previous patches in the series, so if you haven't merged it already, Rafael, it seems like it makes sense for you to merge this instead of me. Bjorn