Re: [PATCH] PCI: Fix device node for virtual bus

[Bjorn Helgaas <bhelgaas@google.com>]

On Tue, Nov 11, 2014 at 7:42 PM, Gavin Shan <gwshan@linux.vnet.ibm.com> wrote:
> pci_set_bus_of_node() sets virtual PCI bus's device node to PHB's
> device node wrongly. The patch fixes the issue.

This needs more detail.  How is this bug visible to users?  Is there a
bug report?  Is this a regression?  Should it be marked for stable?

We use "virtual bus" to refer to buses created for SR-IOV VFs that are
not on the same bus as the PF.  These virtual buses have no bridge
device leading to them.  But I think you're talking about something
totally different.  Or maybe that *is* what you're talking about,
since this patch resembles 2ba29e270e97 ("PCI: Use pci_is_root_bus()
to check for root bus").

Bjorn

> Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
> ---
>  drivers/pci/of.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/of.c b/drivers/pci/of.c
> index f092993..7b2256b 100644
> --- a/drivers/pci/of.c
> +++ b/drivers/pci/of.c
> @@ -31,9 +31,9 @@ void pci_release_of_node(struct pci_dev *dev)
>
>  void pci_set_bus_of_node(struct pci_bus *bus)
>  {
> -       if (bus->self == NULL)
> +       if (pci_is_root_bus(bus))
>                 bus->dev.of_node = pcibios_get_phb_of_node(bus);
> -       else
> +       else if (bus->self)
>                 bus->dev.of_node = of_node_get(bus->self->dev.of_node);
>  }
>
> --
> 1.8.3.2
>