From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ww0-f44.google.com ([74.125.82.44]:49462 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932252Ab2BXRZl convert rfc822-to-8bit (ORCPT ); Fri, 24 Feb 2012 12:25:41 -0500 Received: by wgbdt10 with SMTP id dt10so2291082wgb.1 for ; Fri, 24 Feb 2012 09:25:39 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <20120220191804.GA14499@avionic-0098.adnet.avionic-design.de> <74CDBE0F657A3D45AFBB94109FB122FF17BD8BC302@HQMAIL01.nvidia.com> <20120222082449.GA15157@avionic-0098.adnet.avionic-design.de> <20120223060355.GA21091@avionic-0098.mockup.avionic-design.de> <20120224065921.GA28932@avionic-0098.mockup.avionic-design.de> From: Bjorn Helgaas Date: Fri, 24 Feb 2012 09:25:19 -0800 Message-ID: Subject: Re: PCIe device tree support To: Pratyush Anand Cc: "Olof Johansson (olof@lixom.net)" , Jesse Barnes , linux-pci@vger.kernel.org, Thierry Reding , Stephen Warren , "linux-tegra@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-pci-owner@vger.kernel.org List-ID: On Fri, Feb 24, 2012 at 9:16 AM, Pratyush Anand wrote: > I too had similar query. > I have written a PCIe host driver for SPEAr platform (ARM Arch). > This driver is registered on paltform bus. > It is for Designware IP, so I believe that most of its part > can be re-usaable for other person. >  have kept common and SPEAr specific part separately. > But,  I am not sure about its best location. > I believe best would have been to keep in driver/pci/pcie/hosts/. > But it uses pci_common_init function which is specific to ARM platform. > So it limits option to arch/arm. > But, if I keep it in arch/arm/mach-spear13xx/ , then it will limit others > from using synopsys specific code. > > What do you suggest? If it uses ARM-specific functions, I think somewhere in arch/arm/ makes the most sense. There are some arches (parisc comes to mind) that do have arch-specific code in drivers/, but until it can be usefully shared, that doesn't seem worthwhile to me. We can always move it later. Bjorn