From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59DD4C4363C for ; Wed, 7 Oct 2020 19:45:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB0AE2083B for ; Wed, 7 Oct 2020 19:45:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="XVwPtcfI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728450AbgJGTph (ORCPT ); Wed, 7 Oct 2020 15:45:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728446AbgJGTph (ORCPT ); Wed, 7 Oct 2020 15:45:37 -0400 Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF9A7C061755; Wed, 7 Oct 2020 12:45:36 -0700 (PDT) Received: by mail-ed1-x541.google.com with SMTP id i5so3447566edr.5; Wed, 07 Oct 2020 12:45:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sX1bT/2OZTxhrLyrJFcwzL9j9+e4FMFs/gH/buYyWgg=; b=XVwPtcfIFhx9+HETMjdyxrHwUZkPShOnMZT9GmmTyIvWY9boa+q1M8RJk40R2VXUdj BwePEAMoRCZZcvqDGYOk3OPn7ILRr9Wfqj0lUgadXXoDSXJr2aCs11PIhwEAJQqViYkn fG5BnQcWumfPvb8WTh6/3oaTOBdfUs+XI/OrKDzUGq6OJo2CdUwoZOFYreindYNPFbxZ VCtfUJ0KVNWsUjVozACaOm2+HoTeHHS/0Hn7deT409gwnhl33ftAbQLx+RVglW0UAxXt E7lYzrLcI3jPvP6sK7xSJgliAWXn4S06JUy+HFU5rkmFrLkz80OtGxxOPKYzjMGtYFs9 3Huw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sX1bT/2OZTxhrLyrJFcwzL9j9+e4FMFs/gH/buYyWgg=; b=JR6dzHVINOByvFHvgpFGphnFtjNohM7p+kox0HVK0JYVlsb7vgKjbQNN4c2PqSypuX C5b7Y7V54EQnA0sWNSHxQdYucLH6rsVFYsetJrB62nrcfo1OrW8UQHB4IgS38VmOxpWW JaUQ1o8sC3fk/JYB2lMs3Nzdq3n0CihsVu162c2ZVsMFmkWuvn2xriEgM/Z8BIEV8Ogq ZB7bxE8sZJoELDeArWKlj/ULQg9cKO3qBPELZqXsOk0zL26chNBdVA3OZK3A7BLgZRMr Ne60E8o9V88G+HLjhl4fEyK+G6261yJJuCZCVJDlywX/jAj6/tC7CDsFLgEZT9Snd3wE SQ6Q== X-Gm-Message-State: AOAM531TiEjeI6eytDOFkImsg1tdaj88ENsN+g3hMHpdRJCIKNTBspbV xw546BqHnyJA4VpOoox+sIHYgq+bjS1Q6PKDNa8Kg5ET X-Google-Smtp-Source: ABdhPJzun5TRYD6e0Yxbi+t1s1H3n+3HxwSEp1GkPGK+CulwldlRV2odxetus8T3WyLXbAbkKRKrk/4w8rrIWuRIqGQ= X-Received: by 2002:a50:d94d:: with SMTP id u13mr5121485edj.365.1602099935423; Wed, 07 Oct 2020 12:45:35 -0700 (PDT) MIME-Version: 1.0 References: <20201004162908.3216898-1-martin.blumenstingl@googlemail.com> <20201004162908.3216898-2-martin.blumenstingl@googlemail.com> In-Reply-To: From: Martin Blumenstingl Date: Wed, 7 Oct 2020 21:45:23 +0200 Message-ID: Subject: Re: [RFC PATCH 1/3] PCI: Add the IDs for Etron EJ168 and EJ188 To: Linus Walleij Cc: linux-usb , linux-pci , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:GPIO SUBSYSTEM" , Rob Herring , Bartosz Golaszewski , "linux-kernel@vger.kernel.org" , Bjorn Helgaas Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Linus, On Wed, Oct 7, 2020 at 11:14 AM Linus Walleij wrote: > > On Sun, Oct 4, 2020 at 8:00 PM Martin Blumenstingl > wrote: > > > Add the vendor ID for Etron Technology, Inc. as well as the device IDs > > for the two USB xHCI controllers EJ168 and EJ188. > > > > Signed-off-by: Martin Blumenstingl > > (...) > > > #define PCI_VENDOR_ID_REDHAT 0x1b36 > > > > +#define PCI_VENDOR_ID_ETRON 0x1b6f > > +#define PCI_DEVICE_ID_ETRON_EJ168 0x7023 > > +#define PCI_DEVICE_ID_ETRON_EJ188 0x7052 > > If you're defining that here, I think it should also be > removed in > drivers/usb/host/xhci-pci.c > by including this file instead? you are absolutely right - I missed that part I will change this in v2 - thanks for pointing it out! Best regards, Martin