* [PATCH 1/2] PCI: Mobiveil: export irq_set_msi_desc symbol @ 2017-11-09 10:25 Subrahmanya Lingappa 2017-11-09 12:03 ` [PATCH 1/2 v2] " subrahmanya_lingappa 0 siblings, 1 reply; 6+ messages in thread From: Subrahmanya Lingappa @ 2017-11-09 10:25 UTC (permalink / raw) To: Bjorn Helgaas, linux-pci, Peter W Newton, Mingkai Hu, M.h. Lian, Raj Raina, Rajan Kapoor, Prabhjot Singh, tglx >From e38b741006856f3a3623109dd5ddf5f99326ce61 Mon Sep 17 00:00:00 2001 From: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in> Date: Thu, 9 Nov 2017 04:25:21 -0500 Subject: [PATCH 1/2] PCI: Mobiveil: export irq_set_msi_desc symbol This patch exports irq_set_msi_desc symbol which is used by few PCIe root port drivers. Tested against kernel : 4.9.0-xilinx-v2017.2. Cc: bhelgaas@google.com Cc: tglx@linutronix.de Signed-off-by: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in> --- kernel/irq/chip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c index be3c34e..c4222c4 100644 --- a/kernel/irq/chip.c +++ b/kernel/irq/chip.c @@ -137,6 +137,7 @@ int irq_set_msi_desc(unsigned int irq, struct msi_desc *entry) return irq_set_msi_desc_off(irq, 0, entry); } +EXPORT_SYMBOL(irq_set_msi_desc); /** * irq_set_chip_data - set irq chip data for an irq * @irq: Interrupt number -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/2 v2] PCI: Mobiveil: export irq_set_msi_desc symbol 2017-11-09 10:25 [PATCH 1/2] PCI: Mobiveil: export irq_set_msi_desc symbol Subrahmanya Lingappa @ 2017-11-09 12:03 ` subrahmanya_lingappa 2017-11-09 13:27 ` Thomas Gleixner 0 siblings, 1 reply; 6+ messages in thread From: subrahmanya_lingappa @ 2017-11-09 12:03 UTC (permalink / raw) To: Bjorn Helgaas, linux-pci, Peter W Newton, Mingkai Hu, M.h. Lian, Raj Raina, Rajan Kapoor, Prabhjot Singh, tglx From e38b741006856f3a3623109dd5ddf5f99326ce61 Mon Sep 17 00:00:00 2001 From: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in> Date: Thu, 9 Nov 2017 04:25:21 -0500 Subject: [PATCH 1/2 v2] PCI: Mobiveil: export irq_set_msi_desc symbol This patch exports irq_set_msi_desc symbol which is used by few PCIe root port drivers. Cc: bhelgaas@google.com Cc: tglx@linutronix.de Signed-off-by: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in> --- kernel/irq/chip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c index be3c34e..c4222c4 100644 --- a/kernel/irq/chip.c +++ b/kernel/irq/chip.c @@ -137,6 +137,7 @@ int irq_set_msi_desc(unsigned int irq, struct msi_desc *entry) return irq_set_msi_desc_off(irq, 0, entry); } +EXPORT_SYMBOL(irq_set_msi_desc); /** * irq_set_chip_data - set irq chip data for an irq * @irq: Interrupt number -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2 v2] PCI: Mobiveil: export irq_set_msi_desc symbol 2017-11-09 12:03 ` [PATCH 1/2 v2] " subrahmanya_lingappa @ 2017-11-09 13:27 ` Thomas Gleixner 2017-11-10 0:29 ` Subrahmanya Lingappa 0 siblings, 1 reply; 6+ messages in thread From: Thomas Gleixner @ 2017-11-09 13:27 UTC (permalink / raw) To: subrahmanya_lingappa Cc: Bjorn Helgaas, linux-pci, Peter W Newton, Mingkai Hu, M.h. Lian, Raj Raina, Rajan Kapoor, Prabhjot Singh On Thu, 9 Nov 2017, subrahmanya_lingappa wrote: > From e38b741006856f3a3623109dd5ddf5f99326ce61 Mon Sep 17 00:00:00 2001 > From: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in> > Date: Thu, 9 Nov 2017 04:25:21 -0500 > Subject: [PATCH 1/2 v2] PCI: Mobiveil: export irq_set_msi_desc symbol > > This patch exports irq_set_msi_desc symbol which is used by > few PCIe root port drivers. And which one of those is modular? Thanks, tglx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2 v2] PCI: Mobiveil: export irq_set_msi_desc symbol 2017-11-09 13:27 ` Thomas Gleixner @ 2017-11-10 0:29 ` Subrahmanya Lingappa 2017-11-10 0:39 ` Bjorn Helgaas 0 siblings, 1 reply; 6+ messages in thread From: Subrahmanya Lingappa @ 2017-11-10 0:29 UTC (permalink / raw) To: Thomas Gleixner Cc: Bjorn Helgaas, linux-pci, Peter W Newton, Mingkai Hu, M.h. Lian, Raj Raina, Rajan Kapoor, Prabhjot Singh tglx, On Thu, Nov 9, 2017 at 6:57 PM, Thomas Gleixner <tglx@linutronix.de> wrote: > On Thu, 9 Nov 2017, subrahmanya_lingappa wrote: > >> From e38b741006856f3a3623109dd5ddf5f99326ce61 Mon Sep 17 00:00:00 2001 >> From: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in> >> Date: Thu, 9 Nov 2017 04:25:21 -0500 >> Subject: [PATCH 1/2 v2] PCI: Mobiveil: export irq_set_msi_desc symbol >> >> This patch exports irq_set_msi_desc symbol which is used by >> few PCIe root port drivers. > > And which one of those is modular? > I think this one is, as I see at least 25 other files using it, albeit SoC devices. Hope I got the question right. > Thanks, > > tglx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2 v2] PCI: Mobiveil: export irq_set_msi_desc symbol 2017-11-10 0:29 ` Subrahmanya Lingappa @ 2017-11-10 0:39 ` Bjorn Helgaas 2017-11-10 5:50 ` Subrahmanya Lingappa 0 siblings, 1 reply; 6+ messages in thread From: Bjorn Helgaas @ 2017-11-10 0:39 UTC (permalink / raw) To: Subrahmanya Lingappa Cc: Thomas Gleixner, Bjorn Helgaas, linux-pci, Peter W Newton, Mingkai Hu, M.h. Lian, Raj Raina, Rajan Kapoor, Prabhjot Singh On Fri, Nov 10, 2017 at 05:59:56AM +0530, Subrahmanya Lingappa wrote: > On Thu, Nov 9, 2017 at 6:57 PM, Thomas Gleixner <tglx@linutronix.de> wrote: > > On Thu, 9 Nov 2017, subrahmanya_lingappa wrote: > > > >> From e38b741006856f3a3623109dd5ddf5f99326ce61 Mon Sep 17 00:00:00 2001 > >> From: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in> > >> Date: Thu, 9 Nov 2017 04:25:21 -0500 > >> Subject: [PATCH 1/2 v2] PCI: Mobiveil: export irq_set_msi_desc symbol > >> > >> This patch exports irq_set_msi_desc symbol which is used by > >> few PCIe root port drivers. > > > > And which one of those is modular? > > I think this one is, as I see at least 25 other files using it, albeit > SoC devices. A modular driver would have "tristate" in its Kconfig. You mentioned pcie-xilinx.c, which has: obj-$(CONFIG_PCIE_XILINX) += pcie-xilinx.o config PCIE_XILINX bool "Xilinx AXI PCIe host bridge support" It's "bool", so not modular, so it shouldn't require the EXPORT_SYMBOL(). You saw an undefined symbol error, though. Was that on an upstream kernel, or possibly some other kernel that has changes to make this driver modular? I don't think your mobiveil driver (as posted) requires this EXPORT_SYMBOL() either. Bjorn ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2 v2] PCI: Mobiveil: export irq_set_msi_desc symbol 2017-11-10 0:39 ` Bjorn Helgaas @ 2017-11-10 5:50 ` Subrahmanya Lingappa 0 siblings, 0 replies; 6+ messages in thread From: Subrahmanya Lingappa @ 2017-11-10 5:50 UTC (permalink / raw) To: Bjorn Helgaas Cc: Thomas Gleixner, Bjorn Helgaas, linux-pci, Peter W Newton, Mingkai Hu, M.h. Lian, Raj Raina, Rajan Kapoor, Prabhjot Singh Bjorn, On Fri, Nov 10, 2017 at 6:09 AM, Bjorn Helgaas <helgaas@kernel.org> wrote: > On Fri, Nov 10, 2017 at 05:59:56AM +0530, Subrahmanya Lingappa wrote: >> On Thu, Nov 9, 2017 at 6:57 PM, Thomas Gleixner <tglx@linutronix.de> wrote: >> > On Thu, 9 Nov 2017, subrahmanya_lingappa wrote: >> > >> >> From e38b741006856f3a3623109dd5ddf5f99326ce61 Mon Sep 17 00:00:00 2001 >> >> From: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in> >> >> Date: Thu, 9 Nov 2017 04:25:21 -0500 >> >> Subject: [PATCH 1/2 v2] PCI: Mobiveil: export irq_set_msi_desc symbol >> >> >> >> This patch exports irq_set_msi_desc symbol which is used by >> >> few PCIe root port drivers. >> > >> > And which one of those is modular? >> >> I think this one is, as I see at least 25 other files using it, albeit >> SoC devices. > > A modular driver would have "tristate" in its Kconfig. You mentioned > pcie-xilinx.c, which has: > > obj-$(CONFIG_PCIE_XILINX) += pcie-xilinx.o > > config PCIE_XILINX > bool "Xilinx AXI PCIe host bridge support" > > It's "bool", so not modular, so it shouldn't require the > EXPORT_SYMBOL(). > > You saw an undefined symbol error, though. Was that on an upstream > kernel, or possibly some other kernel that has changes to make this > driver modular? > > I don't think your mobiveil driver (as posted) requires this > EXPORT_SYMBOL() either. > Agreed, I will drop this patch from my next driver revison. > Bjorn ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-10 5:50 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-11-09 10:25 [PATCH 1/2] PCI: Mobiveil: export irq_set_msi_desc symbol Subrahmanya Lingappa 2017-11-09 12:03 ` [PATCH 1/2 v2] " subrahmanya_lingappa 2017-11-09 13:27 ` Thomas Gleixner 2017-11-10 0:29 ` Subrahmanya Lingappa 2017-11-10 0:39 ` Bjorn Helgaas 2017-11-10 5:50 ` Subrahmanya Lingappa
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).