linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ley Foon Tan <lftan@altera.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Rocketboard Maillist <rfi@lists.rocketboards.org>,
	linux-pci@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] PCI: altera: fix loop in tlp_read_packet()
Date: Thu, 5 Nov 2015 09:56:41 +0800	[thread overview]
Message-ID: <CAFiDJ5_P6zcMuJOqC9mwiQY6c95SueG68TQbYe+BUsta-AMEig@mail.gmail.com> (raw)
In-Reply-To: <20151104133936.GI20966@mwanda>

On Wed, Nov 4, 2015 at 9:39 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The problem is that TLP_LOOP is 500 and the "loop" variable was a u8 so
> "loop < TLP_LOOP" is always true.  We only need this condition to work
> if there is a problem so it would have been easy to miss this in
> testing.  Anyway, lets just make it a normal for loop with "int i"
> instead of over thinking things and making it complicated.
>
> Fixes: 6bb4dd154ae8 ('PCI: altera: Add Altera PCIe host controller driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: Ley Foon Tan <lftan@altera.com>

Thanks for the fix.

Regards
Ley Foon

  reply	other threads:[~2015-11-05  1:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04 13:39 [patch] PCI: altera: fix loop in tlp_read_packet() Dan Carpenter
2015-11-05  1:56 ` Ley Foon Tan [this message]
2015-11-25 18:03 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFiDJ5_P6zcMuJOqC9mwiQY6c95SueG68TQbYe+BUsta-AMEig@mail.gmail.com \
    --to=lftan@altera.com \
    --cc=bhelgaas@google.com \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rfi@lists.rocketboards.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).