From: Ulf Magnusson <ulfalizer@gmail.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ley Foon Tan <lftan@altera.com>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
tfiga@chromium.org, paul.burton@mips.com,
Marek Szyprowski <m.szyprowski@samsung.com>,
Hans-Christian Noren Egtvedt <egtvedt@samfundet.no>,
Linus Walleij <linus.walleij@linaro.org>,
vgupta@synopsys.com, mgorman@techsingularity.net, hch@lst.de,
mina86@mina86.com, robh@kernel.org, sboyd@codeaurora.org,
paulus@ozlabs.org, will.deacon@arm.com,
Tony Lindgren <tony@atomide.com>,
Nicholas Piggin <npiggin@gmail.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Ulf Magnusson <ulfalizer@gmail.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 20/20] x86/PCI: VMD: Fix malformed default
Date: Mon, 5 Feb 2018 03:03:29 +0100 [thread overview]
Message-ID: <CAFkk2KRNMKEoArwi9XQryEDe-VMbbL0WySXh_ydLKchke6XQcw@mail.gmail.com> (raw)
In-Reply-To: <20180205012146.23981-21-ulfalizer@gmail.com>
On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote:
> 'default N' should be 'default n', though they happen to have the same
> effect here, due to undefined symbols (N in this case) evaluating to n
> in a tristate sense.
>
> Remove the default from VMD instead of changing it. bool and tristate
> symbols implicitly default to n.
>
> Discovered with the
> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> script.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---
> drivers/pci/host/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index a4ed7484d127..dc8a2a175f19 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -215,7 +215,6 @@ config PCIE_TANGO_SMP8759
> config VMD
> depends on PCI_MSI && X86_64 && SRCU
> tristate "Intel Volume Management Device Driver"
> - default N
> ---help---
> Adds support for the Intel Volume Management Device (VMD). VMD is a
> secondary PCI host bridge that allows PCI Express root ports,
> --
> 2.14.1
>
The PCIE_ALTERA symbol in this file also depends on the globally
undefined symbol OF_PCI, which was removed in 4670d610d592 ("PCI: Move
OF-related PCI functions into PCI core").
Cheers,
Ulf
next prev parent reply other threads:[~2018-02-05 2:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180205012146.23981-1-ulfalizer@gmail.com>
2018-02-05 1:21 ` [PATCH 20/20] x86/PCI: VMD: Fix malformed default Ulf Magnusson
2018-02-05 2:03 ` Ulf Magnusson [this message]
2018-02-06 19:11 ` Bjorn Helgaas
2018-02-06 22:17 ` Ulf Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFkk2KRNMKEoArwi9XQryEDe-VMbbL0WySXh_ydLKchke6XQcw@mail.gmail.com \
--to=ulfalizer@gmail.com \
--cc=bhelgaas@google.com \
--cc=egtvedt@samfundet.no \
--cc=hch@lst.de \
--cc=lftan@altera.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@techsingularity.net \
--cc=mina86@mina86.com \
--cc=npiggin@gmail.com \
--cc=paul.burton@mips.com \
--cc=paulus@ozlabs.org \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=tfiga@chromium.org \
--cc=tony@atomide.com \
--cc=vgupta@synopsys.com \
--cc=will.deacon@arm.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).