From: Pratyush Anand <pratyush.anand@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH v2 0/4] PCI: spear: Cleanups
Date: Tue, 18 Oct 2016 07:01:20 +0530 [thread overview]
Message-ID: <CAHM4w1nAV2vr7rG4spCfShazgm8Smj3ivdAwqWN87tAD32mHxQ@mail.gmail.com> (raw)
In-Reply-To: <20161012160711.GT4308@localhost>
On Wed, Oct 12, 2016 at 9:37 PM, Bjorn Helgaas <helgaas@kernel.org> wrote:
> On Wed, Oct 12, 2016 at 09:04:20AM -0500, Bjorn Helgaas wrote:
>> - Remove unused constants. There's some documentation value in these,
>> but they're only marginally useful to people without the spec, and
>> I think it's preferable to rely on the spec directly to avoid
>> transcription errors.
>>
>> - Pass device-specific struct to internal functions for consistency.
>>
>> - Tidy up usage of local struct device pointers.
>>
>> Nothing here should change the behavior of the driver.
>>
>> Changes from v1:
>> I dropped the following patch because it was lot of churn for
>> questionable benefit:
>> PCI: spear: Name private struct pointer "spear13xx" consistently
>>
>> ---
>>
>> Bjorn Helgaas (4):
>> PCI: spear: Remove unused constants
>> PCI: spear: Pass device-specific struct to internal functions
>> PCI: spear: Reorder struct spear13xx_pcie
>> PCI: spear: Clean up struct device usage
>>
>>
>> drivers/pci/host/pcie-spear13xx.c | 108 +++++++------------------------------
>> 1 file changed, 20 insertions(+), 88 deletions(-)
>
> I applied these to pci/host-spear for v4.9. I hope to ask Linus to
> pull them tomorrow, so if you see any issues, let me know soon.
Bjorn, Thanks for the cleanup and sorry for late reply.
Patches were all fine. Anyway, they are already in Linus's tree.
I have no more SPEAr platform with me, and my working area has also
changed in last two years So, if someone would like to take over its
maintainership, I would be very happy.
~Pratyush
prev parent reply other threads:[~2016-10-18 1:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 14:04 [PATCH v2 0/4] PCI: spear: Cleanups Bjorn Helgaas
2016-10-12 14:04 ` [PATCH v2 1/4] PCI: spear: Remove unused constants Bjorn Helgaas
2016-10-12 14:04 ` [PATCH v2 2/4] PCI: spear: Pass device-specific struct to internal functions Bjorn Helgaas
2016-10-12 14:04 ` [PATCH v2 3/4] PCI: spear: Reorder struct spear13xx_pcie Bjorn Helgaas
2016-10-12 14:04 ` [PATCH v2 4/4] PCI: spear: Clean up struct device usage Bjorn Helgaas
2016-10-12 16:07 ` [PATCH v2 0/4] PCI: spear: Cleanups Bjorn Helgaas
2016-10-18 1:31 ` Pratyush Anand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHM4w1nAV2vr7rG4spCfShazgm8Smj3ivdAwqWN87tAD32mHxQ@mail.gmail.com \
--to=pratyush.anand@gmail.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).