From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f68.google.com ([209.85.215.68]:36637 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752322AbcDZVH5 (ORCPT ); Tue, 26 Apr 2016 17:07:57 -0400 MIME-Version: 1.0 In-Reply-To: <1461578004-129094-4-git-send-email-mika.westerberg@linux.intel.com> References: <1461578004-129094-1-git-send-email-mika.westerberg@linux.intel.com> <1461578004-129094-4-git-send-email-mika.westerberg@linux.intel.com> Date: Tue, 26 Apr 2016 23:07:55 +0200 Message-ID: Subject: Re: [PATCH v4 3/4] ACPI / hotplug / PCI: Runtime resume bridge before rescan From: "Rafael J. Wysocki" To: Mika Westerberg Cc: Bjorn Helgaas , "Rafael J. Wysocki" , Qipeng Zha , Qi Zheng , Dave Airlie , Mathias Nyman , Greg Kroah-Hartman , Lukas Wunner , Andreas Noever , Linux PCI , "linux-pm@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-pci-owner@vger.kernel.org List-ID: On Mon, Apr 25, 2016 at 11:53 AM, Mika Westerberg wrote: > If a PCI bridge (or PCIe port) that is runtime suspended gets an ACPI > hotplug event, such as BUS_CHECK we need to make sure it is resumed before > devices below the bridge are re-scanned. Otherwise the devices behind the > port are not accessible and will be treated as hot-unplugged. > > To fix this, resume PCI bridges from runtime suspend while rescanning. > > Signed-off-by: Mika Westerberg Acked-by: Rafael J. Wysocki > --- > drivers/pci/hotplug/acpiphp_glue.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c > index fa49f9143b80..d64ce8aa99b3 100644 > --- a/drivers/pci/hotplug/acpiphp_glue.c > +++ b/drivers/pci/hotplug/acpiphp_glue.c > @@ -756,8 +756,10 @@ static void hotplug_event(u32 type, struct acpiphp_context *context) > > acpi_lock_hp_context(); > bridge = context->bridge; > - if (bridge) > + if (bridge) { > get_bridge(bridge); > + pm_runtime_get_sync(&bridge->pci_dev->dev); > + } > > acpi_unlock_hp_context(); > > @@ -797,8 +799,10 @@ static void hotplug_event(u32 type, struct acpiphp_context *context) > } > > pci_unlock_rescan_remove(); > - if (bridge) > + if (bridge) { > + pm_runtime_put(&bridge->pci_dev->dev); > put_bridge(bridge); > + } > } > > static int acpiphp_hotplug_notify(struct acpi_device *adev, u32 type) > -- > 2.8.0.rc3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html