From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qc0-f172.google.com ([209.85.216.172]:54077 "EHLO mail-qc0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755663AbaFYUnV (ORCPT ); Wed, 25 Jun 2014 16:43:21 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Wed, 25 Jun 2014 23:43:20 +0300 Message-ID: Subject: Re: mlx4 - query regarding PF VF functionality division From: Or Gerlitz To: Bob Biloxi Cc: "linux-rdma@vger.kernel.org" , "linux-pci@vger.kernel.org" , Jack Morgenstein Content-Type: text/plain; charset=UTF-8 Sender: linux-pci-owner@vger.kernel.org List-ID: On Tue, Jun 24, 2014 at 4:42 PM, Bob Biloxi wrote: > > > Not really, but let's take EIM approach, what's your goal/mission? > Let's say I am going through code to understand only the PF related > functionality without bothering about VF, what are the things I need > to keep in mind. I see, by the nature of the mlx4 SRIOV architecture under which there's no dedicated/separated PF vs VF driver, this is indeed a non-trivial task, need to think how to make it easier for you Or. > > I mean do i need to : > > a. Go through all the files in mlx4 > b. If the code is not specifically under mlx4_is_master, I still need > to understand it because it is also part of PF driver > c. I can ignore the logic which executes if mlx4_is_master is false, > because that would be the VF code > > Thanks for the help!! > > > > > On Mon, Jun 23, 2014 at 5:30 PM, Or Gerlitz wrote: > > On Mon, Jun 23, 2014 at 12:33 PM, Bob Biloxi wrote: > > [...] > >> Is there any way we can clearly separate the files that are used by PF > >> vs the files that are used by VF in the (drivers/net/ethernet/mlx4 > >> sub-directory)? > > [...] > > > > Not really, but let's take EIM approach, what's your goal/mission? > > > > Or.