From: Alistair Francis <alistair23@gmail.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
linux-pci@vger.kernel.org,
Krzysztof Wilczynski <kwilczynski@kernel.org>
Subject: Re: [PATCH 2/2] PCI: Remove obsolete pci_cleanup_rom() declaration
Date: Thu, 2 Nov 2023 13:36:25 +1000 [thread overview]
Message-ID: <CAKmqyKOGZihCMGeqHbkLmusZETJB3B5xH9WWH5DWeK_0go+7Hw@mail.gmail.com> (raw)
In-Reply-To: <fc30de5276e21d5a3ebcb7e58a8b43e399f7e6e6.1698668982.git.lukas@wunner.de>
On Mon, Oct 30, 2023 at 10:34 PM Lukas Wunner <lukas@wunner.de> wrote:
>
> Commit d9c8bea179a6 ("PCI: Remove unused IORESOURCE_ROM_COPY and
> IORESOURCE_ROM_BIOS_COPY") removed pci_cleanup_rom(), but retained
> its declaration in pci.h.
>
> Remove it.
>
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> drivers/pci/pci.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
> index aedaf4e51146..d865c4321e14 100644
> --- a/drivers/pci/pci.h
> +++ b/drivers/pci/pci.h
> @@ -31,7 +31,6 @@ bool pcie_cap_has_rtctl(const struct pci_dev *dev);
>
> /* Functions internal to the PCI core code */
>
> -void pci_cleanup_rom(struct pci_dev *dev);
> #ifdef CONFIG_DMI
> extern const struct attribute_group pci_dev_smbios_attr_group;
> #endif
> --
> 2.40.1
>
next prev parent reply other threads:[~2023-11-02 3:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 12:32 [PATCH 1/2] PCI: Compile pci-sysfs.c only if CONFIG_SYSFS=y Lukas Wunner
2023-10-30 12:33 ` [PATCH 2/2] PCI: Remove obsolete pci_cleanup_rom() declaration Lukas Wunner
2023-11-02 3:36 ` Alistair Francis [this message]
2023-11-02 3:37 ` [PATCH 1/2] PCI: Compile pci-sysfs.c only if CONFIG_SYSFS=y Alistair Francis
2024-02-08 21:44 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKmqyKOGZihCMGeqHbkLmusZETJB3B5xH9WWH5DWeK_0go+7Hw@mail.gmail.com \
--to=alistair23@gmail.com \
--cc=helgaas@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).