From: Karthikeyan Mitran <m.karthikeyan@mobiveil.co.in>
To: "Z.q. Hou" <zhiqiang.hou@nxp.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: Mobiveil legacy IRQ binding erroneous interrupt-map
Date: Tue, 29 Oct 2019 17:20:41 +0530 [thread overview]
Message-ID: <CAKnKUHG2bNZoaLp2OBsnzC9O6vNoLEv8b4ThGee9a0FUckLGGw@mail.gmail.com> (raw)
In-Reply-To: <DB8PR04MB67470C5AD54BC91BA5E2294F84610@DB8PR04MB6747.eurprd04.prod.outlook.com>
Hi Lorenzo, Zhiqiang,
Thanks, will check and fix.
On Tue, Oct 29, 2019 at 5:08 PM Z.q. Hou <zhiqiang.hou@nxp.com> wrote:
>
> Hi Lorenzo,
>
> The Mobiveil INTx controller is not used on NXP's platform, so I cannot verify this feature.
>
> Karthikeyan, please have a look on this issue.
>
> Thanks,
> Zhiqiang
>
> > -----Original Message-----
> > From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> > Sent: 2019年10月16日 18:32
> > To: Z.q. Hou <zhiqiang.hou@nxp.com>; Karthikeyan Mitran
> > <m.karthikeyan@mobiveil.co.in>
> > Cc: linux-pci@vger.kernel.org
> > Subject: Mobiveil legacy IRQ binding erroneous interrupt-map
> >
> > Hi Hou, Karthikeyan,
> >
> > I have just noticed the mobiveil interrupt-map DT bindings example is wrong:
> >
> > This:
> >
> > interrupt-map = <0 0 0 0 &pci_express 0>,
> > <0 0 0 1 &pci_express 1>,
> > <0 0 0 2 &pci_express 2>,
> > <0 0 0 3 &pci_express 3>;
> >
> > should be:
> >
> > interrupt-map = <0 0 0 1 &pci_express 0>,
> > <0 0 0 2 &pci_express 1>,
> > <0 0 0 3 &pci_express 2>,
> > <0 0 0 4 &pci_express 3>;
> >
> > Legacy IRQs Interrupt pins map this way:
> >
> > {{1, INTA}, {2, INTB}, {3,INTC}, {4,INTD}}
> >
> > (as read from Interrupt pin register in the config space header) (ie refer to
> > PCI local bus specification 3.0), please fix it as soon as possible.
> >
> > Lorenzo
--
Thanks,
Regards,
Karthikeyan Mitran
--
Mobiveil INC., CONFIDENTIALITY NOTICE: This e-mail message, including any
attachments, is for the sole use of the intended recipient(s) and may
contain proprietary confidential or privileged information or otherwise be
protected by law. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please notify the
sender and destroy all copies and the original message.
prev parent reply other threads:[~2019-10-29 11:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 10:31 Mobiveil legacy IRQ binding erroneous interrupt-map Lorenzo Pieralisi
2019-10-29 11:38 ` Z.q. Hou
2019-10-29 11:50 ` Karthikeyan Mitran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKnKUHG2bNZoaLp2OBsnzC9O6vNoLEv8b4ThGee9a0FUckLGGw@mail.gmail.com \
--to=m.karthikeyan@mobiveil.co.in \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=zhiqiang.hou@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).