Re: linux-next: Tree for July 12 (pci)

Re: linux-next: Tree for July 12 (pci)

[Randy Dunlap]

On 07/11/2012 11:03 PM, Stephen Rothwell wrote:

> Hi all,
> 
> Changes since 20120710:
> 
> 
> The pci tree lost its conflicts.


on x86_64:

drivers/built-in.o: In function `pci_bus_add_device':
(.text+0x4f62): undefined reference to `pci_fixup_final_inited'


when CONFIG_PCI_QUIRKS is not enabled.


-- 
~Randy

Re: linux-next: Tree for July 12 (pci)

[Myron Stowe]

On Thu, Jul 12, 2012 at 10:11 AM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> On 07/11/2012 11:03 PM, Stephen Rothwell wrote:
>
>> Hi all,
>>
>> Changes since 20120710:
>>
>>
>> The pci tree lost its conflicts.
>
>
> on x86_64:
>
> drivers/built-in.o: In function `pci_bus_add_device':
> (.text+0x4f62): undefined reference to `pci_fixup_final_inited'
>
>
> when CONFIG_PCI_QUIRKS is not enabled.

Nice catch and thanks for the heads up.  My "[PATCH -v2 8/8] PCI:
Integrate 'pci_fixup_final' quirks into hot-plug paths" patch
introduced this - http://marc.info/?l=linux-pci&m=134187007917537&w=2

I'll handle it.

Thanks again,
 Myron

>
> --
> ~Randy
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: Tree for July 12 (pci)

[Myron Stowe]

On Thu, Jul 12, 2012 at 10:11 AM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> On 07/11/2012 11:03 PM, Stephen Rothwell wrote:
>
>> Hi all,
>>
>> Changes since 20120710:
>>
>>
>> The pci tree lost its conflicts.
>
>
> on x86_64:
>
> drivers/built-in.o: In function `pci_bus_add_device':
> (.text+0x4f62): undefined reference to `pci_fixup_final_inited'
>
>
> when CONFIG_PCI_QUIRKS is not enabled.
>
I just posted a patch to  resolve what you encountered.  Would you mind giving
it a try and reporting back with the results?

It's obvious what you ran into, with CONFIG_PCI_QUIRKS not enabled,
./drivers/pci/quirks.o ends up not being generated and included in the
kernel thus
the unresolved reference from ./drivers/pci/bus.o.

I tried to reproduce the failure by disabling my .config file's
CONFIG_PCI_QUIRKS
entry (which in turn required me to enable CONFIG_EXPERT) but that was not
enough to encounter the unresolved reference - although it *should* have been.

Myron
>
> --
> ~Randy
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html