From: Andy Lutomirski <luto@amacapital.net>
To: Andy Lutomirski <luto@kernel.org>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Yijing Wang <wangyijing@huawei.com>,
Linux ACPI <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 1/2] acpi: Tidy up _OSC error spacing
Date: Thu, 19 Nov 2015 13:59:47 -0800 [thread overview]
Message-ID: <CALCETrUV9qbwYT4wSWGHgZ+5uteRMJTeVsJB14FqssbwZqv+nw@mail.gmail.com> (raw)
In-Reply-To: <cd180d52de6dc9e217bd0a0aed32efa68d0c73f8.1447949171.git.luto@kernel.org>
Forwarding to linux-acpi.
On Thu, Nov 19, 2015 at 8:08 AM, Andy Lutomirski <luto@kernel.org> wrote:
> The whitespace in _OSC error reports is weird. Improve it.
>
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
> drivers/acpi/bus.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index a212cefae524..2177ef0b16e4 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -182,12 +182,12 @@ static void acpi_print_osc_error(acpi_handle handle,
> if (ACPI_FAILURE(acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer)))
> printk(KERN_DEBUG "%s\n", error);
> else {
> - printk(KERN_DEBUG "%s:%s\n", (char *)buffer.pointer, error);
> + printk(KERN_DEBUG "%s: %s\n", (char *)buffer.pointer, error);
> kfree(buffer.pointer);
> }
> - printk(KERN_DEBUG"_OSC request data:");
> + printk(KERN_DEBUG "_OSC request data:");
> for (i = 0; i < context->cap.length; i += sizeof(u32))
> - printk("%x ", *((u32 *)(context->cap.pointer + i)));
> + printk(" %x", *((u32 *)(context->cap.pointer + i)));
> printk("\n");
> }
>
> --
> 2.5.0
>
--
Andy Lutomirski
AMA Capital Management, LLC
next prev parent reply other threads:[~2015-11-19 22:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 16:08 [PATCH 0/2] Minor _OSC error handling improvements Andy Lutomirski
2015-11-19 16:08 ` [PATCH 1/2] acpi: Tidy up _OSC error spacing Andy Lutomirski
2015-11-19 21:59 ` Andy Lutomirski [this message]
2015-11-20 1:01 ` Rafael J. Wysocki
2015-11-19 16:08 ` [PATCH 2/2] acpi: Show _OSC UUID when _OSC fails Andy Lutomirski
2015-11-19 22:00 ` Andy Lutomirski
2015-11-19 22:23 ` [PATCH 0/2] Minor _OSC error handling improvements Rafael J. Wysocki
2015-12-03 17:29 ` Bjorn Helgaas
2015-12-15 3:15 ` Andy Lutomirski
2015-12-15 16:10 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALCETrUV9qbwYT4wSWGHgZ+5uteRMJTeVsJB14FqssbwZqv+nw@mail.gmail.com \
--to=luto@amacapital.net \
--cc=bhelgaas@google.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=wangyijing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).