From: Andy Lutomirski <luto@amacapital.net>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: Andy Lutomirski <luto@kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Jingoo Han <jingoohan1@gmail.com>,
Pratyush Anand <pratyush.anand@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: i2c_designware doesn't recover from subdevice driver unload
Date: Fri, 4 Dec 2015 08:33:51 -0800 [thread overview]
Message-ID: <CALCETrVWRDO-Hn49SN94UCy3z0PyPZtwsHOcricRVyPRABjNGA@mail.gmail.com> (raw)
In-Reply-To: <564ECD3D.2080205@linux.intel.com>
On Thu, Nov 19, 2015 at 11:35 PM, Jarkko Nikula
<jarkko.nikula@linux.intel.com> wrote:
> Hi
>
>
> On 11/19/2015 10:39 PM, Andy Lutomirski wrote:
>>
>> On Thu, Nov 19, 2015 at 8:57 AM, Andy Lutomirski <luto@amacapital.net>
>> wrote:
>>>
>>> On Thu, Nov 19, 2015 at 7:56 AM, Andy Lutomirski <luto@kernel.org> wrote:
>>>>
>>>> I unloaded and reloaded hid_multitouch (on a Skylake laptop where the
>>>> HID device is behind an integrated designware controller) and I got:
>>>>
>>>> [39545.054684] i2c_hid i2c-DLL0704:01: failed to retrieve report from
>>>> device.
>>>> [39545.061728] i2c_designware i2c_designware.1:
>>>> i2c_dw_handle_tx_abort: lost arbitration
>>>> [39545.061734] i2c_hid i2c-DLL0704:01: failed to retrieve report from
>>>> device.
>>>> [39545.061944] i2c_hid i2c-DLL0704:01: failed to retrieve report from
>>>> device.
>>>> [39545.062373] i2c_hid i2c-DLL0704:01: error in i2c_hid_init_report
>>>> size:6 / ret_size:4
>>>> [39545.062564] i2c_hid i2c-DLL0704:01: failed to retrieve report from
>>>> device.
>>>> [39545.062636] input: DLL0704:01 06CB:76AE UNKNOWN as
>>>>
>>>> /devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-7/i2c-DLL0704:01/0018:06CB:76AE.0005/input/input20
>>>> [39545.063212] hid-multitouch 0018:06CB:76AE.0005: input,hidraw1:
>>>> <UNKNOWN> HID v1.00 Mouse [DLL0704:01 06CB:76AE] on
>>>> [40178.534814] i2c_hid i2c-DLL0704:01: failed to retrieve report from
>>>> device.
>>>> [40178.541848] i2c_designware i2c_designware.1:
>>>> i2c_dw_handle_tx_abort: lost arbitration
>>>> [40178.541853] i2c_hid i2c-DLL0704:01: failed to retrieve report from
>>>> device.
>>>> [40179.542135] i2c_designware i2c_designware.1: controller timed out
>>>> [40179.542166] i2c_hid i2c-DLL0704:01: failed to retrieve report from
>>>> device.
>>>> [40180.542909] i2c_designware i2c_designware.1: controller timed out
>>>> [40180.542942] i2c_hid i2c-DLL0704:01: failed to retrieve report from
>>>> device.
>>>> [40181.543697] i2c_designware i2c_designware.1: controller timed out
>>>>
>>>> after that, I just keep seeing "controller timed out" messages.
>>>>
>>>> This is Linux 4.3.0.
>>>
>>>
>>> This just happened again (after a reboot) on its own without any
>>> rmmod. Reloading the i2c_designware drivers didn't help, so I'm
>>> wondering if it's a bug lower in the stack instead.
>>>
> I guess this is either related to touch panel or bus timings (we have seen
> both cases recently) as it works here on development machine with another
> panel.
>
> Could you try does following commit from v4.4-rc1 help?
>
> 6d4f5440a3a2 ("HID: multitouch: Fetch feature reports on demand for Win8
> devices")
I've been running that commit for a couple weeks and I haven't seen
the problem recur. Thanks!
--Andy
prev parent reply other threads:[~2015-12-04 16:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 15:56 i2c_designware doesn't recover from subdevice driver unload Andy Lutomirski
2015-11-19 16:57 ` Andy Lutomirski
2015-11-19 20:39 ` Andy Lutomirski
2015-11-20 7:35 ` Jarkko Nikula
2015-12-04 16:33 ` Andy Lutomirski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALCETrVWRDO-Hn49SN94UCy3z0PyPZtwsHOcricRVyPRABjNGA@mail.gmail.com \
--to=luto@amacapital.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jingoohan1@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=pratyush.anand@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).