From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C765C43334 for ; Mon, 6 Jun 2022 21:33:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231244AbiFFVdz (ORCPT ); Mon, 6 Jun 2022 17:33:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234965AbiFFVdu (ORCPT ); Mon, 6 Jun 2022 17:33:50 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64B55C6E71; Mon, 6 Jun 2022 14:33:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1B187B81BD4; Mon, 6 Jun 2022 21:33:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5C84C341C4; Mon, 6 Jun 2022 21:33:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654551222; bh=4lwYtXk+4KNqnXm/SLQ7kW5r0PHmTjZ4GioeZ/31n5c=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=KZ6lawMZIlv5iYXXPpncFyh7qlTwHGAU9TSXnGn/rCm9JGb+gimGAWjSGYmapjRB1 CTw7HRh/eh0F+Fmxv4r3WysZrFREJzB6OTf3z1ZgwSh3UF180X8YHAFUxqMV38csKL MMPhB19V9ymOR6LT4CZlh7Ah09lbtY65uUalD5054w+640LWRHmhyr0A4ofuQ0Evmv 1087o137RfajV3IXk8e1TlqEkMDCIYQXclj4c9TXZiCOEHFttsJi/sXpWT9wmzGi+D jK2axiltoxoPiMa2Rh6Gk5zFX5iSPPPGtHEWQxWc0BrVrZXN3SkhnjEXv4jh09xTuJ cj0K+SboPFAAw== Received: by mail-vk1-f180.google.com with SMTP id z17so795376vkb.13; Mon, 06 Jun 2022 14:33:42 -0700 (PDT) X-Gm-Message-State: AOAM532M+MtpPY0XgUCJ6quYBSCT6UsoKUFZOONFN3FpQphuedLzFWg7 LLd/n5PSDPWKA8huloGy//0dr2b6ueBj8gOjWA== X-Google-Smtp-Source: ABdhPJz7B9SjuuJ/LcX9SZnE+gp0M1PXpZFb3AXX9LvPuOzOLmsuxSf7KuKtw6+ijxYCZ7ctPKQTofCx5GjKQgxEzO4= X-Received: by 2002:a1f:a1c6:0:b0:35e:3f6a:b8b8 with SMTP id k189-20020a1fa1c6000000b0035e3f6ab8b8mr1953690vke.26.1654551221808; Mon, 06 Jun 2022 14:33:41 -0700 (PDT) MIME-Version: 1.0 References: <20220603130849.38252-1-linmq006@gmail.com> In-Reply-To: <20220603130849.38252-1-linmq006@gmail.com> From: Rob Herring Date: Mon, 6 Jun 2022 16:33:30 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] PCI: brcmstb: Fix refcount leak in brcm_pcie_probe To: Miaoqian Lin Cc: Nicolas Saenz Julienne , Broadcom internal kernel review list , Jim Quinlan , Florian Fainelli , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , Marc Zyngier , Andrew Murray , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , linux-arm-kernel , PCI , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Jun 3, 2022 at 8:09 AM Miaoqian Lin wrote: > > of_parse_phandle() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: 40ca1bf580ef ("PCI: brcmstb: Add MSI support") > Signed-off-by: Miaoqian Lin > --- > changes in v2: > - update Fixes tag. > v1 Link: https://lore.kernel.org/r/20220602125003.10723-1-linmq006@gmail.com > --- > drivers/pci/controller/pcie-brcmstb.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Rob Herring