From: Rob Herring <robh@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Fabio Estevam <festevam@gmail.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Fabio Estevam <fabio.estevam@freescale.com>,
Tanmay Inamdar <tinamdar@apm.com>
Subject: Re: [PATCH] PCI: xgene: Fix xgene_pcie_map_bus() return type
Date: Wed, 25 Feb 2015 19:10:35 -0600 [thread overview]
Message-ID: <CAL_JsqJKkRQLkMkSc_S1RLGRbRCc-6GoFYrvOtY3WgPs_qpdmA@mail.gmail.com> (raw)
In-Reply-To: <20150226010438.GT6220@google.com>
On Wed, Feb 25, 2015 at 7:04 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> [+cc Tanmay]
>
> On Mon, Feb 09, 2015 at 06:12:11PM -0200, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Commit 350f8be5bb402a1 ("PCI: xgene: Convert to use generic config accessors")
>> introduced the following build warnings:
>>
>> drivers/pci/host/pci-xgene.c:137:3: warning: return makes integer from pointer without a cast
>> drivers/pci/host/pci-xgene.c:140:2: warning: return makes integer from pointer without a cast
>> drivers/pci/host/pci-xgene.c:144:2: warning: initialization from incompatible pointer type
>> drivers/pci/host/pci-xgene.c:144:2: warning: (near initialization for 'xgene_pcie_ops.map_bus')
>>
>> The .map_bus function should return 'void __iomem *' instead of 'int'.
>>
>> Reported-by: Olof's autobuilder <build@lixom.net>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Applied to for-linus for v4.0, thanks!
>
> Rob, Tanmay, speak up if you object.
While this fixes the warning, it doesn't fix the real problem. You
should apply this instead:
https://patchwork.ozlabs.org/patch/440759/
Rob
>
>> ---
>> drivers/pci/host/pci-xgene.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c
>> index aab5547..22addb6 100644
>> --- a/drivers/pci/host/pci-xgene.c
>> +++ b/drivers/pci/host/pci-xgene.c
>> @@ -127,7 +127,7 @@ static bool xgene_pcie_hide_rc_bars(struct pci_bus *bus, int offset)
>> return false;
>> }
>>
>> -static int xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn,
>> +static void __iomem *xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn,
>> int offset)
>> {
>> struct xgene_pcie_port *port = bus->sysdata;
>> --
>> 1.9.1
>>
next prev parent reply other threads:[~2015-02-26 1:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 20:12 [PATCH] PCI: xgene: Fix xgene_pcie_map_bus() return type Fabio Estevam
2015-02-26 1:04 ` Bjorn Helgaas
2015-02-26 1:10 ` Rob Herring [this message]
2015-02-26 1:21 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJKkRQLkMkSc_S1RLGRbRCc-6GoFYrvOtY3WgPs_qpdmA@mail.gmail.com \
--to=robh@kernel.org \
--cc=bhelgaas@google.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=tinamdar@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).