From: Rob Herring <robh@kernel.org>
To: matthew.gerlach@linux.intel.com
Cc: lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com,
krzk+dt@kernel.org, conor+dt@kernel.org, dinguyen@kernel.org,
joyce.ooi@intel.com, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v2 1/7] dt-bindings: PCI: altera: Convert to YAML
Date: Fri, 9 Aug 2024 13:36:25 -0600 [thread overview]
Message-ID: <CAL_JsqJg_ahW451sBht1k5SxP9s4dE09F-EWrgdXdDpUPFDfcQ@mail.gmail.com> (raw)
In-Reply-To: <98185d65-805f-f09d-789-6eda61c4b36d@linux.intel.com>
On Fri, Aug 9, 2024 at 12:43 PM <matthew.gerlach@linux.intel.com> wrote:
> On Fri, 9 Aug 2024, Rob Herring wrote:
>
> > On Fri, Aug 09, 2024 at 10:12:07AM -0500, matthew.gerlach@linux.intel.com wrote:
> >> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> >>
> >> Convert the device tree bindings for the Altera Root Port PCIe controller
> >> from text to YAML. Update the entries in the interrupt-map field to have
> >> the correct number of address cells for the interrupt parent.
> >>
> >> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> >> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> >> ---
> >> v8:
> >
> > v2 or v8 or ??? I'm confused and tools will be too.
>
> Sorry for the confusion. Patch 1 and patch 2 were individually reviewed
> previously. Patch 1 was previously reviewed up to v8, and I included them
> in the greater patch set for convience and completeness, and this is v2 of
> the entire patch set.
>
> How should this be handled for better clarity? Would it be better to not
> to include Patch 1 and 2 in the patch set and refer to them, or would it
> better to remove the history in patch 1 and 2, or something else?
Generally, if you added new patches you keep the versioning and say
"vN: new patch" in the new patches.
If this was 2 prior series, combined, there's not really a good answer
other than don't do that.
Rob
next prev parent reply other threads:[~2024-08-09 19:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 15:12 [PATCH v2 0/7] Add PCIe Root Port support for Agilex family of chips matthew.gerlach
2024-08-09 15:12 ` [PATCH v2 1/7] dt-bindings: PCI: altera: Convert to YAML matthew.gerlach
2024-08-09 18:14 ` Rob Herring
2024-08-09 18:41 ` matthew.gerlach
2024-08-09 19:36 ` Rob Herring [this message]
2024-09-20 15:26 ` matthew.gerlach
2024-08-09 15:12 ` [PATCH v2 2/7] dt-bindings: PCI: altera: msi: " matthew.gerlach
2024-08-09 15:12 ` [PATCH v2 3/7] dt-bindings: PCI: altera: Add binding for Agilex matthew.gerlach
2024-08-09 15:12 ` [PATCH v2 4/7] arm64: dts: agilex: add soc0 label matthew.gerlach
2024-08-09 15:12 ` [PATCH v2 5/7] arm64: dts: agilex: add dtsi for PCIe Root Port matthew.gerlach
2024-08-09 15:12 ` [PATCH v2 6/7] arm64: dts: agilex: add dts enabling " matthew.gerlach
2024-08-09 15:12 ` [PATCH v2 7/7] PCI: altera: Add Agilex support matthew.gerlach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJg_ahW451sBht1k5SxP9s4dE09F-EWrgdXdDpUPFDfcQ@mail.gmail.com \
--to=robh@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=joyce.ooi@intel.com \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=matthew.gerlach@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).