From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f45.google.com (mail-vs1-f45.google.com [209.85.217.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9601D67E67 for ; Tue, 20 Feb 2024 11:22:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708428176; cv=none; b=DzE0Jhzwcvyk34QrkQ4IMsEsI+rncs9++wyXAWW6qHsuDk3UEOMLLNNmHAs+QsvhC0xrDQRlk51OP+BrwQ8otmXTWPnACPms2ns8rtpPYydULdGJmOm/zcSYWeCFEmt7NCGHYNDfCzy7BC4QSlybOQkhWz9hjLubSVhotWifrVc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708428176; c=relaxed/simple; bh=dQqffqh6T4LO8Z67UPdabicBep7/vKvQtPnTrA6jWl0=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=DTigkGli4zddVe6mghme4kPFBd9T7lY4fOYspwbeRuJW2Ci0l25GZwn0gUSMvWP+Ts+vQWoPaMZiZsXGTGSGzw4yQmdSII0BJyudVWybw3zYhYstPhoLSGH5sDVsHKSh5tyQnHqoyD+3YIJCQ74jugdeUQ910Sj3zNrxFgb2++k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=vSO0mx5a; arc=none smtp.client-ip=209.85.217.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="vSO0mx5a" Received: by mail-vs1-f45.google.com with SMTP id ada2fe7eead31-47064e95199so323070137.3 for ; Tue, 20 Feb 2024 03:22:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1708428173; x=1709032973; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tnGpsA2N+oEjNvZD5MvHoPc7WS23uAKNUryh+bWrqLI=; b=vSO0mx5a+FNZasQYE4RcLEccUm4jxE8F3vYw1Sc5Z6kw5LmrJjsBHkEAhmB/OwiObt tP8uQWrOti3T4Rsuxd2Dqutiv+AGL72KptpRTUkZnO4DrhN39ZYEcR8wGuugsTxpFzN7 lQyH9QDVQWiZp67zAJGmlFmxUG44rWwjGYkA4JBpouU3dzGX53eAy0Vv5CiKJSR7jW2u Bgca6eN8Oj+QhK3B5CBSfGP3EnYlRfI1NNrpHpbcj623KRgeabfPIRWT4zzt3u/8VT9A 3G7DDvfLBZ5+7czw32tDwcCPbEA+IOYiiR/QTDyburwckbN3vOFgvgyvYIRhLTX3n1qu m82w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708428173; x=1709032973; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tnGpsA2N+oEjNvZD5MvHoPc7WS23uAKNUryh+bWrqLI=; b=ex28g8utBNd4+TkeV+kH3t6DxutsLGBCJE6wPo7g+hiVvl8pERM3Svn7J8FnSkhYx0 5C3F20Yj3OGsdharaq3FBAzxXEuNMDchwraIU2WRXrFdhZxllJi33NYjoapONEX5IQ9e gbgneAmmsH4RzCdrwBWg54BCnj7DzjEsAlTpDVua3TV/ESp+/Xjurs7IRCaiFiXtE6tX D1NzLVAHVeUIS9mi+7Ak9IztckdNaNA6xAU4FUozJ1ehvprVmYC7MvEWgwSUbV/TEWPw IY/qEuZ+Y1CpAx/+xLElGSSKRpFYt0Er3JDzEotnSPyLYIs73rrOzg/hkCYtgjHfGPae ug9A== X-Forwarded-Encrypted: i=1; AJvYcCUo0/nhjnVnYFP9U0X0+7vMTsP/6EecuKg4pmhyM8JURfcXTRpPB8rsGAiN3FjUn7Ut8avXfmCQFjG7gX+bjXEdDX60urAOrCH4 X-Gm-Message-State: AOJu0Yz+/s45bhQVKuB8zeY5HWm3z1rXhrCVQpqPm57gWsgt1iIRHy0C Fi0OG+Ct5eWCcukQEQLgkSYTke9ibYyr+RidU6QI/mDs4M9ejNiV830Ny2AWNi0MqynN6/uhVSd 5etwhhMH22+C3EaDQWst9/9gdKWuf6Yba0oDGSQ== X-Google-Smtp-Source: AGHT+IGmypbXGvIgsXnS85V0NkbV+58vcVfrux92hdJBvsnBD1MJ/T8V6U4tgekizLSc354z11MbuHbewdtd9TTnF58= X-Received: by 2002:a67:ec0a:0:b0:470:4dd8:b18 with SMTP id d10-20020a67ec0a000000b004704dd80b18mr5421598vso.19.1708428173554; Tue, 20 Feb 2024 03:22:53 -0800 (PST) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240216203215.40870-1-brgl@bgdev.pl> <20240216203215.40870-15-brgl@bgdev.pl> In-Reply-To: From: Bartosz Golaszewski Date: Tue, 20 Feb 2024 12:22:42 +0100 Message-ID: Subject: Re: [PATCH v5 14/18] PCI/pwrctl: add a power control driver for WCN7850 To: Mark Brown Cc: Marcel Holtmann , Luiz Augusto von Dentz , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kalle Valo , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Catalin Marinas , Will Deacon , Bjorn Helgaas , Saravana Kannan , Geert Uytterhoeven , Arnd Bergmann , Neil Armstrong , Marek Szyprowski , Alex Elder , Srini Kandagatla , Greg Kroah-Hartman , Abel Vesa , Manivannan Sadhasivam , Lukas Wunner , Dmitry Baryshkov , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Feb 19, 2024 at 6:50=E2=80=AFPM Mark Brown wro= te: > > On Fri, Feb 16, 2024 at 09:32:11PM +0100, Bartosz Golaszewski wrote: > > > +static struct pci_pwrctl_wcn7850_vreg pci_pwrctl_wcn7850_vregs[] =3D { > > + { > > + .name =3D "vdd", > > + .load_uA =3D 16000, > > + }, > > I know a bunch of the QC stuff includes these load numbers but are they > actually doing anything constructive? It keeps coming up that they're > causing a bunch of work and it's not clear that they have any great > effect on modern systems. > Yes, we have what is called a high-power mode and a low-power mode in regulators and these values are used to determine which one to use. > > +static int pci_pwrctl_wcn7850_power_on(struct pci_pwrctl_wcn7850_ctx *= ctx) > > +{ > > + int ret; > > + > > + ret =3D regulator_bulk_enable(ctx->pdata->num_vregs, ctx->regs); > > + if (ret) > > + return ret; > > + > > + ret =3D clk_prepare_enable(ctx->clk); > > + if (ret) > > + return ret; > > This won't disable the regulators on error. Indeed. Thanks for catching this. Bart