From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50B561BA89C for ; Fri, 25 Oct 2024 07:57:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729843059; cv=none; b=qX4ovWzEsGSpuK6osNOK7SN4thivKwcm/CLsrifr5kH3lDXjctXap+RSmJRL+D8k9wNzBKngfkWrG+smPKex/Gi/JK0IMZ3bAj48nFLO0wXN8WyEEC/5AT/vEIYRrq6g1DsKgvrrxav1SvCn1kprfheg6jI3dXYrtEQ60FaupBY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729843059; c=relaxed/simple; bh=GUWVH2uka6Ld8tCz6VApcxZXAPIqIZt0tZL1jnDrQdk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=DL2zVdYnjmIZBJrORz3MTPzy9sUSqF9JzjBZSfGRlefV1byqm/Ztk+b35nMbTBb4Uz9x6B2fhhvZagFnt2pyp+3KD1a4Yu6obQ99tJ0QUL0eCZgIDob60sN7LiZscCrEA5kM3k2ob/o7Vq+KBwKPfFb497Ry0m3uthh3T6fKQJA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=1fOE+Hpq; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="1fOE+Hpq" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-539f8490856so1657447e87.2 for ; Fri, 25 Oct 2024 00:57:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1729843055; x=1730447855; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XMR9mRKdj+7kyzA4vhiQt23W1ro+2aLzgQAgkPaGHvo=; b=1fOE+HpqWTSJs93V/tSdANSYrglX1QBr7zHBd4sR/rYtAibgoLOmMgz1+DM04ZlN+g ZF8EroAa7as8kaQ2t+hnHj1OC5osSmkUC30GNeeapxpXdXJ8QQsvf1y6dM9//QeSc/v2 xnU0G8YciREuXgaFGHclkp2ABFoFSXQJIddUJHI763C+e0PMUDCbWom3FeE5TnzjIuO1 Hti8HSqtC06JUPecBYJwCLYHrQV4cYky/yvczySIHL0GfkukZLa9aAATGzdgKHfu/MdD ab13Kc3ytDJvNhoXcXa2CaiJIfil4r5UoRYEzQopUqgE1/HpgfmPDneuhM3sBg0S/4HS oqUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729843055; x=1730447855; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XMR9mRKdj+7kyzA4vhiQt23W1ro+2aLzgQAgkPaGHvo=; b=gEH00KPu272CzgSBiQfzt4wDAu9Ww++G4RdQj2HstOvCUAc5fTGRhiodPreDT+7++1 Rj/YRj9iN/KD5Ri/Ewa6fZuLC1nQGhMdK85CSf8Iei3qg46w4SHvtj2LuVa7xoLwdlNg MTh4b1XU+rvmdOLdCxuF0A1suZa1DFX6WgTQ7DJwSxSJSvrgP/00AEAHe0l7j+dcXnBo mwPoC0S4o1N2+Gkccr8CmIuElYBtZbPr/ehbGKf6QaGB3qtC7BJYwtE1t4cc3uF4O5qh MijnTuiC2zto3w7wPLvsZWp8JOhgctH9yE4Ob+h8uc+kb/EHP0B2zXIVRgpDeNv1JolS UYWg== X-Forwarded-Encrypted: i=1; AJvYcCUpM4Oyxjxooo50OAA7KD6iz+zUM7rL0F298eTdevKxuNnoxS4HNNVF7ggV2PiDRS+TrrkxY/XCVaw=@vger.kernel.org X-Gm-Message-State: AOJu0YxG8FNCQGQMD425UmEpE9TlQ3Bx47pZGFEMxuLY/2RQso5ZjYdd b/S0yDEcb6NxMIC1cy/gpDPaahlfnNB2ePMlyjmoWqFZnfZkMk9ZWWGrgnqHqmLufzQOFXfvggj tTXlb6yf3NbRH5gwNSkZlO2U3gQJDzAeJ4CfMAg== X-Google-Smtp-Source: AGHT+IG81yduQs+Bl3t/NFGz2vsyEiOruGsX6ejobqqT+9o7J2c4ElDzuZkjCn3QbP2hahDTUHVemSq8Xd5QxoUYmdw= X-Received: by 2002:a05:6512:2354:b0:539:f12f:2531 with SMTP id 2adb3069b0e04-53b1a37ca2bmr5293218e87.50.1729843055382; Fri, 25 Oct 2024 00:57:35 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20241025-pci-pwrctl-rework-v2-0-568756156cbe@linaro.org> <20241025-pci-pwrctl-rework-v2-1-568756156cbe@linaro.org> In-Reply-To: <20241025-pci-pwrctl-rework-v2-1-568756156cbe@linaro.org> From: Bartosz Golaszewski Date: Fri, 25 Oct 2024 09:57:23 +0200 Message-ID: Subject: Re: [PATCH v2 1/5] PCI/pwrctl: Use of_platform_device_create() to create pwrctl devices To: manivannan.sadhasivam@linaro.org Cc: Bjorn Helgaas , Bartosz Golaszewski , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov , Johan Hovold , Abel Vesa , Stephan Gerhold , Srinivas Kandagatla , Bjorn Andersson , Krishna chaitanya chundru Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Oct 25, 2024 at 9:55=E2=80=AFAM Manivannan Sadhasivam via B4 Relay wrote: > > From: Manivannan Sadhasivam > > of_platform_populate() API creates platform devices by descending through > the children of the parent node. But it provides no control over the chil= d > nodes, which makes it difficult to add checks for the child nodes in the > future. So use of_platform_device_create() API together with > for_each_child_of_node_scoped() so that it is possible to add checks for > each node before creating the platform device. > > Tested-by: Krishna chaitanya chundru > Tested-by: Bartosz Golaszewski > Signed-off-by: Manivannan Sadhasivam > --- > drivers/pci/bus.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c > index 55c853686051..9d278d3a19ff 100644 > --- a/drivers/pci/bus.c > +++ b/drivers/pci/bus.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -329,6 +330,7 @@ void __weak pcibios_bus_add_device(struct pci_dev *pd= ev) { } > void pci_bus_add_device(struct pci_dev *dev) > { > struct device_node *dn =3D dev->dev.of_node; > + struct platform_device *pdev; > int retval; > > /* > @@ -351,11 +353,11 @@ void pci_bus_add_device(struct pci_dev *dev) > pci_dev_assign_added(dev, true); > > if (dev_of_node(&dev->dev) && pci_is_bridge(dev)) { > - retval =3D of_platform_populate(dev_of_node(&dev->dev), N= ULL, NULL, > - &dev->dev); > - if (retval) > - pci_err(dev, "failed to populate child OF nodes (= %d)\n", > - retval); > + for_each_available_child_of_node_scoped(dn, child) { > + pdev =3D of_platform_device_create(child, NULL, &= dev->dev); > + if (!pdev) > + pci_err(dev, "failed to create OF node: %= s\n", child->name); > + } > } > } > EXPORT_SYMBOL_GPL(pci_bus_add_device); > > -- > 2.25.1 > > Reviewed-by: Bartosz Golaszewski