From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f181.google.com ([209.85.216.181]:38684 "EHLO mail-qt0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751348AbeDIIes (ORCPT ); Mon, 9 Apr 2018 04:34:48 -0400 MIME-Version: 1.0 In-Reply-To: <4462b4d1-1e56-d6d2-ad38-8f02405d1d96@cogentembedded.com> References: <23335d95-63ca-b107-e43d-f4c2621adc2c@cogentembedded.com> <4462b4d1-1e56-d6d2-ad38-8f02405d1d96@cogentembedded.com> From: Geert Uytterhoeven Date: Mon, 9 Apr 2018 10:34:47 +0200 Message-ID: Subject: Re: [PATCH 4/4] pcie-rcar: factor out rcar_pcie_hw_init() call To: Sergei Shtylyov Cc: Simon Horman , Bjorn Helgaas , linux-pci , Linux-Renesas , Lorenzo Pieralisi Content-Type: text/plain; charset="UTF-8" Sender: linux-pci-owner@vger.kernel.org List-ID: On Fri, Apr 6, 2018 at 1:10 PM, Sergei Shtylyov wrote: > We now have rcar_pcie_hw_init_{h1|gen2|gen3}() differing only in the PCIe > PHY init code and all ending with a call to rcar_pcie_hw_init(), thus it > makes sense to move that call into the driver's probe() method and then > rename those functions to rcar_pcie_phy_init_{h1|gen2|gen3}() -- doing > this saves 48 bytes of object code (AArch64 gcc 4.8.5)... > > Signed-off-by: Sergei Shtylyov Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds