From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B4133C17 for ; Sun, 19 Oct 2025 06:00:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760853641; cv=none; b=LkIGNTGKEQ3u4FWXsENI9LPU8GWEysbP5pWLH0kWj3kqax/4v5DOTSjkhZMN5+yITa7orMwg+CBre/YNmWMo0f2qA7TAnU58v2VZISDSiNnMjTY345yLn6gVpv3yN8Ml4T3RpKh/n4JTF3O0e+yUYZE9KK8Lw371cW/ILOQhsAM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760853641; c=relaxed/simple; bh=+FmVBSQvGYziWTCd8nap5gWQD+747UUq/SV2tX+pf9o=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=X6hCqTa+4QvT/JkYT9472N854DdOCCTt1iCOA8Wj2q79pBZIS6N7Kzt7vl16hi8J+JNz9AWyDhl/+pprEWU/UySBMkJoosjb1fOxrKfMszgl9pBOdvbfSpMtqpkte0t0Bh/bgQQun0mZ/KLAdqkyWFCVTHPByG0NPLNvVsP4yJ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kyx8jvE7; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kyx8jvE7" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-b40f11a1027so628514366b.2 for ; Sat, 18 Oct 2025 23:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760853638; x=1761458438; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=RDRUSkhiE/XFv7OW4RSw91eps1PHNhul5pJctkyAuh0=; b=kyx8jvE7CcO5RDTXwF1VKzxZpj89umkgHdcyS5IgRPRQj7UFOv+tB/Yo73VBvPzRkL n8ya5dhgFmIhttynbU1uYG57WZYlzFgb9Q0WPmDl+zlkX4oN1GxnF/q3J13mFvfEYYfv z1RU4EQODW5V5DholblzezLonqs8GwsFOz8wpbwvtkfQ+klQ45LI7OUcCwLDP4uzFMFW JV3Dvo/ScYIHsdoffpYobiUbWXAD3Yu2uYtyibE/mQB4dxSb7PRddKLfuKmBWcJ23GxI ooeOQ9p3Qobmz5Zjml3mTcWj4GCVy/Q/NV2HMT//XF64tAQdSivifSTtJ4WXCAHCWTkZ fYXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760853638; x=1761458438; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RDRUSkhiE/XFv7OW4RSw91eps1PHNhul5pJctkyAuh0=; b=sfnoNItidY8c8FQgmOQV6BPHLVyK/3CXKFttlHMil4HVe7XVorofTAFLFA2pALZIvg DWONTQbyrhokPsZf6uUEeEvnuQQtvjac3qR1sXW8CUdeRWXMth9rdLjh0MTAZ8JK/yUj I55J7/UKJoNunfKUveTYvQeVuRsEsWYk9ztgvVScWuRXWOk+BATIxqa/sAyQuSkJlit0 gDohm36z7cteDZp5FxrerDPL62E9HzsmSms2ZFfcNlZT3MmzxowszcY5xK22nT6Yoz7n xg3FSfY5eOabBcfGM2+N/XFzVE7rFUneqIYBM7/R/30YI9/BgtBWeASaQ87BgP94N8nT FNnw== X-Forwarded-Encrypted: i=1; AJvYcCWgq6GK+mkpvx65o3pCNn3XDl2RQZC2M5oeXo61gwuVL/Q3oTPhmP/ILUFV3YLxnmsJSIwLUAonXSY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywpegt9nwxnRkVlJ5IEHBM4eQN/Gfr0lwCGac2xFr/pVldnJq1j rp2Ud6GzgUJ6Vwuqx1C+gkkrH8I0cXsqMenNH6Fdg8EoMJ+c5KJkgyCwdDRIj5V3mrVaC1hj7Oy Hd/zf0cuPvy7VqDjDsFDQ3wztwX5eWDbbyQ== X-Gm-Gg: ASbGncsaidqdLsB3Xk1insHyetz7OOQyjHYv1YA3WTtP/m6k98vTlKBx+czJk3PXFkB GfEPzXmrgT8IYeEBIRk6V15RivcBGKOXkkp67MFRVUZ2hlldPMQUunJWsrCJk5CyC9N61P5XcSI 9vQwFBNBxZD8KHp4j+PkvFZAZz4Z/KNFdukUOKXOEBEolY8CT8SXEy6kposs1HJw40i07CuuRBc SjLTM81f/pIyACj3W1UqrZT/no1s2pR5F1xrIYjlrrhp1HCAYlb0DpTCMmDZqqIRvCJjA== X-Google-Smtp-Source: AGHT+IFouXM66dWGoME6chpnuaQA5AhGJ3XBtWEQPmJjkQDMbd8DEH4sRrB+vsmFy93A7mrCfiSnE5e4aC5FUlXjYmc= X-Received: by 2002:a17:907:7b8c:b0:b04:b446:355 with SMTP id a640c23a62f3a-b6475706d77mr890751766b.59.1760853637425; Sat, 18 Oct 2025 23:00:37 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251014113234.44418-1-linux.amoon@gmail.com> <20251014113234.44418-2-linux.amoon@gmail.com> In-Reply-To: From: Anand Moon Date: Sun, 19 Oct 2025 11:30:22 +0530 X-Gm-Features: AS18NWDuyNsNiWxQmtkRHjc2M2PlmVH_Wd0KhK-4VAGV-r5GP86AOOEs_7Ea5Qw Message-ID: Subject: Re: [PATCH v1 1/3] PCI: j721e: Propagate dev_err_probe return value To: Dan Carpenter Cc: Vignesh Raghavendra , Siddharth Vadapalli , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , "open list:PCI DRIVER FOR TI DRA7XX/J721E" , "open list:PCI DRIVER FOR TI DRA7XX/J721E" , "moderated list:PCI DRIVER FOR TI DRA7XX/J721E" , open list Content-Type: text/plain; charset="UTF-8" Hi Dan On Sat, 18 Oct 2025 at 15:18, Dan Carpenter wrote: > > On Tue, Oct 14, 2025 at 05:02:27PM +0530, Anand Moon wrote: > > Ensure that the return value from dev_err_probe() is consistently assigned > > back to ret in all error paths within j721e_pcie_probe(). This ensures > > the original error code are propagation for debugging. > > > > Cc: Siddharth Vadapalli > > Signed-off-by: Anand Moon > > --- > > v1: new patch in this series > > --- > > drivers/pci/controller/cadence/pci-j721e.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c > > index 5bc5ab20aa6d..9c7bfa77a66e 100644 > > --- a/drivers/pci/controller/cadence/pci-j721e.c > > +++ b/drivers/pci/controller/cadence/pci-j721e.c > > @@ -569,20 +569,20 @@ static int j721e_pcie_probe(struct platform_device *pdev) > > pm_runtime_enable(dev); > > ret = pm_runtime_get_sync(dev); > > if (ret < 0) { > > - dev_err_probe(dev, ret, "pm_runtime_get_sync failed\n"); > > + ret = dev_err_probe(dev, ret, "pm_runtime_get_sync failed\n"); > > goto err_get_sync; > > Wait, no, this doesn't make sense. It's just assigning ret to itself. > That's just confusing and pointless. > Ok, Thanks for clarifying. > regards, > dan carpenter > Thanks -Anand