From: Emmanuel Grumbach <egrumbach@gmail.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-pci@vger.kernel.org,
linux-wireless <linux-wireless@vger.kernel.org>,
John Linville <linville@tuxdriver.com>
Subject: Re: is L1 really disabled in iwlwifi
Date: Mon, 4 Mar 2013 19:58:57 +0200 [thread overview]
Message-ID: <CANUX_P22AkqeOROP1QHzp20wGWgDbRzy+9FZy2KvHLXCQ5AVnA@mail.gmail.com> (raw)
In-Reply-To: <20130304154832.GD3021@redhat.com>
On Mon, Mar 4, 2013 at 5:48 PM, Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> On Mon, Mar 04, 2013 at 04:57:46PM +0200, Emmanuel Grumbach wrote:
>
>> This is what I did. On 3.7, lspci tells me that ASPM is enabled before
>> I load the module. And same after I load the module.
>
> CONFIG_PCIEASPM disabled ?
>
nope - enabled on both kernel: 3.1 and 3.7. Makes sense though.
CONFIG_PCIEASPM enabled, I have L1. Just wondering why doesn't that
pci_disable_link_state do anything....
Also, I remember so issues Mathew Garret debugged and he ended up
disabling ASPM on older kernel because some BIOS issue (don't remember
really). Apparently, ASPM is enabled again in newer kernels.
Anyway - I think I will just remove this pci_disable_link_state call
and hopefully, it will stay long enough in linux-next so that people
will report issues before it get into linux.
I don't like leaving that code if it doesn't do anything.
next prev parent reply other threads:[~2013-03-04 17:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 8:41 is L1 really disabled in iwlwifi Emmanuel Grumbach
2013-03-04 13:44 ` John W. Linville
2013-03-04 13:49 ` Stanislaw Gruszka
2013-03-04 14:57 ` Emmanuel Grumbach
2013-03-04 15:11 ` John W. Linville
2013-03-04 15:48 ` Stanislaw Gruszka
2013-03-04 17:58 ` Emmanuel Grumbach [this message]
2013-03-17 15:59 ` Roman Yepishev
2013-03-29 18:24 ` Bjorn Helgaas
2013-03-30 18:38 ` Emmanuel Grumbach
2013-03-30 21:26 ` Bjorn Helgaas
[not found] ` <CANUX_P2Hy02SnyYS24dyUGLv3wB3L5xkXt8Y1s+8_RG9d5ReAw@mail.gmail.com>
2013-04-02 11:12 ` Emmanuel Grumbach
2013-04-07 12:23 ` Emmanuel Grumbach
2013-04-08 16:28 ` Bjorn Helgaas
[not found] ` <CANUX_P0hpx8NNvX6cJXfOZMNYN8hrEF-gzf9hBN2Uz=k0WiwgA@mail.gmail.com>
2013-04-30 10:57 ` Emmanuel Grumbach
2013-04-30 22:45 ` Bjorn Helgaas
2013-04-30 22:55 ` Matthew Garrett
2013-05-01 8:31 ` Emmanuel Grumbach
2013-05-01 17:13 ` Bjorn Helgaas
2013-05-10 22:52 ` Bjorn Helgaas
2013-05-11 20:26 ` Rafael J. Wysocki
2013-05-11 20:22 ` Matthew Garrett
2013-05-16 22:55 ` Bjorn Helgaas
2013-05-17 5:49 ` Emmanuel Grumbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANUX_P22AkqeOROP1QHzp20wGWgDbRzy+9FZy2KvHLXCQ5AVnA@mail.gmail.com \
--to=egrumbach@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).