* [RFC v2] PCI: keystone: Fix definition of LTSSM_STATE_MASK
@ 2015-10-05 10:53 Fabio Estevam
2015-10-15 16:23 ` Murali Karicheri
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2015-10-05 10:53 UTC (permalink / raw)
To: bhelgaas; +Cc: m-karicheri2, linux-pci, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
Designware PCI block uses 0x3f for the LTSSM_STATE_MASK.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- Fix Subject
Murali,
I am doing some consolidation on the PCI DW drivers and I noticed that
keystone uses a different LTSSM_STATE_MASK definition.
Could you please double check it?
drivers/pci/host/pci-keystone-dw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/pci-keystone-dw.c b/drivers/pci/host/pci-keystone-dw.c
index 3cf55cd..78320e4 100644
--- a/drivers/pci/host/pci-keystone-dw.c
+++ b/drivers/pci/host/pci-keystone-dw.c
@@ -25,7 +25,7 @@
/* Application register defines */
#define LTSSM_EN_VAL 1
-#define LTSSM_STATE_MASK 0x1f
+#define LTSSM_STATE_MASK 0x3f
#define LTSSM_STATE_L0 0x11
#define DBI_CS2_EN_VAL 0x20
#define OB_XLAT_EN_VAL 2
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC v2] PCI: keystone: Fix definition of LTSSM_STATE_MASK
2015-10-05 10:53 [RFC v2] PCI: keystone: Fix definition of LTSSM_STATE_MASK Fabio Estevam
@ 2015-10-15 16:23 ` Murali Karicheri
2015-10-15 17:16 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Murali Karicheri @ 2015-10-15 16:23 UTC (permalink / raw)
To: Fabio Estevam, bhelgaas; +Cc: linux-pci, Fabio Estevam
On 10/05/2015 06:53 AM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Designware PCI block uses 0x3f for the LTSSM_STATE_MASK.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Fix Subject
>
> Murali,
>
> I am doing some consolidation on the PCI DW drivers and I noticed that
> keystone uses a different LTSSM_STATE_MASK definition.
>
> Could you please double check it?
>
> drivers/pci/host/pci-keystone-dw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-keystone-dw.c b/drivers/pci/host/pci-keystone-dw.c
> index 3cf55cd..78320e4 100644
> --- a/drivers/pci/host/pci-keystone-dw.c
> +++ b/drivers/pci/host/pci-keystone-dw.c
> @@ -25,7 +25,7 @@
>
> /* Application register defines */
> #define LTSSM_EN_VAL 1
> -#define LTSSM_STATE_MASK 0x1f
> +#define LTSSM_STATE_MASK 0x3f
NACK
The mask should be 0x1f as was originally as per document
4-0 LTSSM_STATE
LTSSM current state. Please see Appendix
A.1 for the names of the LTSSM states corresponding to
the encoded values.
refer the document at http://www.ti.com/lit/ug/sprugs6d/sprugs6d.pdf
Murali
> #define LTSSM_STATE_L0 0x11
> #define DBI_CS2_EN_VAL 0x20
> #define OB_XLAT_EN_VAL 2
>
--
Murali Karicheri
Linux Kernel, Keystone
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC v2] PCI: keystone: Fix definition of LTSSM_STATE_MASK
2015-10-15 16:23 ` Murali Karicheri
@ 2015-10-15 17:16 ` Fabio Estevam
0 siblings, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2015-10-15 17:16 UTC (permalink / raw)
To: Murali Karicheri; +Cc: Bjorn Helgaas, linux-pci@vger.kernel.org, Fabio Estevam
On Thu, Oct 15, 2015 at 1:23 PM, Murali Karicheri <m-karicheri2@ti.com> wrote:
> NACK
>
> The mask should be 0x1f as was originally as per document
>
>
> 4-0 LTSSM_STATE LTSSM current state. Please see
> Appendix
> A.1 for the names of the LTSSM states corresponding to
> the encoded values.
>
> refer the document at http://www.ti.com/lit/ug/sprugs6d/sprugs6d.pdf
Yes, in the last version of the patch I use the 0x1f mask for all
Designware PCI drivers.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-15 17:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-05 10:53 [RFC v2] PCI: keystone: Fix definition of LTSSM_STATE_MASK Fabio Estevam
2015-10-15 16:23 ` Murali Karicheri
2015-10-15 17:16 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).