From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f43.google.com (mail-yx1-f43.google.com [74.125.224.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B709832E73D for ; Tue, 21 Oct 2025 10:37:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761043051; cv=none; b=CVX9ihWsCKPlPABjIYWXXpjDBm7R0XkOmbZ60YU5AFI++qDyqRfzOSN++nwgtYgJrVVRUglayjahH/H5YLDJHIKfR39TfRjFhZyCssTmFjjL89vjp26cXV0g3bBFJ73yllDK/td2744pgJZG9rOFMS38UHTBu91fhhBDJf8m7tg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761043051; c=relaxed/simple; bh=G8bIrdKOREeaQWFYl+BVblIyK/tNvhnzk9i8+sGZ5Dk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=VxqdyTLhD9aY9XK0Hvmp0slieMFxaxHrdIDiEsUEMBeF3z4PE25xnGhEZl0RbAjl9Mk//9eqWjL964ZuyB02l1VjGTkAGouC+H4e8yKEUjU+piHCbCLnKkZ6Mj6e+2ztu5doKUDpc2XO4aN0aVU42DZuNP4PLCUZC/WYDb3UPQg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OV4FJNFQ; arc=none smtp.client-ip=74.125.224.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OV4FJNFQ" Received: by mail-yx1-f43.google.com with SMTP id 956f58d0204a3-633c1b740c5so5218814d50.3 for ; Tue, 21 Oct 2025 03:37:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761043046; x=1761647846; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=du/uiA2g0ruAK2UrT7r+xEuTy7bML0SpAVcY8ooVq04=; b=OV4FJNFQ1uapnGqxwNArp1c3sMnou9Gn5Mulg7FgaRBpu3ejO833yxc66+0QPR5qku aA6EtTV2yORIXSU8/KOKiCgkLr08ed7m+oB3VG68OcVm4IkfQWuf0NSFnvDvBvHYEmGO s7eoCUGrMzgib3JPXWKNfiFjGSXvsakVOwKCpyf53cvuthskb+tI6l295G2g2M067qv0 G6+Xk1iy4eqtknYhBYxWVNcWvuKiCEb1jHN6XCahAmWGOYfMn+CWYLTXienvZkfJa3Lm e+zGW8er2mG1JDxIljGhsR0OOWqP1w+F6NtkkmNhuPT00c+L0r+NcJ0Wx1GHFOjnhc7B L2yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761043046; x=1761647846; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=du/uiA2g0ruAK2UrT7r+xEuTy7bML0SpAVcY8ooVq04=; b=kHA+yNSJglsOScKMtpppGtvTBOmv7lqIhktqT3C0fDHYPlP1omQSa+Fb8wNBaVZ8OC kefd4Yh+cvJ+m51iB1YLDPxETI1oAI58hWZVr7pieTJRXUcCpzJY73N6TRAhdHcWHnJm IciFgHZHiLctNPXMLRNA4/Q3PgMNqCz3SHl1MdALX04lTj0d9XimnHbcAG2u5BY4Z6aT psFL0h0EejsTL3ginhBkIRUvKlu1uwxbri3InzxVYjKZ7GyhlpGKTeyiVZ1X9olJMBxV PgVVpeuB4IgN/JNBkeSKaAXDHHkz8VkRH7aiYqhOEuUSAkqFPbm1+//gUqv1aSfy+VsP PgvQ== X-Forwarded-Encrypted: i=1; AJvYcCUmh3aJMfJJ2fHD1FPvPhpMGxZ+LZq88GzgvkFSWyLB7/Or/JZ6WYBgbNJRvj4gTJSgiISQU/e1dK4=@vger.kernel.org X-Gm-Message-State: AOJu0YxNga1fukLIUyrY10EC5fPR+Yj0YAK6OhY8uoMl1AlMOUCuDdUR i7/e0cqe+JEhaJxlYmlj0zvB0C3bh4tl374O3a93xLAc2Zyh9Sf0GHetPXcRfpqw9KbVNehpuLA v1Ug2k+KSFkAWZgdDJoBQxajgzhTGzUUMxLO+d7WUpA== X-Gm-Gg: ASbGnctqAlV90m8/sJ4VZOpn7bW66yWzLrnnkU21F2e+xRYgTHNXNuhYwrlotlE/sVf K0yEPlTd8gIalahPl6VvgCFUZVpt6bFfIOyWs9Ap29xAqlsjTpPZ4y09zMhhzK8unRSpVp5IA9j buBrTe3zNep7cgyfRLgL/QfXLdm7chGsmArtpwGV3BKOeKO6akFhf+QVQOqFhkrSQwBRRivmpbK C8V2bVJ1Ih4C+OhYqHCnsxZ8uNmRg13mEYqXeXcD12CbOZQkhd4f9kNcBCB0w== X-Google-Smtp-Source: AGHT+IFFOhRKu4kQW/XKD1Pm8VUPug9hRZQumhyHTlK9vebZPyquvLC0TgCPXJX5yR8+F8jVszRXlOsVXxUxv7obTms= X-Received: by 2002:a05:690e:4090:b0:63e:3e77:a7c4 with SMTP id 956f58d0204a3-63e3e77a7fdmr3660188d50.1.1761043045615; Tue, 21 Oct 2025 03:37:25 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251015071420.1173068-1-herve.codina@bootlin.com> <20251015071420.1173068-10-herve.codina@bootlin.com> In-Reply-To: <20251015071420.1173068-10-herve.codina@bootlin.com> From: Ulf Hansson Date: Tue, 21 Oct 2025 12:36:49 +0200 X-Gm-Features: AS18NWAi-o77CPd71JT42D3mLl8vqFN7eYPAV53oOUDllJc5eKGrXIzOLUEhLMM Message-ID: Subject: Re: [PATCH v4 09/29] drivers: core: Use fw_devlink_set_device() To: Herve Codina Cc: Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Michael Turquette , Stephen Boyd , Andi Shyti , Wolfram Sang , Peter Rosin , Arnd Bergmann , Saravana Kannan , Bjorn Helgaas , Charles Keepax , Richard Fitzgerald , David Rhodes , Linus Walleij , Mark Brown , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Len Brown , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Geert Uytterhoeven , Wolfram Sang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, linux-spi@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, Allan Nielsen , Horatiu Vultur , Steen Hegelund , Luca Ceresoli , Thomas Petazzoni Content-Type: text/plain; charset="UTF-8" On Wed, 15 Oct 2025 at 09:18, Herve Codina wrote: > > The code set directly fwnode->dev field. > > Use the dedicated fw_devlink_set_device() helper to perform this > operation. > > Signed-off-by: Herve Codina > Reviewed-by: Andy Shevchenko Reviewed-by: Ulf Hansson Kind regards Uffe > --- > drivers/base/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/base/core.c b/drivers/base/core.c > index 3e81b1914ce5..9da630d75d17 100644 > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -3739,7 +3739,7 @@ int device_add(struct device *dev) > * device and the driver sync_state callback is called for this device. > */ > if (dev->fwnode && !dev->fwnode->dev) { > - dev->fwnode->dev = dev; > + fw_devlink_set_device(dev->fwnode, dev); > fw_devlink_link_device(dev); > } > > @@ -3899,7 +3899,7 @@ void device_del(struct device *dev) > device_unlock(dev); > > if (dev->fwnode && dev->fwnode->dev == dev) > - dev->fwnode->dev = NULL; > + fw_devlink_set_device(dev->fwnode, NULL); > > /* Notify clients of device removal. This call must come > * before dpm_sysfs_remove(). > -- > 2.51.0 >