From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4E77C433F5 for ; Thu, 30 Sep 2021 15:28:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9835E61A2C for ; Thu, 30 Sep 2021 15:28:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245036AbhI3Paa (ORCPT ); Thu, 30 Sep 2021 11:30:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244867AbhI3Pa3 (ORCPT ); Thu, 30 Sep 2021 11:30:29 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EBD0C06176A for ; Thu, 30 Sep 2021 08:28:47 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id t4so4309631plo.0 for ; Thu, 30 Sep 2021 08:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Jx2U1fXVMAX8YVJnygiZPmNCKOQJD2Hj7BS/kMAYEgs=; b=agBAaxvELaCg38+3MxkDJ5W3WTSUor6hjrK6UKjt7TpCZZuOPc7FM6IKQBxSyoc52K ilxpSY9wGu5Gckh+Y8wN93EqxSZzaoJx/7UfSc/o94BA/avp/+GptpxHQJdaTadAAjUO dApT93yF6zsQdX+lxSSJHyhabVLKYswM5ji7mIpRt06U+F8zgITyyWPHLuyJeCwWWRGN Y15ffW0I+FZnbmTTtme+SdoYeyiWGTduhyGuvTThXHcvhLrxiSGC2HEm/q23MDFOHhgq oCJmcf19GZOambHRb3p397D+7b6T+d8k74DqQhG9jcverKvnrcGX3TISXhAdq6YTGeUa BG6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Jx2U1fXVMAX8YVJnygiZPmNCKOQJD2Hj7BS/kMAYEgs=; b=vNMalsbivuT0vrB9HHNNYpV8LjdOItrnrTYyfrnzHOW/cWF1ESbt534CuGcWxscUX6 1TyxKKOvplvVqfuZ9GGUaw3PW8U9MnI6n+LE392a6R+a0GRdaDfLBV2txeDo3EMZhYtk V3pO+lowNOpDYax8zIEn6CmJP1CdBOrTiP92Vp+3qiFTJm9Sa8aQN7R2n9c5F+924Kmn 3xjcGCKdkVgp6BP2hf7M7VdQRofCgYzB1YZBBZS+TTGOsxVrH1fIprOPFj8eGc/ggaaD AAzOC4UNqtkAEbY7X606bUT6Qhepz9wcWcengyDWjUMGK5weAmKx7FhZKWAuSBmhzAHR z15w== X-Gm-Message-State: AOAM531Hh6TCi+xhYYtcgMqBk855t/ktPozwNfOiqd4IkoK2wpNysfbR tOEClSWKZpvir3Mgd3yW3UqiBmlgQaCHUsInmPvBNQ== X-Google-Smtp-Source: ABdhPJy+Q5gdj1FvBjL6jYwPI7vYzDx17vSL3eDwmyx/hbSgqCzUcrj89W/AlsE7w1znCFVh/khI/9h4dUStCMaYHDk= X-Received: by 2002:a17:90a:d686:: with SMTP id x6mr13753493pju.8.1633015726357; Thu, 30 Sep 2021 08:28:46 -0700 (PDT) MIME-Version: 1.0 References: <20210930010511.3387967-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20210930010511.3387967-2-sathyanarayanan.kuppuswamy@linux.intel.com> In-Reply-To: From: Dan Williams Date: Thu, 30 Sep 2021 08:28:36 -0700 Message-ID: Subject: Re: [PATCH v2 1/6] driver core: Move the "authorized" attribute from USB/Thunderbolt to core To: Yehezkel Bernat Cc: Kuppuswamy Sathyanarayanan , Greg Kroah-Hartman , Borislav Petkov , X86 ML , Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Andreas Noever , "Michael S . Tsirkin" , Michael Jamet , "Rafael J . Wysocki" , Mika Westerberg , Jonathan Corbet , Jason Wang , Andi Kleen , Kuppuswamy Sathyanarayanan , LKML , Linux PCI , USB list , virtualization@lists.linux-foundation.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Sep 30, 2021 at 4:20 AM Yehezkel Bernat wrote: > > On Thu, Sep 30, 2021 at 4:05 AM Kuppuswamy Sathyanarayanan > wrote: > > > > no functional > > changes other than value 2 being not visible to the user. > > > > Are we sure we don't break any user-facing tool with it? Tools might use this to > "remember" how the device was authorized this time. That's why it was highlighted in the changelog. Hopefully a Thunderbolt developer can confirm if it is a non-issue. Documentation/ABI/testing/sysfs-bus-thunderbolt does not seem to answer this question about whether authorized_show and authorized_store need to be symmetric.