From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04FD0C433EF for ; Tue, 28 Sep 2021 17:41:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD18E6127C for ; Tue, 28 Sep 2021 17:41:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229863AbhI1RnR (ORCPT ); Tue, 28 Sep 2021 13:43:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242079AbhI1RnR (ORCPT ); Tue, 28 Sep 2021 13:43:17 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80841C061745 for ; Tue, 28 Sep 2021 10:41:37 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id m21so21933815pgu.13 for ; Tue, 28 Sep 2021 10:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WkidfBLNDflGiXs0oP3mDBZ5il/79hD91IY+k5Xsxuc=; b=bA7yAxAI4PivPTDL2tmtUWSug8cFLm+Lp/M/J8tWpOX7VThwyhD1uHRnHWyn1gypjz /XzmjC9sfErVDuGFsyJvSSHvvhu9nQ7Kso3E+RGxpZnlV1rpwx4LYj/P5l6Z38Y/UEfp dNeWL6kK9unlsA8wG5GEhkIZ+4tvRDOMk+TJy7HzL9rdoix0FJNsfZcPFnfoMkxbst93 a/G0KXVU8o79EfFIKtiBKh5+QiY7b/PJds1zfTAHCkczgYa7RB5dkQrraBWKo6v3QHEl TcfvQ5mM+1T1aqcT9TKMJNtVWXVgUrfew9Eem3OwSym9y2/TAeOib1Yk9gpHI3xIahD9 clDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WkidfBLNDflGiXs0oP3mDBZ5il/79hD91IY+k5Xsxuc=; b=Vi7gO9jyNwxHeWWV3V7YZ+nPSXQaEB7c9tQ8cMVBx1VwJLUlRO59OEsiTKK0k7kGN1 w69ATnwfWHPNQ77UV5qW3Yf3yMR7GvZf48dtcjDSchgqWR8XBa/urGnQP8rkplfbRhLc 7BXHu8josnbxyNE2IO9C8I/IO4wxUZGYLsM2vQFWZhi3TiVF9oXOOS+QnksfPTr+bb5Y txQENzEVyTsEuyLyJgISOU4nROYw3FZq0EOrtb2AVdZ5pA/cHj2QMJ41sAPrA/Gxh9Kf RoKC9xBnOMaKZoRYweZaVhG9veGUql/R0tMaKi2lhwlZm2SQiVoS0ZPmbEXR1/KhW7P1 E9Wg== X-Gm-Message-State: AOAM533w56UbLhlSk3/dnCvqOdzUZheQbA4pkaYiewy0S374IGJoCeK2 7yHLvjmROpd7gTFQoKKav0TSPy2hiWbgOP4/wVL4lw== X-Google-Smtp-Source: ABdhPJxE685ihjSuTSw0+w9d2q6ixqqWA3MsNeG+SfMab1LeeuIrmS8uWL0F1Ylm1UNzWyahPTQwxwoyCoYk+d5LLKY= X-Received: by 2002:a63:1e0e:: with SMTP id e14mr5684055pge.5.1632850896968; Tue, 28 Sep 2021 10:41:36 -0700 (PDT) MIME-Version: 1.0 References: <20210923172647.72738-1-ben.widawsky@intel.com> <20210923172647.72738-6-ben.widawsky@intel.com> In-Reply-To: <20210923172647.72738-6-ben.widawsky@intel.com> From: Dan Williams Date: Tue, 28 Sep 2021 10:41:24 -0700 Message-ID: Subject: Re: [PATCH v2 5/9] cxl/pci: Make more use of cxl_register_map To: Ben Widawsky Cc: linux-cxl@vger.kernel.org, Andrew Donnellan , Bjorn Helgaas , "David E. Box" , David Woodhouse , Frederic Barrat , Kan Liang , Lu Baolu , "open list:DMA MAPPING HELPERS" , Linux PCI , linuxppc-dev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Sep 23, 2021 at 10:27 AM Ben Widawsky wrote: > > The structure exists to pass around information about register mapping. > Using it more extensively cleans up many existing functions. I would have liked to have seen "add @base to cxl_register_map" and "use @map for @bar and @offset arguments" somewhere in this changelog to set expectations for what changes are included. That would have also highlighted that adding a @base to cxl_register_map deserves its own patch vs the conversion of @bar and @offset to instead use @map->bar and @map->offset. Can you resend with that split and those mentions?