From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79E2BC433EF for ; Wed, 9 Feb 2022 19:57:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229949AbiBIT5t (ORCPT ); Wed, 9 Feb 2022 14:57:49 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:44150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229820AbiBIT5s (ORCPT ); Wed, 9 Feb 2022 14:57:48 -0500 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F3B1E067869 for ; Wed, 9 Feb 2022 11:57:50 -0800 (PST) Received: by mail-pl1-x635.google.com with SMTP id w20so3137134plq.12 for ; Wed, 09 Feb 2022 11:57:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hLa+EiH1mRG9f1fQTD6dnIZH6dFitXQQk4vxZMPiC5c=; b=KX8AdbYmDS6spCCkdzMJ7tZJv5GtJ1yMkJcpmSpW1TfCRtSAnNQtHSMa4mPauEi/Cd +MLAjE0FY3+SJWZvR4HwSBSax5Hqg4pXKqJ/idqJG8nDynA1AsxQJpTKolXkM86ZpzU7 ki/MDoBo1aeE5Odl8CYDrDcAO19oeCWrrOmQxrbIcqw7Fdcqtmv81Eax8I1LRRfHCsgY x2VvrtSCBcpwbVqKkOdPql2XNRQjEUyX1omLLffMH6H6QhQhX1Ck3H52H1nan8+jCpNh vf2/wuHA4n9yW+x/PpSvpKtY1P3Ub3+fzkAzDOgV78LZvHrBDurXd+d4HTq3jzSBhucc WgbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hLa+EiH1mRG9f1fQTD6dnIZH6dFitXQQk4vxZMPiC5c=; b=4TDciejzjVN/ZkRbOIk0T5iKspJTPJ3k2fk3R9U6USPskkwLKc0w5I7yp4ryfCupvo HqFFWLz43cOJFqjD/mIu1PSAJaZPn+oBm4sIFFKVGizPFZC7zeK+hEGKvZH2GKRHm+Sx 06f/ZM7O6APJr5I4pzj2Y3knoLCxJ7A8+37vXtDp53PnqlAz62RIvQrnb7qrnuhfLmxx myhIfIW+FuXhBax9JUB5jRfW6MOyzRtmxC8ap4SBv6HhT9bH4UE6tUl36lI3v6nQ8AKP 3KX3Bb9wl1/AMHRW++wjbq/NHtABa3jUsOyH877pNP5j0rxoAGnOSjOD3X++v0z74gKM XvIA== X-Gm-Message-State: AOAM532lOlONuEvmUKMfyHcInj5xtlWcyxJgwxrpGNP4E/EyjUroopgZ XQZlFrxC1m30JNH1rByyB1KVfVIyrvr7JgXWVikh3g== X-Google-Smtp-Source: ABdhPJy1CZ+jtneOWBZEOWg3IGJXU0RLO7anSCnJ9xepD6AnWwHom3tpnlP5xqHgKfePw1ryjZF96fweobvsuAxF1rA= X-Received: by 2002:a17:902:bcca:: with SMTP id o10mr3830543pls.147.1644436669601; Wed, 09 Feb 2022 11:57:49 -0800 (PST) MIME-Version: 1.0 References: <20220201071952.900068-1-ira.weiny@intel.com> <20220201071952.900068-4-ira.weiny@intel.com> <20220209101320.00000473@Huawei.com> <20220209165756.00002841@huawei.com> In-Reply-To: <20220209165756.00002841@huawei.com> From: Dan Williams Date: Wed, 9 Feb 2022 11:57:38 -0800 Message-ID: Subject: Re: [PATCH V6 03/10] PCI/DOE: Add Data Object Exchange Aux Driver To: Jonathan Cameron Cc: "Weiny, Ira" , Bjorn Helgaas , Alison Schofield , Vishal Verma , Ben Widawsky , Linux Kernel Mailing List , linux-cxl@vger.kernel.org, Linux PCI Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Feb 9, 2022 at 8:58 AM Jonathan Cameron wrote: [..] > > It just seems an unnecessary hunk of code for the core to carry when > > it's trivial for a client of the core to do: > > > > task->private = &completion; > > task->end_task = complete_completion; > > submit_task() > > wait_for_completion(&completion); > > OK, we can move this to the callers though function obviously will > also need renaming - I guess to pci_doe_exchange() and now need to take a > task rather than the exchange. > > I personally slightly prefer the layered approach, but don't care that > strongly. Like I said, you and Ira are holding the pen, so if you decide to keep the layering, just document the ontology somewhere and I'll let it go.