From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CB19C433B4 for ; Wed, 19 May 2021 20:01:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2AC2961355 for ; Wed, 19 May 2021 20:01:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232476AbhESUCc (ORCPT ); Wed, 19 May 2021 16:02:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230431AbhESUCc (ORCPT ); Wed, 19 May 2021 16:02:32 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7E47C061760 for ; Wed, 19 May 2021 13:01:11 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id i13so16725957edb.9 for ; Wed, 19 May 2021 13:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OlxoSwTyBGcIB+AvV2WfDn1g1Sf/3pWsJB/YRZB8SB8=; b=1dh0Q+cxVbEWRDmbm9CbH3FmdqIYJe8AQBGdaFSXXRTRAU50YTKYucb5bSElHQPTK1 Lv7Cc8hcGY8Leks6KtL54P+GEsSL7ZzHs9Ys03+8y7Uo6LGzaBH5et1EMJpA6MqboF7d dzbjjXf0OOlXr3SgohVT+LZCuju7dgik6T+NVkiwR70FiBTjiTMyz6gW86PcTkuD2EIM SUYq4mZmDjcOp/FALakgTnus6G9wyiTUGTq7mi1Hq+k1Z6akiGnqyz6b58BCCLoRnfRV qsfACgNRDDs2QVQDf+3Tj3FfouX4mQcV45NPfvFPUl3SuhuIeA92MXc+/xVPADipFOwb W8og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OlxoSwTyBGcIB+AvV2WfDn1g1Sf/3pWsJB/YRZB8SB8=; b=tCuCI2O2oFB+Yf1rPT8cPxnXY9X80a9SoJf9fxyi2HbyL4hGz3ICXcak+nr8paqyqz 7eD1l3HAeVZgMo5UNKiURgWMlZvZU7yamTGpD/A/CZ+1kyvqdRBipvzFaw5BGjmWm1xL RBpglEdhL3ok+86F7jaxKHdQoojFEVt86u+530yPoIqunL7LDz+t+jaoP1B6+GSqMxl/ v0OFsNvK+CvYj/k29MKIH+WUMpmlRpeIrwO3AcO/t64fg3k3hzPbEeJfjes9kggBi2pJ DbVXdhnBICgDEnJ5/e1SqgKNhrcCVWTnRcnIPoH6GPMyNjrs3ECAyAmzSuHPFc5y2HZn 2H8A== X-Gm-Message-State: AOAM533VamVjA83DjsUmYsGi1jbJDkHG67yYd4hPdMmFSAeuMyUWpaDo kCZLB1rx2KnSEIy5GICQYd+7FUnbCyF9Gs3MG0oSgg== X-Google-Smtp-Source: ABdhPJwBYagjUpaXpLq5SIcAJYpu2toyEqzEY8kfw4+9XLQVZ7jpoX+ib07aWV6cm4nAhKDYGUb4FOrk3VOFKfJnE30= X-Received: by 2002:a05:6402:128f:: with SMTP id w15mr808464edv.354.1621454470538; Wed, 19 May 2021 13:01:10 -0700 (PDT) MIME-Version: 1.0 References: <20210415232610.603273-3-ben.widawsky@intel.com> <20210415232750.604112-1-ben.widawsky@intel.com> In-Reply-To: <20210415232750.604112-1-ben.widawsky@intel.com> From: Dan Williams Date: Wed, 19 May 2021 13:01:00 -0700 Message-ID: Subject: Re: [PATCH 3/3] cxl/mem: Demarcate vendor specific capability IDs To: Ben Widawsky Cc: linux-cxl@vger.kernel.org, Linux PCI , Linux ACPI , "Weiny, Ira" , Vishal L Verma , "Schofield, Alison" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Apr 15, 2021 at 4:27 PM Ben Widawsky wrote: > > Vendor capabilities occupy 0x8000 to 0xFFFF according to CXL 2.0 spec > 8.2.8.2.1 CXL Device Capabilities. While they are not defined by the > spec, they are allowed and not "unknown". Call this detail out in the > logs to let users easily distinguish the difference. > > v2: Should be greater than or equal to (Ben) > > Fixes: 8adaf747c9f0b ("cxl/mem: Find device capabilities") > Signed-off-by: Ben Widawsky > --- > drivers/cxl/mem.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/cxl/mem.c b/drivers/cxl/mem.c > index c05617b0ba4b..28c7c29567b3 100644 > --- a/drivers/cxl/mem.c > +++ b/drivers/cxl/mem.c > @@ -939,7 +939,10 @@ static int cxl_mem_setup_regs(struct cxl_mem *cxlm) > cxlm->memdev_regs = register_block; > break; > default: > - dev_dbg(dev, "Unknown cap ID: %x (0x%x)\n", cap_id, offset); > + if (cap_id >= 0x8000) > + dev_dbg(dev, "Vendor cap ID: %x (0x%x)\n", cap_id, offset); > + else > + dev_dbg(dev, "Unknown cap ID: %x (0x%x)\n", cap_id, offset); This wants the same %#x fixup that Vishal noted on patch2 [1], and I think it would be useful to clarify that the second number is indeed an offset: "Unknown cap_id: %#x offset: %#x\n" [1]: http://lore.kernel.org/r/40063fe52fcaa066a42d352b13128b6762277542.camel@intel.com