From: Matthew Garrett <mjg59@coreos.com>
To: Josef Bacik <jbacik@fb.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
linux-pci@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
shli@fb.com, kernel-team@fb.com
Subject: Re: [PATCH] pci: completely disable aspm if it's unsupported
Date: Wed, 18 Nov 2015 11:19:02 -0800 [thread overview]
Message-ID: <CAPeXnHsdA0rDdSh020Yc7GUTQ_hQiEKdSOa1vcu1Ov=mJn4eDA@mail.gmail.com> (raw)
In-Reply-To: <564CCAC2.5050600@fb.com>
On Wed, Nov 18, 2015 at 11:00 AM, Josef Bacik <jbacik@fb.com> wrote:
> It looks to me I'm doing what Matthew set out to do, only with a bigger
> hammer ;). His patch still allowed the initialization of the ASPM stuff,
> like setting up the clocks and such, but then made it so we couldn't change
> the ASPM state at all. My patch goes the step further of not even doing the
> initialization stuff. Thanks,
That sounds fine - if we don't gain _OSC control then we should avoid
touching any of the ASPM register state that the firmware has set. I'm
happy to call the current state broken.
next prev parent reply other threads:[~2015-11-18 19:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 14:25 [PATCH] pci: completely disable aspm if it's unsupported Josef Bacik
2015-11-18 18:40 ` Bjorn Helgaas
2015-11-18 19:00 ` Josef Bacik
2015-11-18 19:19 ` Matthew Garrett [this message]
2015-12-03 16:40 ` Bjorn Helgaas
2015-12-03 22:40 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPeXnHsdA0rDdSh020Yc7GUTQ_hQiEKdSOa1vcu1Ov=mJn4eDA@mail.gmail.com' \
--to=mjg59@coreos.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=jbacik@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=shli@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).