From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-1.cisco.com ([173.37.86.72]:56962 "EHLO rcdn-iport-1.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751352AbaG1ISF convert rfc822-to-8bit (ORCPT ); Mon, 28 Jul 2014 04:18:05 -0400 From: "Suma Ramars (sramars)" To: Alexander Gordeev , "linux-kernel@vger.kernel.org" CC: Hiral Patel , "Brian Uchino (buchino)" , "linux-scsi@vger.kernel.org" , "linux-pci@vger.kernel.org" Subject: Re: [PATCH v2 RESEND 07/23] fnic: Use pci_enable_msix_exact() instead of pci_enable_msix() Date: Mon, 28 Jul 2014 08:08:28 +0000 Message-ID: References: <20140726081502.GD21129@agordeev.usersys.redhat.com> In-Reply-To: <20140726081502.GD21129@agordeev.usersys.redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org List-ID: Acked-by: "Suma Ramars (sramars)" On 26/07/14 1:45 pm, "Alexander Gordeev" wrote: >On Wed, Jul 16, 2014 at 08:05:11PM +0200, Alexander Gordeev wrote: >> As result of deprecation of MSI-X/MSI enablement functions >> pci_enable_msix() and pci_enable_msi_block() all drivers >> using these two interfaces need to be updated to use the >> new pci_enable_msi_range() or pci_enable_msi_exact() >> and pci_enable_msix_range() or pci_enable_msix_exact() >> interfaces. > >Hi Hiral, Suma, Brian, > >Could you please review this patch? > >Thanks! > >> Signed-off-by: Alexander Gordeev >> Cc: Hiral Patel >> Cc: Suma Ramars >> Cc: Brian Uchino >> Cc: linux-scsi@vger.kernel.org >> Cc: linux-pci@vger.kernel.org >> --- >> drivers/scsi/fnic/fnic_isr.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/scsi/fnic/fnic_isr.c b/drivers/scsi/fnic/fnic_isr.c >> index 7d9b54a..a0dd1b6 100644 >> --- a/drivers/scsi/fnic/fnic_isr.c >> +++ b/drivers/scsi/fnic/fnic_isr.c >> @@ -257,8 +257,8 @@ int fnic_set_intr_mode(struct fnic *fnic) >> fnic->raw_wq_count >= m && >> fnic->wq_copy_count >= o && >> fnic->cq_count >= n + m + o) { >> - if (!pci_enable_msix(fnic->pdev, fnic->msix_entry, >> - n + m + o + 1)) { >> + if (!pci_enable_msix_exact(fnic->pdev, fnic->msix_entry, >> + n + m + o + 1)) { >> fnic->rq_count = n; >> fnic->raw_wq_count = m; >> fnic->wq_copy_count = o; >> -- >> 1.7.7.6 >> > >-- >Regards, >Alexander Gordeev >agordeev@redhat.com