Linux PCI subsystem development
 help / color / mirror / Atom feed
From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Danilo Krummrich" <dakr@kernel.org>,
	<gregkh@linuxfoundation.org>, <rafael@kernel.org>,
	<bhelgaas@google.com>, <kwilczynski@kernel.org>,
	<zhiw@nvidia.com>, <cjia@nvidia.com>, <jhubbard@nvidia.com>,
	<bskeggs@nvidia.com>, <acurrid@nvidia.com>,
	<joelagnelf@nvidia.com>, <ttabi@nvidia.com>, <ojeda@kernel.org>,
	<alex.gaynor@gmail.com>, <boqun.feng@gmail.com>,
	<gary@garyguo.net>, <bjorn3_gh@protonmail.com>,
	<benno.lossin@proton.me>, <a.hindborg@kernel.org>,
	<aliceryhl@google.com>, <tmgross@umich.edu>
Cc: <linux-pci@vger.kernel.org>, <rust-for-linux@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/3] Devres optimization with bound devices
Date: Wed, 30 Apr 2025 11:46:04 +0900	[thread overview]
Message-ID: <D9JMO1USPIAB.3TBU959NO7P9M@nvidia.com> (raw)
In-Reply-To: <20250428140137.468709-1-dakr@kernel.org>

On Mon Apr 28, 2025 at 11:00 PM JST, Danilo Krummrich wrote:
> This patch series implements a direct accessor for the data stored within
> a Devres container for cases where we can prove that we own a reference
> to a Device<Bound> (i.e. a bound device) of the same device that was used
> to create the corresponding Devres container.
>
> Usually, when accessing the data stored within a Devres container, it is
> not clear whether the data has been revoked already due to the device
> being unbound and, hence, we have to try whether the access is possible
> and subsequently keep holding the RCU read lock for the duration of the
> access.
>
> However, when we can prove that we hold a reference to Device<Bound>
> matching the device the Devres container has been created with, we can
> guarantee that the device is not unbound for the duration of the
> lifetime of the Device<Bound> reference and, hence, it is not possible
> for the data within the Devres container to be revoked.
>
> Therefore, in this case, we can bypass the atomic check and the RCU read
> lock, which is a great optimization and simplification for drivers.

Thanks, this removes one of my pain points with the way revocable
resources were accessed and will allow to write drivers in a much more
natural way.

FWIW, the series

Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>

  parent reply	other threads:[~2025-04-30  2:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-28 14:00 [PATCH v2 0/3] Devres optimization with bound devices Danilo Krummrich
2025-04-28 14:00 ` [PATCH v2 1/3] rust: revocable: implement Revocable::access() Danilo Krummrich
2025-05-01 14:21   ` Miguel Ojeda
2025-04-28 14:00 ` [PATCH v2 2/3] rust: devres: implement Devres::access_with() Danilo Krummrich
2025-05-11 18:29   ` Miguel Ojeda
2025-04-28 14:00 ` [PATCH v2 3/3] samples: rust: pci: take advantage of Devres::access_with() Danilo Krummrich
2025-04-28 17:39 ` [PATCH v2 0/3] Devres optimization with bound devices Boqun Feng
2025-04-28 18:41   ` Danilo Krummrich
2025-04-30  2:46 ` Alexandre Courbot [this message]
2025-04-30 12:56   ` Joel Fernandes
2025-05-04 16:14 ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D9JMO1USPIAB.3TBU959NO7P9M@nvidia.com \
    --to=acourbot@nvidia.com \
    --cc=a.hindborg@kernel.org \
    --cc=acurrid@nvidia.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bhelgaas@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=bskeggs@nvidia.com \
    --cc=cjia@nvidia.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=jhubbard@nvidia.com \
    --cc=joelagnelf@nvidia.com \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rafael@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    --cc=ttabi@nvidia.com \
    --cc=zhiw@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox