From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6DA12E425C; Tue, 22 Jul 2025 11:21:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753183313; cv=none; b=GHShF9NJy17SZa/s8gyvSotyUbzawpnhZDMB+yGyuVnmNOZSwRRPVb+og5zpMR8TBuxEeLJMJLcFp1aEZqqLT7ZyZHd88DWIS56aHb+FUKjuZaSaoBBW1aGd6CeGXiNEmQH8bD27G+1NNlPltSjwasNEuF4OfvwdQtzO8WHicWc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753183313; c=relaxed/simple; bh=tzsVfb1kk8DsL7ewK+ArZQHuqErMnKOq7wSuG4wpvUg=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=YZ/Q9xIQClWzRjcCOc5Iq3k4A8wEfk3ZewhtCeOMmljND4ypfpdAW8Bi2DzNVXRb9DvSwN+ABPWlvGH1Ij5onxWZUb/mLhQacA3ngF3PlFifdCmRlsmoROpxUPqdb5/SlKduHtFhQ3bHOTSGqFHvuj+XYZK7idaB19vCp4aqmYg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RBVbEAzo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RBVbEAzo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3E67C4CEF4; Tue, 22 Jul 2025 11:21:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753183312; bh=tzsVfb1kk8DsL7ewK+ArZQHuqErMnKOq7wSuG4wpvUg=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=RBVbEAzobwbTYs19yr3TB8IbNsRXakQ/UM1Uev57Anq0LYTlc01u0efkcXlsBsjjF CYLht6GR6trBTJHTuw4x2xE9mHtC7J6YDBQFk9ngJChaCkDk0t5/KKtr4dVSV7O3dt tnb2Ejmgo9sED3EJ0z0pMIFJoZHCCdnmLXP62DRmX5CY9ciPrMsVY8U+pIpS+BowQx jX8rAuEjYoKUkkpo+HC0ob7SRQp9YfgdRa9JogLo6D4Zore+mNNEEiTAgDzs+xb60R IrsGal2X8piI1k5g417tUBwb6oHUBx7J9dLdqWQlASK3INbxxvFrKhveeyusbV+nTG Pccvp47GTKd2Q== Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 22 Jul 2025 13:21:47 +0200 Message-Id: Cc: "Alistair Popple" , , "Bjorn Helgaas" , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , "Miguel Ojeda" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Andreas Hindborg" , "Alice Ryhl" , "Trevor Gross" , "Greg Kroah-Hartman" , "Rafael J. Wysocki" , "John Hubbard" , "Alexandre Courbot" , , Subject: Re: [PATCH v2 1/2] rust: Update PCI binding safety comments and add inline compiler hint From: "Benno Lossin" To: "Danilo Krummrich" X-Mailer: aerc 0.20.1 References: <20250710022415.923972-1-apopple@nvidia.com> In-Reply-To: On Tue Jul 22, 2025 at 1:02 PM CEST, Danilo Krummrich wrote: > On 7/22/25 12:57 PM, Benno Lossin wrote: >> On Tue Jul 22, 2025 at 11:51 AM CEST, Danilo Krummrich wrote: >>> I think they're good, but we're pretty late in the cycle now. That shou= ld be >>> fine though, we can probably take them through the nova tree, or in the= worst >>> case share a tag, if needed. >>> >>> Given that, it would probably be good to add the Guarantee section on a= s_raw(), >>> as proposed by Benno, right away. >>> >>> @Benno: Any proposal on what this section should say? >>=20 >> At a minimum I'd say "The returned pointer is valid.", but that doesn't >> really say for what it's valid... AFAIK you're mostly using this pointer >> to pass it to the C side, in that case, how about: > > It is used for for FFI calls and to access fields of the underlying > struct pci_dev. By "access fields" you mean read-only? --- Cheers, Benno