From: "Danilo Krummrich" <dakr@kernel.org>
To: "Daniel Almeida" <daniel.almeida@collabora.com>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczy´nski" <kwilczynski@kernel.org>,
"Benno Lossin" <lossin@kernel.org>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v7 3/6] rust: irq: add support for non-threaded IRQs and handlers
Date: Wed, 23 Jul 2025 23:31:19 +0200 [thread overview]
Message-ID: <DBJR7DCAPYJ1.39V7X6LNO3ILC@kernel.org> (raw)
In-Reply-To: <5FA40D95-4FB4-4E71-8FDA-3DEC3A7FF0A5@collabora.com>
On Wed Jul 23, 2025 at 6:18 PM CEST, Daniel Almeida wrote:
>> On 23 Jul 2025, at 13:11, Danilo Krummrich <dakr@kernel.org> wrote:
>> On Wed Jul 23, 2025 at 6:07 PM CEST, Daniel Almeida wrote:
>>> On top of that, we can use the
>>> words "interior mutability" somewhere in the example as well to make it even
>>> clearer.
>>
>> You *can* have this example and I encourage it, I think it is valuable. You can
>> have spinlock or mutex for this purpose in threaded handler, no?
>
> Right, but then what goes in the hard-irq part for ThreadedHandler? I guess we
> can leave that one blank then and only touch the data from the threaded part.
>
> If that’s the case, then I think it can work too.
For instance, yes. It's a very common pattern to only have the threaded handler
but not the hard irq handler implemented.
IMHO, for ThreadedHandler the hard irq handler should even have a default blank
implementation.
next prev parent reply other threads:[~2025-07-23 21:31 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 15:16 [PATCH v7 0/6] rust: add support for request_irq Daniel Almeida
2025-07-15 15:16 ` [PATCH v7 1/6] rust: irq: add irq module Daniel Almeida
2025-07-15 15:16 ` [PATCH v7 2/6] rust: irq: add flags module Daniel Almeida
2025-07-16 14:20 ` Daniel Almeida
2025-07-16 14:45 ` Alice Ryhl
2025-07-15 15:16 ` [PATCH v7 3/6] rust: irq: add support for non-threaded IRQs and handlers Daniel Almeida
2025-07-16 23:45 ` kernel test robot
2025-07-17 16:20 ` Daniel Almeida
2025-07-21 14:17 ` Alice Ryhl
2025-07-21 14:45 ` Alice Ryhl
2025-07-21 15:10 ` Daniel Almeida
2025-07-21 15:28 ` Danilo Krummrich
2025-07-21 15:39 ` Daniel Almeida
2025-07-23 4:32 ` Boqun Feng
2025-07-23 4:57 ` Boqun Feng
2025-07-23 5:35 ` Alice Ryhl
2025-07-23 13:51 ` Boqun Feng
2025-07-23 13:55 ` Daniel Almeida
2025-07-23 14:26 ` Boqun Feng
2025-07-23 14:35 ` Danilo Krummrich
2025-07-23 14:56 ` Daniel Almeida
2025-07-23 15:03 ` Danilo Krummrich
2025-07-23 15:44 ` Alice Ryhl
2025-07-23 15:52 ` Danilo Krummrich
2025-07-23 14:54 ` Daniel Almeida
2025-07-23 15:50 ` Boqun Feng
2025-07-23 16:07 ` Daniel Almeida
2025-07-23 16:11 ` Danilo Krummrich
2025-07-23 16:18 ` Daniel Almeida
2025-07-23 21:31 ` Danilo Krummrich [this message]
2025-07-15 15:16 ` [PATCH v7 4/6] rust: irq: add support for threaded " Daniel Almeida
2025-07-21 14:48 ` Alice Ryhl
2025-07-15 15:16 ` [PATCH v7 5/6] rust: platform: add irq accessors Daniel Almeida
2025-07-15 15:16 ` [PATCH v7 6/6] rust: pci: " Daniel Almeida
2025-07-15 15:32 ` [PATCH v7 0/6] rust: add support for request_irq Danilo Krummrich
2025-07-22 11:41 ` Dirk Behme
2025-07-22 14:52 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBJR7DCAPYJ1.39V7X6LNO3ILC@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).