From: "Danilo Krummrich" <dakr@kernel.org>
To: "Jason Gunthorpe" <jgg@nvidia.com>
Cc: "John Hubbard" <jhubbard@nvidia.com>,
"Zhi Wang" <zhiw@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>,
"Surath Mitra" <smitra@nvidia.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Alex Williamson" <alex.williamson@redhat.com>
Subject: Re: [PATCH 0/2] rust: pci: expose is_virtfn() and reject VFs in nova-core
Date: Thu, 02 Oct 2025 14:08:27 +0200 [thread overview]
Message-ID: <DD7TP31FEE92.2E0AKAHUOHVVF@kernel.org> (raw)
In-Reply-To: <20251002120149.GC3195801@nvidia.com>
On Thu Oct 2, 2025 at 2:01 PM CEST, Jason Gunthorpe wrote:
> On Thu, Oct 02, 2025 at 12:52:10AM +0200, Danilo Krummrich wrote:
>
>> Indicating whether the driver supports VFs through a boolean in struct
>> pci_driver is about the same effort (well, maybe slightly more), but solves the
>> problem in a cleaner way since it avoids probe() being called in the first
>> place. Other existing drivers benefit from that as well.
>
> I'm strongly against that idea.
>
> Drivers should not be doing things like this, giving them core code
> helpers to do something they should not do is the wrong direction.
>
> I think this patchset should be simply dropped. Novacore should try to
> boot on a VF and fail if it isn't setup.
Why? What about other upstream drivers that clearly assert that they don't
support VFs? Why would we want to force them to try to boot to a point where
they "naturally" fail?
I think there's nothing wrong with allowing drivers to "officially" assert that
they're intended for PFs only.
Here are a few examples of drivers that have the same requirement:
https://elixir.bootlin.com/linux/v6.17/source/drivers/net/ethernet/realtek/rtase/rtase_main.c#L2195
https://elixir.bootlin.com/linux/v6.17/source/drivers/net/ethernet/intel/ice/ice_main.c#L5266
https://elixir.bootlin.com/linux/v6.17/source/drivers/net/ethernet/intel/igb/igb_main.c#L3221
next prev parent reply other threads:[~2025-10-02 12:08 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 22:07 [PATCH 0/2] rust: pci: expose is_virtfn() and reject VFs in nova-core John Hubbard
2025-09-30 22:07 ` [PATCH 1/2] rust: pci: add is_virtfn(), to check for VFs John Hubbard
2025-10-01 0:30 ` Alistair Popple
2025-09-30 22:07 ` [PATCH 2/2] gpu: nova-core: reject binding to SR-IOV Virtual Functions John Hubbard
2025-10-01 0:33 ` Alistair Popple
2025-10-01 1:26 ` John Hubbard
2025-10-01 0:26 ` [PATCH 0/2] rust: pci: expose is_virtfn() and reject VFs in nova-core Alexandre Courbot
2025-10-01 1:26 ` John Hubbard
2025-10-01 1:39 ` Alexandre Courbot
2025-10-01 1:45 ` John Hubbard
2025-10-01 8:09 ` Zhi Wang
2025-10-01 14:48 ` Jason Gunthorpe
2025-10-01 21:13 ` Zhi Wang
2025-10-02 1:43 ` Alexandre Courbot
2025-10-02 1:50 ` John Hubbard
2025-10-02 11:58 ` Jason Gunthorpe
2025-10-02 12:59 ` Zhi Wang
2025-10-02 13:42 ` Jason Gunthorpe
2025-10-02 14:29 ` Zhi Wang
2025-10-02 14:31 ` Jason Gunthorpe
2025-10-07 6:51 ` Zhi Wang
2025-10-07 10:14 ` Danilo Krummrich
2025-10-07 11:00 ` Zhi Wang
2025-10-07 11:26 ` Jason Gunthorpe
2025-10-01 14:46 ` Jason Gunthorpe
2025-10-01 18:16 ` Alex Williamson
2025-10-01 18:30 ` Jason Gunthorpe
2025-10-01 22:35 ` John Hubbard
2025-10-02 7:41 ` Zhi Wang
2025-10-01 0:29 ` Alistair Popple
2025-10-01 1:22 ` John Hubbard
2025-10-01 10:32 ` Danilo Krummrich
2025-10-01 13:52 ` Zhi Wang
2025-10-01 22:38 ` John Hubbard
2025-10-01 22:52 ` Danilo Krummrich
2025-10-01 23:00 ` John Hubbard
2025-10-01 23:47 ` Joel Fernandes
2025-10-01 23:51 ` John Hubbard
2025-10-01 23:55 ` Danilo Krummrich
2025-10-02 0:48 ` Joel Fernandes
2025-10-02 0:54 ` John Hubbard
2025-10-02 12:05 ` Jason Gunthorpe
2025-10-02 12:01 ` Jason Gunthorpe
2025-10-02 12:08 ` Danilo Krummrich [this message]
2025-10-02 12:32 ` Jason Gunthorpe
2025-10-02 12:41 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DD7TP31FEE92.2E0AKAHUOHVVF@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=alex.williamson@redhat.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=smitra@nvidia.com \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).