* [PATCH v2 2/8] rust: pci: remove redundant `.as_ref()` for `dev_*` print
[not found] <20260123175854.176735-1-gary@kernel.org>
@ 2026-01-23 17:58 ` Gary Guo
2026-01-24 0:38 ` Danilo Krummrich
0 siblings, 1 reply; 2+ messages in thread
From: Gary Guo @ 2026-01-23 17:58 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rafael J. Wysocki, Danilo Krummrich,
Miguel Ojeda, Boqun Feng, Gary Guo, Björn Roy Baron,
Benno Lossin, Andreas Hindborg, Alice Ryhl, Trevor Gross,
Bjorn Helgaas, Krzysztof Wilczyński
Cc: rust-for-linux, linux-kernel, linux-pci
From: Gary Guo <gary@garyguo.net>
This is now handled by the macro itself.
Signed-off-by: Gary Guo <gary@garyguo.net>
---
rust/kernel/pci.rs | 2 +-
rust/kernel/pci/id.rs | 2 +-
samples/rust/rust_driver_pci.rs | 6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/rust/kernel/pci.rs b/rust/kernel/pci.rs
index bea76ca9c3da..3946ca919332 100644
--- a/rust/kernel/pci.rs
+++ b/rust/kernel/pci.rs
@@ -351,7 +351,7 @@ impl Device {
/// // Get an instance of `Vendor`.
/// let vendor = pdev.vendor_id();
/// dev_info!(
- /// pdev.as_ref(),
+ /// pdev,
/// "Device: Vendor={}, Device=0x{:x}\n",
/// vendor,
/// pdev.device_id()
diff --git a/rust/kernel/pci/id.rs b/rust/kernel/pci/id.rs
index 42ffb1bbf87c..50005d176561 100644
--- a/rust/kernel/pci/id.rs
+++ b/rust/kernel/pci/id.rs
@@ -22,7 +22,7 @@
/// fn probe_device(pdev: &pci::Device<Core>) -> Result {
/// let pci_class = pdev.pci_class();
/// dev_info!(
-/// pdev.as_ref(),
+/// pdev,
/// "Detected PCI class: {}\n",
/// pci_class
/// );
diff --git a/samples/rust/rust_driver_pci.rs b/samples/rust/rust_driver_pci.rs
index ef04c6401e6a..d50828b642e5 100644
--- a/samples/rust/rust_driver_pci.rs
+++ b/samples/rust/rust_driver_pci.rs
@@ -75,7 +75,7 @@ fn probe(pdev: &pci::Device<Core>, info: &Self::IdInfo) -> impl PinInit<Self, Er
pin_init::pin_init_scope(move || {
let vendor = pdev.vendor_id();
dev_dbg!(
- pdev.as_ref(),
+ pdev,
"Probe Rust PCI driver sample (PCI ID: {}, 0x{:x}).\n",
vendor,
pdev.device_id()
@@ -91,7 +91,7 @@ fn probe(pdev: &pci::Device<Core>, info: &Self::IdInfo) -> impl PinInit<Self, Er
let bar = bar.access(pdev.as_ref())?;
dev_info!(
- pdev.as_ref(),
+ pdev,
"pci-testdev data-match count: {}\n",
Self::testdev(info, bar)?
);
@@ -112,7 +112,7 @@ fn unbind(pdev: &pci::Device<Core>, this: Pin<&Self>) {
#[pinned_drop]
impl PinnedDrop for SampleDriver {
fn drop(self: Pin<&mut Self>) {
- dev_dbg!(self.pdev.as_ref(), "Remove Rust PCI driver sample.\n");
+ dev_dbg!(self.pdev, "Remove Rust PCI driver sample.\n");
}
}
--
2.51.2
^ permalink raw reply related [flat|nested] 2+ messages in thread